Browse code

Expand disabled pylint rules. (#29162)

* Expand disabled pylint rules.
* Fix pylint and unicode issues in ansible-test.
(cherry picked from commit f88750d66512bb01fa64e9080f3d3fbc9eb9d758)

Matt Clay authored on 2017/09/10 00:59:09
Showing 5 changed files
... ...
@@ -89,7 +89,7 @@ class PylintTest(SanitySingleVersion):
89 89
             messages = []
90 90
 
91 91
         errors = [SanityMessage(
92
-            message=m['message'],
92
+            message=m['message'].replace('\n', ' '),
93 93
             path=m['path'],
94 94
             line=int(m['line']),
95 95
             column=int(m['column']),
... ...
@@ -359,7 +359,7 @@ class TestFailure(TestResult):
359 359
         if self.summary:
360 360
             block = self.summary
361 361
         else:
362
-            block = '\n'.join(str(m) for m in self.messages)
362
+            block = '\n'.join(m.format() for m in self.messages)
363 363
 
364 364
         message = block.strip()
365 365
 
... ...
@@ -374,6 +374,9 @@ class Display(object):
374 374
             message = message.replace(self.clear, color)
375 375
             message = '%s%s%s' % (color, message, self.clear)
376 376
 
377
+        if sys.version_info[0] == 2 and isinstance(message, type(u'')):
378
+            message = message.encode('utf-8')
379
+
377 380
         print(message, file=fd)
378 381
         fd.flush()
379 382
 
... ...
@@ -1,24 +1,100 @@
1
+abstract-method
1 2
 access-member-before-definition
3
+anomalous-backslash-in-string
4
+anomalous-unicode-escape-in-string
5
+arguments-differ
2 6
 assignment-from-no-return
3
-C
7
+attribute-defined-outside-init
8
+bad-continuation
9
+bad-format-string
10
+bad-indentation
11
+bad-mcs-classmethod-argument
12
+bad-open-mode
13
+bad-whitespace
14
+bare-except
15
+blacklisted-name
16
+broad-except
17
+cell-var-from-loop
18
+consider-iterating-dictionary
19
+consider-using-enumerate
20
+dangerous-default-value
21
+deprecated-method
22
+deprecated-module
23
+duplicate-key
24
+eval-used
25
+exec-used
26
+expression-not-assigned
27
+fixme
4 28
 function-redefined
29
+global-at-module-level
30
+global-statement
31
+global-variable-not-assigned
32
+global-variable-undefined
5 33
 import-error
34
+import-self
35
+invalid-name
36
+line-too-long
6 37
 locally-disabled
7
-locally-enabled
38
+logging-format-interpolation
39
+logging-not-lazy
40
+lost-exception
8 41
 method-hidden
42
+misplaced-comparison-constant
43
+missing-docstring
9 44
 no-member
45
+no-name-in-module
46
+no-self-use
10 47
 no-value-for-parameter
11 48
 non-iterator-returned
12
-no-name-in-module
13 49
 not-a-mapping
14 50
 not-an-iterable
15 51
 not-callable
16
-R
52
+pointless-statement
53
+pointless-string-statement
54
+protected-access
17 55
 raising-bad-type
18
-raising-non-exception
56
+redefined-builtin
57
+redefined-outer-name
58
+redefined-variable-type
59
+redundant-unittest-assert
60
+reimported
61
+signature-differs
62
+simplifiable-if-statement
63
+super-init-not-called
64
+superfluous-parens
65
+suppressed-message
66
+too-few-public-methods
67
+too-many-ancestors
68
+too-many-arguments
69
+too-many-boolean-expressions
70
+too-many-branches
19 71
 too-many-function-args
72
+too-many-instance-attributes
73
+too-many-lines
74
+too-many-locals
75
+too-many-nested-blocks
76
+too-many-public-methods
77
+too-many-return-statements
78
+too-many-statements
79
+trailing-newlines
80
+undefined-loop-variable
20 81
 unexpected-keyword-arg
82
+ungrouped-imports
83
+unidiomatic-typecheck
84
+unnecessary-lambda
85
+unnecessary-pass
86
+unneeded-not
87
+unreachable
21 88
 unsubscriptable-object
22 89
 unsupported-membership-test
90
+unused-argument
91
+unused-import
92
+unused-variable
93
+unused-wildcard-import
23 94
 used-before-assignment
24
-W
95
+useless-else-on-loop
96
+useless-suppression
97
+using-constant-test
98
+wildcard-import
99
+wrong-import-order
100
+wrong-import-position
... ...
@@ -1 +0,0 @@
1
-#wildcard-import