Browse code

Fix config timeout issue for network modules (#28261)

* Fix config timeout issue for network modules

* Re-enable network test

* Remove unwanted persistent connection timer

* Minor changes in description

Ganesh Nalawade authored on 2017/08/16 23:55:39
Showing 3 changed files
... ...
@@ -1279,14 +1279,6 @@ PARAMIKO_RECORD_HOST_KEYS:
1279 1279
   - {key: record_host_keys, section: paramiko_connection}
1280 1280
   type: boolean
1281 1281
   yaml: {key: paramiko_connection.record_host_keys}
1282
-PERSISTENT_CONNECT_INTERVAL:
1283
-  default: 1
1284
-  description: 'TODO: write it'
1285
-  env: [{name: ANSIBLE_PERSISTENT_CONNECT_INTERVAL}]
1286
-  ini:
1287
-  - {key: connect_interval, section: persistent_connection}
1288
-  type: integer
1289
-  yaml: {key: persistent_connection.connect_interval}
1290 1282
 PERSISTENT_CONTROL_PATH_DIR:
1291 1283
   default: ~/.ansible/pc
1292 1284
   description: 'TODO: write it'
... ...
@@ -1294,17 +1286,9 @@ PERSISTENT_CONTROL_PATH_DIR:
1294 1294
   ini:
1295 1295
   - {key: control_path_dir, section: persistent_connection}
1296 1296
   yaml: {key: persistent_connection.control_path_dir}
1297
-PERSISTENT_CONNECT_RETRIES:
1298
-  default: 30
1299
-  description: 'TODO: write it'
1300
-  env: [{name: ANSIBLE_PERSISTENT_CONNECT_RETRIES}]
1301
-  ini:
1302
-  - {key: connect_retries, section: persistent_connection}
1303
-  type: integer
1304
-  yaml: {key: persistent_connection.connect_retries}
1305 1297
 PERSISTENT_CONNECT_TIMEOUT:
1306 1298
   default: 30
1307
-  description: 'TODO: write it'
1299
+  description: This controls how long the persistent connection will remain idle before it is destroyed.
1308 1300
   env: [{name: ANSIBLE_PERSISTENT_CONNECT_TIMEOUT}]
1309 1301
   ini:
1310 1302
   - {key: connect_timeout, section: persistent_connection}
... ...
@@ -1312,21 +1296,19 @@ PERSISTENT_CONNECT_TIMEOUT:
1312 1312
   yaml: {key: persistent_connection.connect_timeout}
1313 1313
 PERSISTENT_CONNECT_RETRY_TIMEOUT:
1314 1314
   default: 15
1315
-  desc: 'TODO: write it'
1315
+  description: This contorls the retry timeout for presistent connection to connect to the local domain socket.
1316 1316
   env: [{name: ANSIBLE_PERSISTENT_CONNECT_RETRY_TIMEOUT}]
1317 1317
   ini:
1318 1318
   - {key: connect_retry_timeout, section: persistent_connection}
1319
-  value_type: integer
1320
-  vars: []
1319
+  type: integer
1321 1320
   yaml: {key: persistent_connection.connect_retry_timeout}
1322 1321
 PERSISTENT_COMMAND_TIMEOUT:
1323 1322
   default: 10
1324
-  desc: 'TODO: write it'
1323
+  description: This controls the amount of time to wait for response from remote device before timing out presistent connection.
1325 1324
   env: [{name: ANSIBLE_PERSISTENT_COMMAND_TIMEOUT}]
1326 1325
   ini:
1327 1326
   - {key: command_timeout, section: persistent_connection}
1328
-  value_type: integer
1329
-  vars: []
1327
+  type: integer
1330 1328
   yaml: {key: persistent_connection.command_timeout}
1331 1329
 RETRY_FILES_ENABLED:
1332 1330
   default: True
... ...
@@ -340,7 +340,7 @@ class PlayContext(Base):
340 340
         #  general flags (should we move out?)
341 341
         # for flag in ('connection', 'remote_user', 'private_key_file', 'verbosity', 'force_handlers', 'step', 'start_at_task', 'diff'):
342 342
         #  should only be 'non plugin' flags
343
-        for flag in ('connection', 'private_key_file', 'verbosity', 'force_handlers', 'step', 'start_at_task', 'diff'):
343
+        for flag in ('connection', 'remote_user', 'private_key_file', 'verbosity', 'force_handlers', 'step', 'start_at_task', 'diff'):
344 344
             attribute = getattr(options, flag, False)
345 345
             if attribute:
346 346
                 setattr(self, flag, attribute)
... ...
@@ -24,6 +24,8 @@ matrix:
24 24
 
25 25
     - env: TEST=windows
26 26
 
27
+    - env: TEST=network
28
+
27 29
     - env: TEST=linux/centos6/1
28 30
     - env: TEST=linux/centos7/1
29 31
     - env: TEST=linux/fedora24/1