Browse code

remove unused ssh pipelining setters

fixes #31125

(cherry picked from commit 101377768bf12840fbb50a4fce4970cc851c8a37)

Brian Coca authored on 2017/10/02 22:17:08
Showing 4 changed files
... ...
@@ -73,6 +73,7 @@ Ansible Changes By Release
73 73
 * Fix for win_msg to document and show error when message is greater than 255 characters
74 74
 * Fix for win_dotnet_ngen to work after recent regression
75 75
 * fixed backwards compat method for config
76
+* removed docs for prematurely added ssh specific pipelining settings
76 77
 
77 78
 
78 79
 <a id="2.4"></a>
... ...
@@ -210,19 +210,6 @@ ANSIBLE_SSH_EXECUTABLE:
210 210
   - {key: ssh_executable, section: ssh_connection}
211 211
   yaml: {key: ssh_connection.ssh_executable}
212 212
   version_added: "2.2"
213
-ANSIBLE_SSH_PIPELINING:
214
-  # TODO: move to ssh plugin
215
-  default: False
216
-  description:
217
-    - Pipelining reduces the number of SSH operations required to execute a module on the remote server,
218
-      by executing many Ansible modules without actual file transfer.
219
-    - This can result in a very significant performance improvement when enabled.
220
-    - "However this conflicts with privilege escalation (become). For example, when using 'sudo:' operations you must first disable 'requiretty' in /etc/sudoers on all managed hosts, which is why it is disabled by default."
221
-  env: [{name: ANSIBLE_SSH_PIPELINING}]
222
-  ini:
223
-  - {key: pipelining, section: ssh_connection}
224
-  type: boolean
225
-  yaml: {key: ssh_connection.pipelining}
226 213
 ANSIBLE_SSH_RETRIES:
227 214
   # TODO: move to ssh plugin
228 215
   default: 0
... ...
@@ -116,11 +116,18 @@ DOCUMENTATION = '''
116 116
             - However this conflicts with privilege escalation (become).
117 117
               For example, when using sudo operations you must first disable 'requiretty' in the sudoers file for the target hosts,
118 118
               which is why this feature is disabled by default.
119
-          env: [{name: ANSIBLE_SSH_PIPELINING}]
119
+          env:
120
+            - name: ANSIBLE_PIPELINING
121
+            #- name: ANSIBLE_SSH_PIPELINING
120 122
           ini:
121
-          - {key: pipelining, section: ssh_connection}
123
+            - section: defaults
124
+              key: pipelining
125
+            #- section: ssh_connection
126
+            #  key: pipelining
122 127
           type: boolean
123
-          vars: [{name: ansible_ssh_pipelining}]
128
+          vars:
129
+            - name: ansible_pipelining
130
+            - name: ansible_ssh_pipelining
124 131
       private_key_file:
125 132
           description:
126 133
               - Path to private key file to use for authentication
... ...
@@ -58,7 +58,7 @@ $(CREDENTIALS_FILE):
58 58
 	@exit 1
59 59
 
60 60
 amazon: $(CREDENTIALS_FILE)
61
-	ANSIBLE_HOST_KEY_CHECKING=False ANSIBLE_SSH_PIPELINING=no BOTO_CONFIG=/dev/null ansible-playbook amazon.yml -i $(INVENTORY) -e @$(VARS_FILE) $(CREDENTIALS_ARG) -e "resource_prefix=$(CLOUD_RESOURCE_PREFIX)" -v $(TEST_FLAGS) ; \
61
+	ANSIBLE_HOST_KEY_CHECKING=False ANSIBLE_PIPELINING=no BOTO_CONFIG=/dev/null ansible-playbook amazon.yml -i $(INVENTORY) -e @$(VARS_FILE) $(CREDENTIALS_ARG) -e "resource_prefix=$(CLOUD_RESOURCE_PREFIX)" -v $(TEST_FLAGS) ; \
62 62
     RC=$$? ; \
63 63
     CLOUD_RESOURCE_PREFIX="$(CLOUD_RESOURCE_PREFIX)" make amazon_cleanup ; \
64 64
     exit $$RC;