Browse code

Merge "Remove fixup_virtualenv"

Zuul authored on 2020/04/10 01:00:35
Showing 1 changed files
... ...
@@ -207,39 +207,9 @@ function fixup_suse {
207 207
     sudo zypper up -y p11-kit ca-certificates-mozilla
208 208
 }
209 209
 
210
-# The version of pip(1.5.4) supported by python-virtualenv(1.11.4) has
211
-# connection issues under proxy so re-install the latest version using
212
-# pip. To avoid having pip's virtualenv overwritten by the distro's
213
-# package (e.g. due to installing a distro package with a dependency
214
-# on python-virtualenv), first install the distro python-virtualenv
215
-# to satisfy any dependencies then use pip to overwrite it.
216
-
217
-# ... but, for infra builds, the pip-and-virtualenv [1] element has
218
-# already done this to ensure the latest pip, virtualenv and
219
-# setuptools on the base image for all platforms.  It has also added
220
-# the packages to the yum/dnf ignore list to prevent them being
221
-# overwritten with old versions.  F26 and dnf 2.0 has changed
222
-# behaviour that means re-installing python-virtualenv fails [2].
223
-# Thus we do a quick check if we're in the infra environment by
224
-# looking for the mirror config script before doing this, and just
225
-# skip it if so.
226
-
227
-# [1] https://opendev.org/openstack/diskimage-builder/src/branch/master/ \
228
-#        diskimage_builder/elements/pip-and-virtualenv/ \
229
-#            install.d/pip-and-virtualenv-source-install/04-install-pip
230
-# [2] https://bugzilla.redhat.com/show_bug.cgi?id=1477823
231
-
232
-function fixup_virtualenv {
233
-    if [[ ! -f /etc/ci/mirror_info.sh ]]; then
234
-        install_package python-virtualenv
235
-        pip_install -U --force-reinstall virtualenv
236
-    fi
237
-}
238
-
239 210
 function fixup_all {
240 211
     fixup_keystone
241 212
     fixup_ubuntu
242 213
     fixup_fedora
243 214
     fixup_suse
244
-    fixup_virtualenv
245 215
 }