Browse code

Merge "Rename screen logfiles"

Jenkins authored on 2015/01/20 23:24:00
Showing 3 changed files
... ...
@@ -1278,8 +1278,8 @@ function _run_process {
1278 1278
     exec 6>&-
1279 1279
 
1280 1280
     if [[ -n ${SCREEN_LOGDIR} ]]; then
1281
-        exec 1>&${SCREEN_LOGDIR}/screen-${service}.${CURRENT_LOG_TIME}.log 2>&1
1282
-        ln -sf ${SCREEN_LOGDIR}/screen-${service}.${CURRENT_LOG_TIME}.log ${SCREEN_LOGDIR}/screen-${service}.log
1281
+        exec 1>&${SCREEN_LOGDIR}/screen-${service}.log.${CURRENT_LOG_TIME} 2>&1
1282
+        ln -sf ${SCREEN_LOGDIR}/screen-${service}.log.${CURRENT_LOG_TIME} ${SCREEN_LOGDIR}/screen-${service}.log
1283 1283
 
1284 1284
         # TODO(dtroyer): Hack to get stdout from the Python interpreter for the logs.
1285 1285
         export PYTHONUNBUFFERED=1
... ...
@@ -1363,9 +1363,9 @@ function screen_process {
1363 1363
     screen -S $SCREEN_NAME -X screen -t $name
1364 1364
 
1365 1365
     if [[ -n ${SCREEN_LOGDIR} ]]; then
1366
-        screen -S $SCREEN_NAME -p $name -X logfile ${SCREEN_LOGDIR}/screen-${name}.${CURRENT_LOG_TIME}.log
1366
+        screen -S $SCREEN_NAME -p $name -X logfile ${SCREEN_LOGDIR}/screen-${name}.log.${CURRENT_LOG_TIME}
1367 1367
         screen -S $SCREEN_NAME -p $name -X log on
1368
-        ln -sf ${SCREEN_LOGDIR}/screen-${name}.${CURRENT_LOG_TIME}.log ${SCREEN_LOGDIR}/screen-${name}.log
1368
+        ln -sf ${SCREEN_LOGDIR}/screen-${name}.log.${CURRENT_LOG_TIME} ${SCREEN_LOGDIR}/screen-${name}.log
1369 1369
     fi
1370 1370
 
1371 1371
     # sleep to allow bash to be ready to be send the command - we are
... ...
@@ -1411,7 +1411,7 @@ function screen_rc {
1411 1411
         echo "stuff \"$2$NL\"" >> $SCREENRC
1412 1412
 
1413 1413
         if [[ -n ${SCREEN_LOGDIR} ]]; then
1414
-            echo "logfile ${SCREEN_LOGDIR}/screen-${1}.${CURRENT_LOG_TIME}.log" >>$SCREENRC
1414
+            echo "logfile ${SCREEN_LOGDIR}/screen-${1}.log.${CURRENT_LOG_TIME}" >>$SCREENRC
1415 1415
             echo "log on" >>$SCREENRC
1416 1416
         fi
1417 1417
     fi
... ...
@@ -1523,8 +1523,8 @@ function _old_run_process {
1523 1523
     exec 6>&-
1524 1524
 
1525 1525
     if [[ -n ${SCREEN_LOGDIR} ]]; then
1526
-        exec 1>&${SCREEN_LOGDIR}/screen-${1}.${CURRENT_LOG_TIME}.log 2>&1
1527
-        ln -sf ${SCREEN_LOGDIR}/screen-${1}.${CURRENT_LOG_TIME}.log ${SCREEN_LOGDIR}/screen-${1}.log
1526
+        exec 1>&${SCREEN_LOGDIR}/screen-${1}.log.${CURRENT_LOG_TIME} 2>&1
1527
+        ln -sf ${SCREEN_LOGDIR}/screen-${1}.log.${CURRENT_LOG_TIME} ${SCREEN_LOGDIR}/screen-${1}.log
1528 1528
 
1529 1529
         # TODO(dtroyer): Hack to get stdout from the Python interpreter for the logs.
1530 1530
         export PYTHONUNBUFFERED=1
... ...
@@ -20,7 +20,7 @@ set +o xtrace
20 20
 # Defaults
21 21
 # --------
22 22
 # for DSTAT logging
23
-DSTAT_FILE=${DSTAT_FILE:-"dstat.txt"}
23
+DSTAT_FILE=${DSTAT_FILE:-"dstat.log"}
24 24
 
25 25
 
26 26
 # start_dstat() - Start running processes, including screen
... ...
@@ -379,15 +379,14 @@ if [[ -n "$LOGFILE" || -n "$SCREEN_LOGDIR" ]]; then
379 379
 fi
380 380
 
381 381
 if [[ -n "$LOGFILE" ]]; then
382
-    # First clean up old log files.  Use the user-specified ``LOGFILE``
383
-    # as the template to search for, appending '.*' to match the date
384
-    # we added on earlier runs.
385
-    LOGDIR=$(dirname "$LOGFILE")
386
-    LOGFILENAME=$(basename "$LOGFILE")
387
-    mkdir -p $LOGDIR
388
-    find $LOGDIR -maxdepth 1 -name $LOGFILENAME.\* -mtime +$LOGDAYS -exec rm {} \;
382
+    # Clean up old log files.  Append '.*' to the user-specified
383
+    # ``LOGFILE`` to match the date in the search template.
384
+    local logfile_dir="${LOGFILE%/*}"           # dirname
385
+    local logfile_name="${LOGFILE##*/}"         # basename
386
+    mkdir -p $logfile_dir
387
+    find $logfile_dir -maxdepth 1 -name $logfile_name.\* -mtime +$LOGDAYS -exec rm {} \;
389 388
     LOGFILE=$LOGFILE.${CURRENT_LOG_TIME}
390
-    SUMFILE=$LOGFILE.${CURRENT_LOG_TIME}.summary
389
+    SUMFILE=$LOGFILE.summary.${CURRENT_LOG_TIME}
391 390
 
392 391
     # Redirect output according to config
393 392
 
... ...
@@ -408,8 +407,8 @@ if [[ -n "$LOGFILE" ]]; then
408 408
 
409 409
     echo_summary "stack.sh log $LOGFILE"
410 410
     # Specified logfile name always links to the most recent log
411
-    ln -sf $LOGFILE $LOGDIR/$LOGFILENAME
412
-    ln -sf $SUMFILE $LOGDIR/$LOGFILENAME.summary
411
+    ln -sf $LOGFILE $logfile_dir/$logfile_name
412
+    ln -sf $SUMFILE $logfile_dir/$logfile_name.summary
413 413
 else
414 414
     # Set up output redirection without log files
415 415
     # Set fd 3 to a copy of stdout. So we can set fd 1 without losing