Browse code

Remove deprecated vars

These have been emitting deprecated warnings for over a full release cycle:
Q_AGENT_EXTRA_AGENT_OPTS, Q_AGENT_EXTRA_SRV_OPTS, CINDER_MULTI_LVM_BACKEND

Change-Id: I3aa5cabd6ce3a0072cba08bbca1ad23d4a831219

Dean Troyer authored on 2014/12/19 07:31:34
Showing 7 changed files
... ...
@@ -215,21 +215,6 @@ in the near future.  The ``local.conf`` headers for the replacements are:
215 215
     [[post-config|/$Q_PLUGIN_CONF_FILE]]
216 216
     [linuxbridge]   # or [ovs]
217 217
 
218
-* ``Q_AGENT_EXTRA_AGENT_OPTS``:
219
-
220
-    [[post-config|/$Q_PLUGIN_CONF_FILE]]
221
-    [agent]
222
-
223
-* ``Q_AGENT_EXTRA_SRV_OPTS``:
224
-
225
-    [[post-config|/$Q_PLUGIN_CONF_FILE]]
226
-    [linuxbridge]   # or [ovs]
227
-
228
-* ``Q_SRV_EXTRA_DEFAULT_OPTS``:
229
-
230
-    [[post-config|$NEUTRON_CONF]]
231
-    [DEFAULT]
232
-
233 218
 Example extra config in `local.conf`:
234 219
 
235 220
     [[post-config|/$Q_PLUGIN_CONF_FILE]]
... ...
@@ -65,21 +65,14 @@ else
65 65
 fi
66 66
 
67 67
 
68
-# Maintain this here for backward-compatibility with the old configuration
69
-# DEPRECATED: Use CINDER_ENABLED_BACKENDS instead
70
-# Support for multi lvm backend configuration (default is no support)
71
-CINDER_MULTI_LVM_BACKEND=$(trueorfalse False CINDER_MULTI_LVM_BACKEND)
72
-
73 68
 # Default backends
74 69
 # The backend format is type:name where type is one of the supported backend
75 70
 # types (lvm, nfs, etc) and name is the identifier used in the Cinder
76 71
 # configuration and for the volume type name.  Multiple backends are
77 72
 # comma-separated.
78
-if [[ $CINDER_MULTI_LVM_BACKEND == "False" ]]; then
79
-    CINDER_ENABLED_BACKENDS=${CINDER_ENABLED_BACKENDS:-lvm:${DEFAULT_VOLUME_GROUP_NAME##*-}}
80
-else
81
-    CINDER_ENABLED_BACKENDS=${CINDER_ENABLED_BACKENDS:-lvm:${DEFAULT_VOLUME_GROUP_NAME##*-},lvm:cinder}
82
-fi
73
+# The old ``CINDER_MULTI_LVM_BACKEND=True`` setting had a default of:
74
+# CINDER_ENABLED_BACKENDS=${CINDER_ENABLED_BACKENDS:-lvm:lvmdriver-1,lvm:lvmdriver-2}
75
+CINDER_ENABLED_BACKENDS=${CINDER_ENABLED_BACKENDS:-lvm:lvmdriver-1}
83 76
 
84 77
 
85 78
 # Should cinder perform secure deletion of volumes?
... ...
@@ -50,20 +50,6 @@ function neutron_plugin_configure_plugin_agent {
50 50
     fi
51 51
     AGENT_BINARY="$NEUTRON_BIN_DIR/neutron-linuxbridge-agent"
52 52
     iniset /$Q_PLUGIN_CONF_FILE agent tunnel_types $Q_TUNNEL_TYPES
53
-    # Define extra "AGENT" configuration options when q-agt is configured by defining
54
-    # the array ``Q_AGENT_EXTRA_AGENT_OPTS``.
55
-    # For Example: ``Q_AGENT_EXTRA_AGENT_OPTS=(foo=true bar=2)``
56
-    for I in "${Q_AGENT_EXTRA_AGENT_OPTS[@]}"; do
57
-        # Replace the first '=' with ' ' for iniset syntax
58
-        iniset /$Q_PLUGIN_CONF_FILE agent ${I/=/ }
59
-    done
60
-    # Define extra "LINUX_BRIDGE" configuration options when q-agt is configured by defining
61
-    # the array ``Q_AGENT_EXTRA_SRV_OPTS``.
62
-    # For Example: ``Q_AGENT_EXTRA_SRV_OPTS=(foo=true bar=2)``
63
-    for I in "${Q_AGENT_EXTRA_SRV_OPTS[@]}"; do
64
-        # Replace the first '=' with ' ' for iniset syntax
65
-        iniset /$Q_PLUGIN_CONF_FILE linux_bridge ${I/=/ }
66
-    done
67 53
 }
68 54
 
69 55
 function neutron_plugin_setup_interface_driver {
... ...
@@ -84,13 +84,6 @@ function neutron_plugin_configure_plugin_agent {
84 84
     AGENT_BINARY="$NEUTRON_BIN_DIR/neutron-ofagent-agent"
85 85
 
86 86
     iniset /$Q_PLUGIN_CONF_FILE agent tunnel_types $Q_TUNNEL_TYPES
87
-    # Define extra "AGENT" configuration options when q-agt is configured by defining
88
-    # defining the array ``Q_AGENT_EXTRA_AGENT_OPTS``.
89
-    # For Example: ``Q_AGENT_EXTRA_AGENT_OPTS=(foo=true bar=2)``
90
-    for I in "${Q_AGENT_EXTRA_AGENT_OPTS[@]}"; do
91
-        # Replace the first '=' with ' ' for iniset syntax
92
-        iniset /$Q_PLUGIN_CONF_FILE agent ${I/=/ }
93
-    done
94 87
 }
95 88
 
96 89
 function neutron_plugin_setup_interface_driver {
... ...
@@ -104,20 +104,6 @@ function neutron_plugin_configure_plugin_agent {
104 104
         iniset "/$Q_PLUGIN_CONF_FILE.domU" agent root_helper "$Q_RR_COMMAND"
105 105
     fi
106 106
     iniset /$Q_PLUGIN_CONF_FILE agent tunnel_types $Q_TUNNEL_TYPES
107
-    # Define extra "AGENT" configuration options when q-agt is configured by defining
108
-    # defining the array ``Q_AGENT_EXTRA_AGENT_OPTS``.
109
-    # For Example: ``Q_AGENT_EXTRA_AGENT_OPTS=(foo=true bar=2)``
110
-    for I in "${Q_AGENT_EXTRA_AGENT_OPTS[@]}"; do
111
-        # Replace the first '=' with ' ' for iniset syntax
112
-        iniset /$Q_PLUGIN_CONF_FILE agent ${I/=/ }
113
-    done
114
-    # Define extra "OVS" configuration options when q-agt is configured by defining
115
-    # defining the array ``Q_AGENT_EXTRA_SRV_OPTS``.
116
-    # For Example: ``Q_AGENT_EXTRA_SRV_OPTS=(foo=true bar=2)``
117
-    for I in "${Q_AGENT_EXTRA_SRV_OPTS[@]}"; do
118
-        # Replace the first '=' with ' ' for iniset syntax
119
-        iniset /$Q_PLUGIN_CONF_FILE ovs ${I/=/ }
120
-    done
121 107
 }
122 108
 
123 109
 function neutron_plugin_setup_interface_driver {
... ...
@@ -29,7 +29,6 @@
29 29
 # - ``USE_BLOCK_MIGRATION_FOR_LIVE_MIGRATION``
30 30
 # - ``DEFAULT_INSTANCE_TYPE``
31 31
 # - ``DEFAULT_INSTANCE_USER``
32
-# - ``CINDER_MULTI_LVM_BACKEND``
33 32
 # - ``CINDER_ENABLED_BACKENDS``
34 33
 #
35 34
 # ``stack.sh`` calls the entry points in this order:
... ...
@@ -1329,57 +1329,6 @@ if [[ -n "$DEPRECATED_TEXT" ]]; then
1329 1329
     echo_summary "WARNING: $DEPRECATED_TEXT"
1330 1330
 fi
1331 1331
 
1332
-if is_service_enabled neutron; then
1333
-    # TODO(dtroyer): Remove Q_AGENT_EXTRA_AGENT_OPTS after stable/juno branch is cut
1334
-    if [[ -n "$Q_AGENT_EXTRA_AGENT_OPTS" ]]; then
1335
-        echo ""
1336
-        echo_summary "WARNING: Q_AGENT_EXTRA_AGENT_OPTS is used"
1337
-        echo "You are using Q_AGENT_EXTRA_AGENT_OPTS to pass configuration into $NEUTRON_CONF."
1338
-        echo "Please convert that configuration in localrc to a $NEUTRON_CONF section in local.conf:"
1339
-        echo "Q_AGENT_EXTRA_AGENT_OPTS will be removed early in the 'K' development cycle"
1340
-        echo "
1341
-[[post-config|/\$Q_PLUGIN_CONF_FILE]]
1342
-[DEFAULT]
1343
-"
1344
-        for I in "${Q_AGENT_EXTRA_AGENT_OPTS[@]}"; do
1345
-            # Replace the first '=' with ' ' for iniset syntax
1346
-            echo ${I}
1347
-        done
1348
-    fi
1349
-
1350
-    # TODO(dtroyer): Remove Q_AGENT_EXTRA_SRV_OPTS after stable/juno branch is cut
1351
-    if [[ -n "$Q_AGENT_EXTRA_SRV_OPTS" ]]; then
1352
-        echo ""
1353
-        echo_summary "WARNING: Q_AGENT_EXTRA_SRV_OPTS is used"
1354
-        echo "You are using Q_AGENT_EXTRA_SRV_OPTS to pass configuration into $NEUTRON_CONF."
1355
-        echo "Please convert that configuration in localrc to a $NEUTRON_CONF section in local.conf:"
1356
-        echo "Q_AGENT_EXTRA_AGENT_OPTS will be removed early in the 'K' development cycle"
1357
-        echo "
1358
-[[post-config|/\$Q_PLUGIN_CONF_FILE]]
1359
-[DEFAULT]
1360
-"
1361
-        for I in "${Q_AGENT_EXTRA_SRV_OPTS[@]}"; do
1362
-            # Replace the first '=' with ' ' for iniset syntax
1363
-            echo ${I}
1364
-        done
1365
-    fi
1366
-fi
1367
-
1368
-if is_service_enabled cinder; then
1369
-    # TODO(dtroyer): Remove CINDER_MULTI_LVM_BACKEND after stable/juno branch is cut
1370
-    if [[ "$CINDER_MULTI_LVM_BACKEND" = "True" ]]; then
1371
-        echo ""
1372
-        echo_summary "WARNING: CINDER_MULTI_LVM_BACKEND is used"
1373
-        echo "You are using CINDER_MULTI_LVM_BACKEND to configure Cinder's multiple LVM backends"
1374
-        echo "Please convert that configuration in local.conf to use CINDER_ENABLED_BACKENDS."
1375
-        echo "CINDER_MULTI_LVM_BACKEND will be removed early in the 'K' development cycle"
1376
-        echo "
1377
-[[local|localrc]]
1378
-CINDER_ENABLED_BACKENDS=lvm:lvmdriver-1,lvm:lvmdriver-2
1379
-"
1380
-    fi
1381
-fi
1382
-
1383 1332
 # Indicate how long this took to run (bash maintained variable ``SECONDS``)
1384 1333
 echo_summary "stack.sh completed in $SECONDS seconds."
1385 1334