Browse code

Revert "Disable Cinder v1 API support by default"

There has been a ton of fall out from this change, and I
think it's been premature. We should revert and try again
when more of the client space supports this.

This reverts commit a29434460e869b7bb397044d8f073531e4ee112d.

Change-Id: I1658dc48a024627be0fdb39c46137aaa3d9b911a

Sean Dague authored on 2015/09/30 19:33:57
Showing 3 changed files
... ...
@@ -587,13 +587,6 @@ with ``VOLUME_BACKING_FILE_SIZE``.
587 587
         VOLUME_BACKING_FILE_SIZE=10250M
588 588
 
589 589
 
590
-Cinder v1 API is depricated and disabled by default. You can enable v1 API by
591
-setting ``CINDER_ENABLE_V1_API`` to ``True``.
592
-
593
-    ::
594
-        CINDER_ENABLE_V1_API=True
595
-
596
-
597 590
 Keystone
598 591
 ~~~~~~~~
599 592
 
... ...
@@ -27,9 +27,6 @@ set +o xtrace
27 27
 # Defaults
28 28
 # --------
29 29
 
30
-# NOTE (e0ne): Cinder API v1 is deprecated and will be disabled by default.
31
-CINDER_ENABLE_V1_API=$(trueorfalse False CINDER_ENABLE_V1_API)
32
-
33 30
 # set up default driver
34 31
 CINDER_DRIVER=${CINDER_DRIVER:-default}
35 32
 CINDER_PLUGINS=$TOP_DIR/lib/cinder_plugins
... ...
@@ -228,12 +225,9 @@ function configure_cinder {
228 228
     iniset $CINDER_CONF oslo_concurrency lock_path $CINDER_STATE_PATH
229 229
     iniset $CINDER_CONF DEFAULT periodic_interval $CINDER_PERIODIC_INTERVAL
230 230
     # NOTE(thingee): Cinder V1 API is deprecated and defaults to off as of
231
-    # Juno.
232
-    if [[ ${CINDER_ENABLE_V1_API} = True ]]; then
233
-        iniset $CINDER_CONF DEFAULT enable_v1_api true
234
-    else
235
-        iniset $CINDER_CONF DEFAULT enable_v1_api false
236
-    fi
231
+    # Juno. Keep it enabled so we can continue testing while it's still
232
+    # supported.
233
+    iniset $CINDER_CONF DEFAULT enable_v1_api true
237 234
 
238 235
     iniset $CINDER_CONF DEFAULT os_region_name "$REGION_NAME"
239 236
 
... ...
@@ -332,13 +326,12 @@ function create_cinder_accounts {
332 332
 
333 333
         if [[ "$KEYSTONE_CATALOG_BACKEND" = 'sql' ]]; then
334 334
 
335
-            if [[ ${CINDER_ENABLE_V1_API} = True ]]; then
336
-                get_or_create_service "cinder" "volume" "Cinder Volume Service"
337
-                get_or_create_endpoint "volume" "$REGION_NAME" \
338
-                    "$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT/v1/\$(tenant_id)s" \
339
-                    "$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT/v1/\$(tenant_id)s" \
340
-                    "$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT/v1/\$(tenant_id)s"
341
-            fi
335
+            get_or_create_service "cinder" "volume" "Cinder Volume Service"
336
+            get_or_create_endpoint "volume" "$REGION_NAME" \
337
+                "$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT/v1/\$(tenant_id)s" \
338
+                "$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT/v1/\$(tenant_id)s" \
339
+                "$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT/v1/\$(tenant_id)s"
340
+
342 341
             get_or_create_service "cinderv2" "volumev2" "Cinder Volume Service V2"
343 342
             get_or_create_endpoint "volumev2" "$REGION_NAME" \
344 343
                 "$CINDER_SERVICE_PROTOCOL://$CINDER_SERVICE_HOST:$CINDER_SERVICE_PORT/v2/\$(tenant_id)s" \
... ...
@@ -489,7 +482,9 @@ function create_volume_types {
489 489
         local be be_name
490 490
         for be in ${CINDER_ENABLED_BACKENDS//,/ }; do
491 491
             be_name=${be##*:}
492
-            openstack volume type create --os-volume-api-version 2 --property volume_backend_name="${be_name}" ${be_name}
492
+            # FIXME(jamielennox): Remove --os-volume-api-version pinning when
493
+            # osc supports volume type create on v2 api. bug #1475060
494
+            openstack volume type create --os-volume-api-version 1 --property volume_backend_name="${be_name}" ${be_name}
493 495
         done
494 496
     fi
495 497
 }
... ...
@@ -494,15 +494,6 @@ function configure_tempest {
494 494
         iniset $TEMPEST_CONFIG volume-feature-enabled backup False
495 495
     fi
496 496
 
497
-    # Use only Cinder API v2
498
-    if [[ ${CINDER_ENABLE_V1_API} = True ]]; then
499
-        iniset $TEMPEST_CONFIG volume-feature-enabled api_v1 True
500
-        iniset $TEMPEST_CONFIG volume catalog_type volume
501
-    else
502
-        iniset $TEMPEST_CONFIG volume-feature-enabled api_v1 False
503
-        iniset $TEMPEST_CONFIG volume catalog_type volumev2
504
-    fi
505
-
506 497
     # Using ``CINDER_ENABLED_BACKENDS``
507 498
     if [[ -n "$CINDER_ENABLED_BACKENDS" ]] && [[ $CINDER_ENABLED_BACKENDS =~ .*,.* ]]; then
508 499
         iniset $TEMPEST_CONFIG volume-feature-enabled multi_backend "True"