Browse code

Restrict enabling the manage_snapshot volume feature

The test that is in tempest for this feature is
specific to LVM and will *not* work for other backends
regardless of them supporting the feature. It shouldn't
default to enabled for everyone, only for LVM.

If others want to opt-in they can, but its definitely
the minority that would.

Change-Id: I21347f2a5069059e6413208b254d5acd246faaea

Patrick East authored on 2017/01/14 04:44:54
Showing 1 changed files
... ...
@@ -434,7 +434,11 @@ function configure_tempest {
434 434
     iniset $TEMPEST_CONFIG validation network_for_ssh $TEMPEST_SSH_NETWORK_NAME
435 435
 
436 436
     # Volume
437
-    iniset $TEMPEST_CONFIG volume-feature-enabled manage_snapshot $(trueorfalse True TEMPEST_VOLUME_MANAGE_SNAPSHOT)
437
+    # Only turn on TEMPEST_VOLUME_MANAGE_SNAPSHOT by default for "lvm" backends
438
+    if [[ "$CINDER_ENABLED_BACKENDS" == *"lvm"* ]]; then
439
+        TEMPEST_VOLUME_MANAGE_SNAPSHOT=${TEMPEST_VOLUME_MANAGE_SNAPSHOT:-True}
440
+    fi
441
+    iniset $TEMPEST_CONFIG volume-feature-enabled manage_snapshot $(trueorfalse False TEMPEST_VOLUME_MANAGE_SNAPSHOT)
438 442
     # TODO(ynesenenko): Remove the volume_services flag when Liberty and Kilo will correct work with host info.
439 443
     iniset $TEMPEST_CONFIG volume-feature-enabled volume_services True
440 444
     # TODO(ameade): Remove the api_v3 flag when Mitaka and Liberty are end of life.