Browse code

Neutron: stop creating neutron debug probes

They seem to be more trouble than they are worth.

http://lists.openstack.org/pipermail/openstack-dev/2016-May/095476.html

Neutron has already deprecated the utility in
https://review.openstack.org/#/c/318786/

Change-Id: I470ed5bc1cbe754c4bfae41f411150331bc4335d

Sean M. Collins authored on 2016/05/20 00:36:57
Showing 2 changed files
... ...
@@ -130,8 +130,6 @@ Q_USE_ROOTWRAP_DAEMON=$(trueorfalse True Q_USE_ROOTWRAP_DAEMON)
130 130
 Q_META_DATA_IP=${Q_META_DATA_IP:-$SERVICE_HOST}
131 131
 # Allow Overlapping IP among subnets
132 132
 Q_ALLOW_OVERLAPPING_IP=${Q_ALLOW_OVERLAPPING_IP:-True}
133
-# Use neutron-debug command
134
-Q_USE_DEBUG_COMMAND=${Q_USE_DEBUG_COMMAND:-False}
135 133
 # The name of the default q-l3 router
136 134
 Q_ROUTER_NAME=${Q_ROUTER_NAME:-router1}
137 135
 Q_NOTIFY_NOVA_PORT_STATUS_CHANGES=${Q_NOTIFY_NOVA_PORT_STATUS_CHANGES:-True}
... ...
@@ -361,8 +359,6 @@ function configure_mutnauq {
361 361
         _configure_neutron_ceilometer_notifications
362 362
     fi
363 363
 
364
-    _configure_neutron_debug_command
365
-
366 364
     iniset $NEUTRON_CONF DEFAULT api_workers "$API_WORKERS"
367 365
 }
368 366
 
... ...
@@ -799,24 +795,6 @@ function _configure_neutron_common {
799 799
     _neutron_setup_rootwrap
800 800
 }
801 801
 
802
-function _configure_neutron_debug_command {
803
-    if [[ "$Q_USE_DEBUG_COMMAND" != "True" ]]; then
804
-        return
805
-    fi
806
-
807
-    cp $NEUTRON_DIR/etc/l3_agent.ini.sample $NEUTRON_TEST_CONFIG_FILE
808
-
809
-    iniset $NEUTRON_TEST_CONFIG_FILE DEFAULT debug False
810
-    iniset $NEUTRON_TEST_CONFIG_FILE AGENT root_helper "$Q_RR_COMMAND"
811
-    if [[ "$Q_USE_ROOTWRAP_DAEMON" == "True" ]]; then
812
-        iniset $NEUTRON_TEST_CONFIG_FILE AGENT root_helper_daemon "$Q_RR_DAEMON_COMMAND"
813
-    fi
814
-
815
-    _neutron_setup_interface_driver $NEUTRON_TEST_CONFIG_FILE
816
-
817
-    neutron_plugin_configure_debug_command
818
-}
819
-
820 802
 function _configure_neutron_dhcp_agent {
821 803
 
822 804
     cp $NEUTRON_DIR/etc/dhcp_agent.ini.sample $Q_DHCP_CONF_FILE
... ...
@@ -1027,24 +1005,6 @@ function delete_probe {
1027 1027
     neutron-debug --os-tenant-name admin --os-username admin probe-delete $probe_id
1028 1028
 }
1029 1029
 
1030
-function setup_neutron_debug {
1031
-    if [[ "$Q_USE_DEBUG_COMMAND" == "True" ]]; then
1032
-        public_net_id=`_get_net_id $PUBLIC_NETWORK_NAME`
1033
-        if [[ -n $public_net_id ]]; then
1034
-            neutron-debug --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD probe-create --device-owner compute $public_net_id
1035
-        fi
1036
-        private_net_id=`_get_net_id $PRIVATE_NETWORK_NAME`
1037
-        if [[ -n $private_net_id ]]; then
1038
-            neutron-debug --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD probe-create --device-owner compute $private_net_id
1039
-        fi
1040
-    fi
1041
-}
1042
-
1043
-function teardown_neutron_debug {
1044
-    delete_probe $PUBLIC_NETWORK_NAME
1045
-    delete_probe $PRIVATE_NETWORK_NAME
1046
-}
1047
-
1048 1030
 function _get_net_id {
1049 1031
     neutron --os-cloud devstack-admin --os-region "$REGION_NAME" --os-tenant-name admin --os-username admin --os-password $ADMIN_PASSWORD net-list | grep $1 | awk '{print $2}'
1050 1032
 }
... ...
@@ -1250,7 +1250,6 @@ fi
1250 1250
 if is_service_enabled q-svc && [[ "$NEUTRON_CREATE_INITIAL_NETWORKS" == "True" ]]; then
1251 1251
     echo_summary "Creating initial neutron network elements"
1252 1252
     create_neutron_initial_network
1253
-    setup_neutron_debug
1254 1253
 fi
1255 1254
 
1256 1255
 if is_service_enabled nova; then