1. devstack
  2. Commit 79fc935640aa4695c26b4bcc8b06c605e2256311
Browse code

Restoring xtrace state for os-brick plugin

The change Ibb7423d243d57852dada0b6298463bbdfc6dc63c that introduced the
os-brick plugin introduced a flaw where the xtrace state wasn't restored
after the end of the plugin's execution. The end behavior is that devstack's
logs were with way less information, difficulting the debugging of the build.
This patch fixes the variable that was intended to hold the xtrace state (it
was using cinder's) and restoring the state at the end of the script.

Change-Id: I47c6c794a9704049b089142eca5603d1183f8a10

Thiago Paiva authored on 2016/07/15 02:16:20
Showing 1 changed files
lib/os_brick
History View file @ 79fc935
... ... 
@@ -13,7 +13,7 @@
13 13 
 # - install_os_brick
14 14
15 15 
 # Save trace setting
16 
-_XTRACE_CINDER=$(set +o | grep xtrace)
16 
+_XTRACE_OS_BRICK=$(set +o | grep xtrace)
17 17 
 set +o xtrace
18 18
19 19
... ... 
@@ -27,3 +27,6 @@ function install_os_brick {
27 27 
         setup_dev_lib "os-brick"
28 28 
     fi
29 29 
 }
30 
+
31 
+# Restore xtrace
32 
+$_XTRACE_OS_BRICK
30 33 
\ No newline at end of file