Browse code

[Fedora] Devstack fails to install in firewalld less system

The official F20 cloud image does not contains the firewalld,
there is nothing to restart, and it fails the installation.

The previous workaround change, assumed all is_fedoras has
a restartable firewalld without ensuring is it installed at all.

RHEL6 even does not have a firewalld.

Closes-bug: #1329102
Change-Id: I3d119ce48af81b30bf02b01c2cd386612ac6ef90

Ian Wienand authored on 2014/06/12 07:47:50
Showing 1 changed files
... ...
@@ -29,12 +29,16 @@ function install_libvirt {
29 29
         install_package python-libguestfs
30 30
     fi
31 31
 
32
-    # Restart dbus/firewalld after install of libvirt to avoid a
33
-    # problem with polkit, which libvirtd brings in.  See
32
+    # Restart firewalld after install of libvirt to avoid a problem
33
+    # with polkit, which libvirtd brings in.  See
34 34
     # https://bugzilla.redhat.com/show_bug.cgi?id=1099031
35
+
36
+    # Note there is a difference between F20 rackspace cloud images
37
+    # and HP images used in the gate; rackspace has firewalld but hp
38
+    # cloud doesn't.  RHEL6 doesn't have firewalld either.  So we
39
+    # don't care if it fails.
35 40
     if is_fedora; then
36
-        sudo service dbus restart
37
-        sudo service firewalld restart
41
+        sudo service firewalld restart || true
38 42
     fi
39 43
 }
40 44