Browse code

Remove firewalld on Fedora 20 by default

firewalld interacts badly with the libvirt on f20, causing slow-downs
so great that it can timeout the gate.

Developers who want to leave it enabled should set FORCE_FIREWALLD=True

Change-Id: I5252a12223a35f7fb7a4ac3c58aa4a3cd1bc4799

Dean Troyer authored on 2014/08/20 00:54:59
Showing 2 changed files
... ...
@@ -37,7 +37,7 @@ function install_libvirt {
37 37
     # and HP images used in the gate; rackspace has firewalld but hp
38 38
     # cloud doesn't.  RHEL6 doesn't have firewalld either.  So we
39 39
     # don't care if it fails.
40
-    if is_fedora; then
40
+    if is_fedora && is_package_installed firewalld; then
41 41
         sudo service firewalld restart || true
42 42
     fi
43 43
 }
... ...
@@ -103,6 +103,21 @@ if is_fedora; then
103 103
     if selinuxenabled; then
104 104
         sudo setenforce 0
105 105
     fi
106
+
107
+    FORCE_FIREWALLD=$(trueorfalse False $FORCE_FIREWALLD)
108
+    if [[ ${DISTRO} =~ (f19|f20) && $FORCE_FIREWALLD == "False" ]]; then
109
+        # On Fedora 19 and 20 firewalld interacts badly with libvirt and
110
+        # slows things down significantly.  However, for those cases
111
+        # where that combination is desired, allow this fix to be skipped.
112
+
113
+        # There was also an additional issue with firewalld hanging
114
+        # after install of libvirt with polkit.  See
115
+        # https://bugzilla.redhat.com/show_bug.cgi?id=1099031
116
+        if is_package_installed firewalld; then
117
+            uninstall_package firewalld
118
+        fi
119
+    fi
120
+
106 121
 fi
107 122
 
108 123
 # RHEL6