Browse code

Remove sshd reconfig from lib/ironic

The sshd reconfiguration to listen on port 2222 provides no
benefit and complicates deployment on some systems. This removes
the reconfiguration and instead just confirms SSH connectivity.
Default SSH host and ports are left configurable, but the port now
reflects the default 22.

Change-Id: Iaf7c71854c3741a505a79037ffb8c86ace74fc27

Adam Gandelman authored on 2014/04/15 03:57:13
Showing 1 changed files
... ...
@@ -49,7 +49,7 @@ IRONIC_SSH_KEY_FILENAME=${IRONIC_SSH_KEY_FILENAME:-ironic_key}
49 49
 IRONIC_KEY_FILE=$IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME
50 50
 IRONIC_SSH_VIRT_TYPE=${IRONIC_SSH_VIRT_TYPE:-virsh}
51 51
 IRONIC_TFTPBOOT_DIR=${IRONIC_TFTPBOOT_DIR:-$IRONIC_DATA_DIR/tftpboot}
52
-IRONIC_VM_SSH_PORT=${IRONIC_VM_SSH_PORT:-2222}
52
+IRONIC_VM_SSH_PORT=${IRONIC_VM_SSH_PORT:-22}
53 53
 IRONIC_VM_SSH_ADDRESS=${IRONIC_VM_SSH_ADDRESS:-$HOST_IP}
54 54
 IRONIC_VM_COUNT=${IRONIC_VM_COUNT:-1}
55 55
 IRONIC_VM_SPECS_CPU=${IRONIC_VM_SPECS_CPU:-1}
... ...
@@ -423,31 +423,10 @@ function ironic_ssh_check {
423 423
     fi
424 424
 }
425 425
 
426
-function configure_ironic_sshd {
427
-    # Ensure sshd server accepts connections from localhost only
428
-
429
-    SSH_CONFIG=/etc/ssh/sshd_config
430
-    HOST_PORT=$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT
431
-    if ! sudo grep ListenAddress $SSH_CONFIG | grep $HOST_PORT; then
432
-        echo "ListenAddress $HOST_PORT" | sudo tee -a $SSH_CONFIG
433
-    fi
434
-
435
-    SSH_SERVICE_NAME=sshd
436
-    if is_ubuntu; then
437
-        SSH_SERVICE_NAME=ssh
438
-    fi
439
-
440
-    restart_service $SSH_SERVICE_NAME
441
-    # to ensure ssh service is up and running
442
-    sleep 3
443
-    ironic_ssh_check $IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME $IRONIC_VM_SSH_ADDRESS $IRONIC_VM_SSH_PORT $IRONIC_SSH_USERNAME 10
444
-
445
-}
446
-
447 426
 function configure_ironic_auxiliary {
448 427
     configure_ironic_dirs
449 428
     configure_ironic_ssh_keypair
450
-    configure_ironic_sshd
429
+    ironic_ssh_check $IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME $IRONIC_VM_SSH_ADDRESS $IRONIC_VM_SSH_PORT $IRONIC_SSH_USERNAME 10
451 430
 }
452 431
 
453 432
 # build deploy kernel+ramdisk, then upload them to glance