Browse code

Remove sshd reconfig from lib/ironic

The sshd reconfiguration to listen on port 2222 provides no
benefit and complicates deployment on some systems. This removes
the reconfiguration and instead just confirms SSH connectivity.
Default SSH host and ports are left configurable, but the port now
reflects the default 22.

Change-Id: Iaf7c71854c3741a505a79037ffb8c86ace74fc27
(cherry picked from commit 867651049a07a087e619a17d05f569188032f7e0)

Adam Gandelman authored on 2014/04/15 03:57:13
Showing 1 changed files
... ...
@@ -49,7 +49,7 @@ IRONIC_SSH_KEY_FILENAME=${IRONIC_SSH_KEY_FILENAME:-ironic_key}
49 49
 IRONIC_KEY_FILE=$IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME
50 50
 IRONIC_SSH_VIRT_TYPE=${IRONIC_SSH_VIRT_TYPE:-virsh}
51 51
 IRONIC_TFTPBOOT_DIR=${IRONIC_TFTPBOOT_DIR:-$IRONIC_DATA_DIR/tftpboot}
52
-IRONIC_VM_SSH_PORT=${IRONIC_VM_SSH_PORT:-2222}
52
+IRONIC_VM_SSH_PORT=${IRONIC_VM_SSH_PORT:-22}
53 53
 IRONIC_VM_SSH_ADDRESS=${IRONIC_VM_SSH_ADDRESS:-$HOST_IP}
54 54
 IRONIC_VM_COUNT=${IRONIC_VM_COUNT:-1}
55 55
 IRONIC_VM_SPECS_CPU=${IRONIC_VM_SPECS_CPU:-1}
... ...
@@ -438,31 +438,10 @@ function ironic_ssh_check {
438 438
     fi
439 439
 }
440 440
 
441
-function configure_ironic_sshd {
442
-    # Ensure sshd server accepts connections from localhost only
443
-
444
-    SSH_CONFIG=/etc/ssh/sshd_config
445
-    HOST_PORT=$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT
446
-    if ! sudo grep ListenAddress $SSH_CONFIG | grep $HOST_PORT; then
447
-        echo "ListenAddress $HOST_PORT" | sudo tee -a $SSH_CONFIG
448
-    fi
449
-
450
-    SSH_SERVICE_NAME=sshd
451
-    if is_ubuntu; then
452
-        SSH_SERVICE_NAME=ssh
453
-    fi
454
-
455
-    restart_service $SSH_SERVICE_NAME
456
-    # to ensure ssh service is up and running
457
-    sleep 3
458
-    ironic_ssh_check $IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME $IRONIC_VM_SSH_ADDRESS $IRONIC_VM_SSH_PORT $IRONIC_SSH_USERNAME 10
459
-
460
-}
461
-
462 441
 function configure_ironic_auxiliary {
463 442
     configure_ironic_dirs
464 443
     configure_ironic_ssh_keypair
465
-    configure_ironic_sshd
444
+    ironic_ssh_check $IRONIC_SSH_KEY_DIR/$IRONIC_SSH_KEY_FILENAME $IRONIC_VM_SSH_ADDRESS $IRONIC_VM_SSH_PORT $IRONIC_SSH_USERNAME 10
466 445
 }
467 446
 
468 447
 # build deploy kernel+ramdisk, then upload them to glance