Browse code

End support for changing cinder periodic_interval

Support for changing the cinder periodic_interval config option
was added way back in havana as a workaround for bug #1180976
by change I20e52e66fcc94b224476cdd14c88bd6981b4e617. As the fix
for that bug does not require modifying this config value, and
such modification may have unintentional adverse effects, end
the support.

Change-Id: I1ef1fe564123216b19582262726cdb1078b7650e
Partial-bug: #1824837

Brian Rosmaita authored on 2019/04/16 01:00:07
Showing 2 changed files
... ...
@@ -380,7 +380,6 @@
380 380
         SWIFT_REPLICAS: 1
381 381
         SWIFT_START_ALL_SERVICES: false
382 382
         SWIFT_HASH: 1234123412341234
383
-        CINDER_PERIODIC_INTERVAL: 10
384 383
         DEBUG_LIBVIRT_COREDUMPS: true
385 384
         NOVA_VNC_ENABLED: true
386 385
         VNCSERVER_LISTEN: 0.0.0.0
... ...
@@ -88,14 +88,6 @@ CINDER_ENABLED_BACKENDS=${CINDER_ENABLED_BACKENDS:-lvm:lvmdriver-1}
88 88
 CINDER_VOLUME_CLEAR=${CINDER_VOLUME_CLEAR:-${CINDER_VOLUME_CLEAR_DEFAULT:-zero}}
89 89
 CINDER_VOLUME_CLEAR=$(echo ${CINDER_VOLUME_CLEAR} | tr '[:upper:]' '[:lower:]')
90 90
 
91
-# Cinder reports allocations back to the scheduler on periodic intervals
92
-# it turns out we can get an "out of space" issue when we run tests too
93
-# quickly just because cinder didn't realize we'd freed up resources.
94
-# Make this configurable so that devstack-gate/tempest can set it to
95
-# less than the 60 second default
96
-# https://bugs.launchpad.net/cinder/+bug/1180976
97
-CINDER_PERIODIC_INTERVAL=${CINDER_PERIODIC_INTERVAL:-60}
98
-
99 91
 # Centos7 and OpenSUSE switched to using LIO and that's all that's supported,
100 92
 # although the tgt bits are in EPEL and OpenSUSE we don't want that for CI
101 93
 if is_fedora || is_suse; then
... ...
@@ -237,7 +229,6 @@ function configure_cinder {
237 237
     iniset $CINDER_CONF DEFAULT osapi_volume_listen $CINDER_SERVICE_LISTEN_ADDRESS
238 238
     iniset $CINDER_CONF DEFAULT state_path $CINDER_STATE_PATH
239 239
     iniset $CINDER_CONF oslo_concurrency lock_path $CINDER_STATE_PATH
240
-    iniset $CINDER_CONF DEFAULT periodic_interval $CINDER_PERIODIC_INTERVAL
241 240
     iniset $CINDER_CONF DEFAULT my_ip "$HOST_IP"
242 241
 
243 242
     iniset $CINDER_CONF key_manager backend cinder.keymgr.conf_key_mgr.ConfKeyManager