Browse code

Re-enable memory_tracker

The old peakmem_tracker service has been disabled in [0], now enable
the replacement memory_tracker.

Also fail when the old service is still configured, otherwise
consumers might never notice.

Depends-On: https://review.opendev.org/739995
Change-Id: I583caf3f36a8ff41d7d4106dabc6c5f24243085e

Jens Harbott authored on 2019/02/21 21:24:17
Showing 2 changed files
... ...
@@ -404,6 +404,7 @@
404 404
         # Shared services
405 405
         dstat: true
406 406
         etcd3: true
407
+        memory_tracker: true
407 408
         mysql: true
408 409
         rabbit: true
409 410
     group-vars:
... ...
@@ -411,6 +412,7 @@
411 411
         devstack_services:
412 412
           # Shared services
413 413
           dstat: true
414
+          memory_tracker: true
414 415
         devstack_localrc:
415 416
           # Multinode specific settings
416 417
           HOST_IP: "{{ hostvars[inventory_hostname]['nodepool']['private_ipv4'] }}"
... ...
@@ -476,6 +478,7 @@
476 476
         # Shared services
477 477
         dstat: true
478 478
         etcd3: true
479
+        memory_tracker: true
479 480
         mysql: true
480 481
         rabbit: true
481 482
         tls-proxy: true
... ...
@@ -524,6 +527,7 @@
524 524
           # This list replaces the test-matrix.
525 525
           # Shared services
526 526
           dstat: true
527
+          memory_tracker: true
527 528
           tls-proxy: true
528 529
           # Nova services
529 530
           n-cpu: true
... ...
@@ -35,10 +35,10 @@ function start_dstat {
35 35
     # to your localrc
36 36
     run_process memory_tracker "$TOP_DIR/tools/memory_tracker.sh" "" "root"
37 37
 
38
-    # remove support for the old name when it's no longer used (sometime in Queens)
38
+    # TODO(jh): Fail when using the old service name otherwise consumers might
39
+    # never notice that is has been removed.
39 40
     if is_service_enabled peakmem_tracker; then
40
-        deprecated "Use of peakmem_tracker in devstack is deprecated, use memory_tracker instead"
41
-        run_process peakmem_tracker "$TOP_DIR/tools/memory_tracker.sh" "" "root"
41
+        die $LINENO "The peakmem_tracker service has been removed, use memory_tracker instead"
42 42
     fi
43 43
 }
44 44