A syntax error is hit when trying to upload a flat vmdk file that
is accompanied by a descriptor file. The code block that handles
this has some unneeded characters that cause the error. Also,
an else-block has been removed so that we can remove an extra
indent.
Change-Id: Iaf5c914e09da6831eeeec141228b39554a1e2216
Closes-bug: #1288471
| ... | ... |
@@ -163,38 +163,37 @@ function upload_image {
|
| 163 | 163 |
if [[ ${IMAGE_NAME: -5} != "-flat" ]]; then
|
| 164 | 164 |
warn $LINENO "Expected filename suffix: '-flat'."` |
| 165 | 165 |
`" Filename provided: ${IMAGE_NAME}"
|
| 166 |
- else |
|
| 167 |
- descriptor_fname="${IMAGE_NAME:0:${#IMAGE_NAME} - 5}.vmdk"
|
|
| 168 |
- path_len=`expr ${#image_url} - ${#IMAGE_FNAME}`
|
|
| 169 |
- flat_path="${image_url:0:$path_len}"
|
|
| 170 |
- descriptor_url=$flat_path$descriptor_fname |
|
| 171 |
- warn $LINENO "$descriptor_data_pair_msg"` |
|
| 172 |
- `" Attempt to retrieve the descriptor *.vmdk: $descriptor_url" |
|
| 173 |
- if [[ $flat_path != file* ]]; then |
|
| 174 |
- if [[ ! -f $FILES/$descriptor_fname || \ |
|
| 175 |
- "$(stat -c "%s" $FILES/$descriptor_fname)" = "0" ]]; then |
|
| 176 |
- wget -c $descriptor_url -O $FILES/$descriptor_fname |
|
| 177 |
- if [[ $? -ne 0 ]]; then |
|
| 178 |
- warn $LINENO "Descriptor not found $descriptor_url" |
|
| 179 |
- descriptor_found=false |
|
| 180 |
- fi |
|
| 181 |
- fi |
|
| 182 |
- descriptor_url="$FILES/$descriptor_fname" |
|
| 183 |
- else |
|
| 184 |
- descriptor_url=$(echo $descriptor_url | sed "s/^file:\/\///g") |
|
| 185 |
- if [[ ! -f $descriptor_url || \ |
|
| 186 |
- "$(stat -c "%s" $descriptor_url)" == "0" ]]; then |
|
| 166 |
+ fi |
|
| 167 |
+ |
|
| 168 |
+ descriptor_fname="${IMAGE_NAME:0:${#IMAGE_NAME} - 5}.vmdk"
|
|
| 169 |
+ path_len=`expr ${#image_url} - ${#IMAGE_FNAME}`
|
|
| 170 |
+ flat_path="${image_url:0:$path_len}"
|
|
| 171 |
+ descriptor_url=$flat_path$descriptor_fname |
|
| 172 |
+ warn $LINENO "$descriptor_data_pair_msg"` |
|
| 173 |
+ `" Attempt to retrieve the descriptor *.vmdk: $descriptor_url" |
|
| 174 |
+ if [[ $flat_path != file* ]]; then |
|
| 175 |
+ if [[ ! -f $FILES/$descriptor_fname || \ |
|
| 176 |
+ "$(stat -c "%s" $FILES/$descriptor_fname)" = "0" ]]; then |
|
| 177 |
+ wget -c $descriptor_url -O $FILES/$descriptor_fname |
|
| 178 |
+ if [[ $? -ne 0 ]]; then |
|
| 187 | 179 |
warn $LINENO "Descriptor not found $descriptor_url" |
| 188 | 180 |
descriptor_found=false |
| 189 | 181 |
fi |
| 190 | 182 |
fi |
| 191 |
- if $descriptor_found; then |
|
| 192 |
- vmdk_adapter_type="$(head -25 $descriptor_url |"` |
|
| 193 |
- `" { grep -a -F -m 1 'ddb.adapterType =' $descriptor_url || true; })"
|
|
| 194 |
- vmdk_adapter_type="${vmdk_adapter_type#*\"}"
|
|
| 195 |
- vmdk_adapter_type="${vmdk_adapter_type%?}"
|
|
| 183 |
+ descriptor_url="$FILES/$descriptor_fname" |
|
| 184 |
+ else |
|
| 185 |
+ descriptor_url=$(echo $descriptor_url | sed "s/^file:\/\///g") |
|
| 186 |
+ if [[ ! -f $descriptor_url || \ |
|
| 187 |
+ "$(stat -c "%s" $descriptor_url)" == "0" ]]; then |
|
| 188 |
+ warn $LINENO "Descriptor not found $descriptor_url" |
|
| 189 |
+ descriptor_found=false |
|
| 196 | 190 |
fi |
| 197 | 191 |
fi |
| 192 |
+ if $descriptor_found; then |
|
| 193 |
+ vmdk_adapter_type="$(head -25 $descriptor_url | { grep -a -F -m 1 'ddb.adapterType =' $descriptor_url || true; })"
|
|
| 194 |
+ vmdk_adapter_type="${vmdk_adapter_type#*\"}"
|
|
| 195 |
+ vmdk_adapter_type="${vmdk_adapter_type%?}"
|
|
| 196 |
+ fi |
|
| 198 | 197 |
vmdk_disktype="preallocated" |
| 199 | 198 |
else |
| 200 | 199 |
vmdk_disktype="preallocated" |