Browse code

neutron-legacy: Consistently use `--config-file foo`

This change adjusts a few instances of `--config-file=foo` to
`--config-file foo` (no `=`) in order to make neutron command
lines more consistent and easier to match in sudoers/rootwrap
filters.

This is particularly useful for oslo.privsep, which needs to start a
helper command with the same `--config-file` arguments (see
Ia9675dff9232e0e987a836ecaf9e842eb5c3cb18).

Change-Id: I91fe18f66f3c3bc2ccd1ca8be91be2915ed3e3ec

Angus Lees authored on 2016/05/31 13:43:14
Showing 2 changed files
... ...
@@ -297,7 +297,7 @@ function _determine_config_server {
297 297
 }
298 298
 
299 299
 function _determine_config_l3 {
300
-    local opts="--config-file $NEUTRON_CONF --config-file=$Q_L3_CONF_FILE"
300
+    local opts="--config-file $NEUTRON_CONF --config-file $Q_L3_CONF_FILE"
301 301
     if is_service_enabled q-fwaas; then
302 302
         opts+=" --config-file $Q_FWAAS_CONF_FILE"
303 303
     fi
... ...
@@ -524,7 +524,7 @@ function start_mutnauq_l2_agent {
524 524
 }
525 525
 
526 526
 function start_mutnauq_other_agents {
527
-    run_process q-dhcp "$AGENT_DHCP_BINARY --config-file $NEUTRON_CONF --config-file=$Q_DHCP_CONF_FILE"
527
+    run_process q-dhcp "$AGENT_DHCP_BINARY --config-file $NEUTRON_CONF --config-file $Q_DHCP_CONF_FILE"
528 528
 
529 529
     if is_service_enabled neutron-vpnaas; then
530 530
         :  # Started by plugin
... ...
@@ -532,8 +532,8 @@ function start_mutnauq_other_agents {
532 532
         run_process q-l3 "$AGENT_L3_BINARY $(determine_config_files neutron-l3-agent)"
533 533
     fi
534 534
 
535
-    run_process q-meta "$AGENT_META_BINARY --config-file $NEUTRON_CONF --config-file=$Q_META_CONF_FILE"
536
-    run_process q-lbaas "$AGENT_LBAAS_BINARY --config-file $NEUTRON_CONF --config-file=$LBAAS_AGENT_CONF_FILENAME"
535
+    run_process q-meta "$AGENT_META_BINARY --config-file $NEUTRON_CONF --config-file $Q_META_CONF_FILE"
536
+    run_process q-lbaas "$AGENT_LBAAS_BINARY --config-file $NEUTRON_CONF --config-file $LBAAS_AGENT_CONF_FILENAME"
537 537
     run_process q-metering "$AGENT_METERING_BINARY --config-file $NEUTRON_CONF --config-file $METERING_AGENT_CONF_FILENAME"
538 538
 
539 539
     if [ "$VIRT_DRIVER" = 'xenserver' ]; then
... ...
@@ -83,7 +83,7 @@ SUBNETPOOL_SIZE_V4=${SUBNETPOOL_SIZE_V4:-24}
83 83
 SUBNETPOOL_SIZE_V6=${SUBNETPOOL_SIZE_V6:-64}
84 84
 
85 85
 function _determine_config_l3 {
86
-    local opts="--config-file $NEUTRON_CONF --config-file=$Q_L3_CONF_FILE"
86
+    local opts="--config-file $NEUTRON_CONF --config-file $Q_L3_CONF_FILE"
87 87
     echo "$opts"
88 88
 }
89 89