Browse code

Remove support for enabling file injection

File injection is disabled in nova meanwhile, and devstack core
reviewers think it shouldn't be configureable in devstack anymore.
This basically reverts https://review.openstack.org/#/c/70560/

Change-Id: Ia7dd407da00c0b1c9641865aea1f7b74533d7357

Dirk Mueller authored on 2015/06/23 19:23:29
Showing 1 changed files
... ...
@@ -25,9 +25,6 @@ source $TOP_DIR/lib/nova_plugins/functions-libvirt
25 25
 # Defaults
26 26
 # --------
27 27
 
28
-# File injection is disabled by default in Nova.  This will turn it back on.
29
-ENABLE_FILE_INJECTION=$(trueorfalse False ENABLE_FILE_INJECTION)
30
-
31 28
 
32 29
 # Entry Points
33 30
 # ------------
... ...
@@ -60,17 +57,9 @@ function configure_nova_hypervisor {
60 60
         iniset $NOVA_CONF DEFAULT vnc_enabled "false"
61 61
     fi
62 62
 
63
-    if [[ "$ENABLE_FILE_INJECTION" = "True" ]] ; then
64
-        # When libguestfs is available for file injection, enable using
65
-        # libguestfs to inspect the image and figure out the proper
66
-        # partition to inject into.
67
-        iniset $NOVA_CONF libvirt inject_partition '-1'
68
-        iniset $NOVA_CONF libvirt inject_key 'true'
69
-    else
70
-        # File injection is being disabled by default in the near future -
71
-        # disable it here for now to avoid surprises later.
72
-        iniset $NOVA_CONF libvirt inject_partition '-2'
73
-    fi
63
+    # File injection is being disabled by default in the near future -
64
+    # disable it here for now to avoid surprises later.
65
+    iniset $NOVA_CONF libvirt inject_partition '-2'
74 66
 
75 67
     if [[ "$LIBVIRT_TYPE" = "parallels" ]]; then
76 68
         iniset $NOVA_CONF libvirt connection_uri "parallels+unix:///system"
... ...
@@ -96,14 +85,6 @@ function install_nova_hypervisor {
96 96
             yum_install libcgroup-tools
97 97
         fi
98 98
     fi
99
-
100
-    if [[ "$ENABLE_FILE_INJECTION" = "True" ]] ; then
101
-        if is_ubuntu; then
102
-            install_package python-guestfs
103
-        elif is_fedora || is_suse; then
104
-            install_package python-libguestfs
105
-        fi
106
-    fi
107 99
 }
108 100
 
109 101
 # start_nova_hypervisor - Start any required external services