Browse code

Merge "Don't run and check c-api if it is disabled"

Jenkins authored on 2017/06/06 05:22:10
Showing 1 changed files
... ...
@@ -498,17 +498,24 @@ function start_cinder {
498 498
         fi
499 499
     fi
500 500
 
501
-    if [ "$CINDER_USE_MOD_WSGI" == "True" ]; then
502
-        enable_apache_site osapi-volume
503
-        restart_apache_server
504
-        tail_log c-api /var/log/$APACHE_NAME/c-api.log
505
-    else
506
-        run_process c-api "$CINDER_BIN_DIR/cinder-api --config-file $CINDER_CONF"
507
-    fi
501
+    if is_service_enabled c-api ; then
502
+        if [ "$CINDER_USE_MOD_WSGI" == "True" ]; then
503
+            enable_apache_site osapi-volume
504
+            restart_apache_server
505
+            tail_log c-api /var/log/$APACHE_NAME/c-api.log
506
+        else
507
+            run_process c-api "$CINDER_BIN_DIR/cinder-api --config-file $CINDER_CONF"
508
+        fi
508 509
 
509
-    echo "Waiting for Cinder API to start..."
510
-    if ! wait_for_service $SERVICE_TIMEOUT $service_protocol://$CINDER_SERVICE_HOST:$service_port; then
511
-        die $LINENO "c-api did not start"
510
+        echo "Waiting for Cinder API to start..."
511
+        if ! wait_for_service $SERVICE_TIMEOUT $service_protocol://$CINDER_SERVICE_HOST:$service_port; then
512
+            die $LINENO "c-api did not start"
513
+        fi
514
+
515
+        # Start proxies if enabled
516
+        if is_service_enabled tls-proxy; then
517
+            start_tls_proxy cinder '*' $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT
518
+        fi
512 519
     fi
513 520
 
514 521
     run_process c-sch "$CINDER_BIN_DIR/cinder-scheduler --config-file $CINDER_CONF"
... ...
@@ -518,11 +525,6 @@ function start_cinder {
518 518
     # NOTE(jdg): For cinder, startup order matters.  To ensure that repor_capabilities is received
519 519
     # by the scheduler start the cinder-volume service last (or restart it) after the scheduler
520 520
     # has started.  This is a quick fix for lp bug/1189595
521
-
522
-    # Start proxies if enabled
523
-    if is_service_enabled c-api && is_service_enabled tls-proxy; then
524
-        start_tls_proxy cinder '*' $CINDER_SERVICE_PORT $CINDER_SERVICE_HOST $CINDER_SERVICE_PORT_INT
525
-    fi
526 521
 }
527 522
 
528 523
 # stop_cinder() - Stop running processes