Browse code

Merge "Set datapath to $OVS_DATAPATH_TYPE for bridges"

Jenkins authored on 2015/06/17 04:44:32
Showing 2 changed files
... ...
@@ -59,7 +59,7 @@ function neutron_plugin_configure_plugin_agent {
59 59
         OVS_BRIDGE_MAPPINGS=$PHYSICAL_NETWORK:$OVS_PHYSICAL_BRIDGE
60 60
 
61 61
         # Configure bridge manually with physical interface as port for multi-node
62
-        sudo ovs-vsctl --no-wait -- --may-exist add-br $OVS_PHYSICAL_BRIDGE
62
+        _neutron_ovs_base_add_bridge $OVS_PHYSICAL_BRIDGE
63 63
     fi
64 64
     if [[ "$OVS_BRIDGE_MAPPINGS" != "" ]]; then
65 65
         iniset /$Q_PLUGIN_CONF_FILE ovs bridge_mappings $OVS_BRIDGE_MAPPINGS
... ...
@@ -92,7 +92,7 @@ function neutron_plugin_configure_plugin_agent {
92 92
         # Set up domU's L2 agent:
93 93
 
94 94
         # Create a bridge "br-$GUEST_INTERFACE_DEFAULT"
95
-        sudo ovs-vsctl --no-wait -- --may-exist add-br "br-$GUEST_INTERFACE_DEFAULT"
95
+        _neutron_ovs_base_add_bridge "br-$GUEST_INTERFACE_DEFAULT"
96 96
         # Add $GUEST_INTERFACE_DEFAULT to that bridge
97 97
         sudo ovs-vsctl add-port "br-$GUEST_INTERFACE_DEFAULT" $GUEST_INTERFACE_DEFAULT
98 98
 
... ...
@@ -15,13 +15,21 @@ function is_neutron_ovs_base_plugin {
15 15
     return 0
16 16
 }
17 17
 
18
+function _neutron_ovs_base_add_bridge {
19
+    local bridge=$1
20
+    local addbr_cmd="sudo ovs-vsctl --no-wait -- --may-exist add-br $bridge"
21
+
22
+    if [ "$OVS_DATAPATH_TYPE" != "" ] ; then
23
+        addbr_cmd="$addbr_cmd -- set Bridge $bridge datapath_type=${OVS_DATAPATH_TYPE}"
24
+    fi
25
+
26
+    $addbr_cmd
27
+}
28
+
18 29
 function _neutron_ovs_base_setup_bridge {
19 30
     local bridge=$1
20 31
     neutron-ovs-cleanup
21
-    sudo ovs-vsctl --no-wait -- --may-exist add-br $bridge
22
-    if [[ $OVS_DATAPATH_TYPE != "" ]]; then
23
-        sudo ovs-vsctl set Bridge $bridge datapath_type=${OVS_DATAPATH_TYPE}
24
-    fi
32
+    _neutron_ovs_base_add_bridge $bridge
25 33
     sudo ovs-vsctl --no-wait br-set-external-id $bridge bridge-id $bridge
26 34
 }
27 35
 
... ...
@@ -92,7 +100,7 @@ function _neutron_ovs_base_configure_l3_agent {
92 92
         sudo ip link set $Q_PUBLIC_VETH_EX up
93 93
         sudo ip addr flush dev $Q_PUBLIC_VETH_EX
94 94
     else
95
-        sudo ovs-vsctl -- --may-exist add-br $PUBLIC_BRIDGE
95
+        _neutron_ovs_base_add_bridge $PUBLIC_BRIDGE
96 96
         sudo ovs-vsctl br-set-external-id $PUBLIC_BRIDGE bridge-id $PUBLIC_BRIDGE
97 97
     fi
98 98
 }