functions-libvirt: Enable DEBUG_LIBVIRT config attribute by default
Enabling it by default because:
- This allows you to get the relevant logs right away when something
in the libvirt code path fails, without having to submit another
change and keep doing a 'recheck' to re-run the CI check/gate jobs
until you hit the bug.
- The libvirt log filters specified in the function
'configure_libvirt' are much more _selective_ and not a catch-all
debug option where you end up with the unhelpful situation of having
to find a "specific piece of hay in a haystack"[1].
FWIW, I always have it enabled in local test environments, and I don't
see the resulting libvirtd.log growing beyond a couple of MB for
three-four days of usage.
[1] http://lists.openstack.org/pipermail/openstack-dev/2014-January/024414.html
Change-Id: I5e0b35446075b419fe473e1db8d0bfedd7009741
Kashyap Chamarthy authored on 2015/04/01 18:30:57Showing 1 changed files
| ... | ... |
@@ -14,8 +14,11 @@ set +o xtrace |
| 14 | 14 |
# Defaults |
| 15 | 15 |
# -------- |
| 16 | 16 |
|
| 17 |
-# if we should turn on massive libvirt debugging |
|
| 18 |
-DEBUG_LIBVIRT=$(trueorfalse False DEBUG_LIBVIRT) |
|
| 17 |
+# Turn on selective debug log filters for libvirt. |
|
| 18 |
+# (NOTE: Enabling this by default, because the log filters enabled in |
|
| 19 |
+# 'configure_libvirt' function further below are _selective_ and not |
|
| 20 |
+# extremely verbose.) |
|
| 21 |
+DEBUG_LIBVIRT=$(trueorfalse True DEBUG_LIBVIRT) |
|
| 19 | 22 |
|
| 20 | 23 |
# Installs required distro-specific libvirt packages. |
| 21 | 24 |
function install_libvirt {
|