Browse code
Add test case to 'cidr2netmask'
'cidr2netmask' of function doesn't have enough test case
and test code isn't smart.
This patch adds test case and refactors test code.
Change-Id: Iab20ef06fe78316a78198ab75c0afe738a577dd6
Closes-bug: #1457989
Mahito authored on 2015/05/23 02:37:23Showing 1 changed files
| ... | ... |
@@ -12,51 +12,41 @@ source $TOP/tests/unittest.sh |
| 12 | 12 |
|
| 13 | 13 |
echo "Testing IP addr functions" |
| 14 | 14 |
|
| 15 |
-if [[ $(cidr2netmask 4) == 240.0.0.0 ]]; then |
|
| 16 |
- passed "cidr2netmask(): /4...OK" |
|
| 17 |
-else |
|
| 18 |
- failed "cidr2netmask(): /4...failed" |
|
| 19 |
-fi |
|
| 20 |
-if [[ $(cidr2netmask 8) == 255.0.0.0 ]]; then |
|
| 21 |
- passed "cidr2netmask(): /8...OK" |
|
| 22 |
-else |
|
| 23 |
- failed "cidr2netmask(): /8...failed" |
|
| 24 |
-fi |
|
| 25 |
-if [[ $(cidr2netmask 12) == 255.240.0.0 ]]; then |
|
| 26 |
- passed "cidr2netmask(): /12...OK" |
|
| 27 |
-else |
|
| 28 |
- failed "cidr2netmask(): /12...failed" |
|
| 29 |
-fi |
|
| 30 |
-if [[ $(cidr2netmask 16) == 255.255.0.0 ]]; then |
|
| 31 |
- passed "cidr2netmask(): /16...OK" |
|
| 32 |
-else |
|
| 33 |
- failed "cidr2netmask(): /16...failed" |
|
| 34 |
-fi |
|
| 35 |
-if [[ $(cidr2netmask 20) == 255.255.240.0 ]]; then |
|
| 36 |
- passed "cidr2netmask(): /20...OK" |
|
| 37 |
-else |
|
| 38 |
- failed "cidr2netmask(): /20...failed" |
|
| 39 |
-fi |
|
| 40 |
-if [[ $(cidr2netmask 24) == 255.255.255.0 ]]; then |
|
| 41 |
- passed "cidr2netmask(): /24...OK" |
|
| 42 |
-else |
|
| 43 |
- failed "cidr2netmask(): /24...failed" |
|
| 44 |
-fi |
|
| 45 |
-if [[ $(cidr2netmask 28) == 255.255.255.240 ]]; then |
|
| 46 |
- passed "cidr2netmask(): /28...OK" |
|
| 47 |
-else |
|
| 48 |
- failed "cidr2netmask(): /28...failed" |
|
| 49 |
-fi |
|
| 50 |
-if [[ $(cidr2netmask 30) == 255.255.255.252 ]]; then |
|
| 51 |
- passed "cidr2netmask(): /30...OK" |
|
| 52 |
-else |
|
| 53 |
- failed "cidr2netmask(): /30...failed" |
|
| 54 |
-fi |
|
| 55 |
-if [[ $(cidr2netmask 32) == 255.255.255.255 ]]; then |
|
| 56 |
- passed "cidr2netmask(): /32...OK" |
|
| 57 |
-else |
|
| 58 |
- failed "cidr2netmask(): /32...failed" |
|
| 59 |
-fi |
|
| 15 |
+function test_cidr2netmask {
|
|
| 16 |
+ local mask=0 |
|
| 17 |
+ local ips="128 192 224 240 248 252 254 255" |
|
| 18 |
+ local ip |
|
| 19 |
+ local msg |
|
| 20 |
+ |
|
| 21 |
+ msg="cidr2netmask(/0) == 0.0.0.0" |
|
| 22 |
+ assert_equal "0.0.0.0" $(cidr2netmask $mask) "$msg" |
|
| 23 |
+ |
|
| 24 |
+ for ip in $ips; do |
|
| 25 |
+ mask=$(( mask + 1 )) |
|
| 26 |
+ msg="cidr2netmask(/$mask) == $ip.0.0.0" |
|
| 27 |
+ assert_equal "$ip.0.0.0" $(cidr2netmask $mask) "$msg" |
|
| 28 |
+ done |
|
| 29 |
+ |
|
| 30 |
+ for ip in $ips; do |
|
| 31 |
+ mask=$(( mask + 1 )) |
|
| 32 |
+ msg="cidr2netmask(/$mask) == 255.$ip.0.0" |
|
| 33 |
+ assert_equal "255.$ip.0.0" $(cidr2netmask $mask) "$msg" |
|
| 34 |
+ done |
|
| 35 |
+ |
|
| 36 |
+ for ip in $ips; do |
|
| 37 |
+ mask=$(( mask + 1 )) |
|
| 38 |
+ msg="cidr2netmask(/$mask) == 255.255.$ip.0" |
|
| 39 |
+ assert_equal "255.255.$ip.0" $(cidr2netmask $mask) "$msg" |
|
| 40 |
+ done |
|
| 41 |
+ |
|
| 42 |
+ for ip in $ips; do |
|
| 43 |
+ mask=$(( mask + 1 )) |
|
| 44 |
+ msg="cidr2netmask(/$mask) == 255.255.255.$ip" |
|
| 45 |
+ assert_equal "255.255.255.$ip" $(cidr2netmask $mask) "$msg" |
|
| 46 |
+ done |
|
| 47 |
+} |
|
| 48 |
+ |
|
| 49 |
+test_cidr2netmask |
|
| 60 | 50 |
|
| 61 | 51 |
if [[ $(maskip 169.254.169.254 240.0.0.0) == 160.0.0.0 ]]; then |
| 62 | 52 |
passed "maskip(): /4...OK" |