Browse code

Add Quantum support: address code review comments

(commit 1bfa3d53c1ee74525932b721c2dddd42fc129b8e)

Brad Hall authored on 2011/10/29 00:28:26
Showing 1 changed files
... ...
@@ -792,8 +792,8 @@ if [[ "$ENABLED_SERVICES" =~ "q-svc" ]]; then
792 792
         if [[ "$ENABLED_SERVICES" =~ "mysql" ]]; then
793 793
             mysql -u$MYSQL_USER -p$MYSQL_PASSWORD -e 'CREATE DATABASE IF NOT EXISTS ovs_quantum;'
794 794
         else
795
-	    echo "mysql must be enabled in order to use the $Q_PLUGIN Quantum plugin."
796
-	    exit 1
795
+            echo "mysql must be enabled in order to use the $Q_PLUGIN Quantum plugin."
796
+            exit 1
797 797
         fi
798 798
     fi
799 799
 
... ...
@@ -817,10 +817,8 @@ if [[ "$ENABLED_SERVICES" =~ "q-agt" ]]; then
817 817
     screen_it q-agt "sleep 4; sudo python $QUANTUM_DIR/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py $QUANTUM_DIR/quantum/plugins/openvswitch/ovs_quantum_plugin.ini -v"
818 818
 fi
819 819
 
820
-# NOTE(bgh): I moved the network creation here because Quantum has to be up
821
-# and running before we can communicate with it if we're using Quantum for
822
-# networking (i.e. q-svc is enabled).
823
-
820
+# If we're using Quantum (i.e. q-svc is enabled), network creation has to
821
+# happen after we've started the Quantum service.
824 822
 if [[ "$ENABLED_SERVICES" =~ "mysql" ]]; then
825 823
     # create a small network
826 824
     $NOVA_DIR/bin/nova-manage network create private $FIXED_RANGE 1 $FIXED_NETWORK_SIZE