Browse code

refactor the install/configure split

configure remains just to generate configs, install now
gets the setup_develop in addition to the git clone. This lets
use remove configure_glanceclient as a function

Change-Id: I68e3e3973d15dc0b4f534662a4f57a9f38f69784

Sean Dague authored on 2013/04/02 04:56:07
Showing 2 changed files
... ...
@@ -62,15 +62,8 @@ function cleanup_glance() {
62 62
     sudo rm -rf $GLANCE_CACHE_DIR $GLANCE_IMAGE_DIR $GLANCE_AUTH_CACHE_DIR
63 63
 }
64 64
 
65
-# configure_glanceclient() - Set config files, create data dirs, etc
66
-function configure_glanceclient() {
67
-    setup_develop $GLANCECLIENT_DIR
68
-}
69
-
70 65
 # configure_glance() - Set config files, create data dirs, etc
71 66
 function configure_glance() {
72
-    setup_develop $GLANCE_DIR
73
-
74 67
     if [[ ! -d $GLANCE_CONF_DIR ]]; then
75 68
         sudo mkdir -p $GLANCE_CONF_DIR
76 69
     fi
... ...
@@ -180,11 +173,13 @@ function init_glance() {
180 180
 # install_glanceclient() - Collect source and prepare
181 181
 function install_glanceclient() {
182 182
     git_clone $GLANCECLIENT_REPO $GLANCECLIENT_DIR $GLANCECLIENT_BRANCH
183
+    setup_develop $GLANCECLIENT_DIR
183 184
 }
184 185
 
185 186
 # install_glance() - Collect source and prepare
186 187
 function install_glance() {
187 188
     git_clone $GLANCE_REPO $GLANCE_DIR $GLANCE_BRANCH
189
+    setup_develop $GLANCE_DIR
188 190
 }
189 191
 
190 192
 # start_glance() - Start running processes, including screen
... ...
@@ -647,10 +647,6 @@ if is_service_enabled g-api n-api; then
647 647
     configure_glance
648 648
 fi
649 649
 
650
-# Do this _after_ glance is installed to override the old binary
651
-# TODO(dtroyer): figure out when this is no longer necessary
652
-configure_glanceclient
653
-
654 650
 if is_service_enabled nova; then
655 651
     # First clean up old instances
656 652
     cleanup_nova