Browse code

Merge "Remove the EBTABLES_RACE_FIX added for Trusty"

Jenkins authored on 2017/04/07 09:33:30
Showing 4 changed files
1 1
deleted file mode 100644
... ...
@@ -1,23 +0,0 @@
1
-#!/bin/bash
2
-#
3
-# Copyright 2015 Hewlett-Packard Development Company, L.P.
4
-#
5
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
6
-# not use this file except in compliance with the License. You may obtain
7
-# a copy of the License at
8
-#
9
-#    http://www.apache.org/licenses/LICENSE-2.0
10
-#
11
-# Unless required by applicable law or agreed to in writing, software
12
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14
-# License for the specific language governing permissions and limitations
15
-# under the License.
16
-#
17
-#
18
-# This is a terrible, terrible, truly terrible work around for
19
-# environments that have libvirt < 1.2.11. ebtables requires that you
20
-# specifically tell it you would like to not race and get punched in
21
-# the face when 2 run at the same time with a --concurrent flag.
22
-
23
-flock -w 300 /var/lock/ebtables.nova /sbin/ebtables.real $@
... ...
@@ -64,11 +64,6 @@ function install_libvirt {
64 64
         install_package qemu-system
65 65
         install_package libvirt-bin libvirt-dev
66 66
         pip_install_gr libvirt-python
67
-        if [[ ${DISTRO} == "trusty" && ${EBTABLES_RACE_FIX} == "True" ]]; then
68
-            # Work around for bug #1501558. We can remove this once we
69
-            # get to a version of Ubuntu that has new enough libvirt.
70
-            TOP_DIR=$TOP_DIR $TOP_DIR/tools/install_ebtables_workaround.sh
71
-        fi
72 67
         #pip_install_gr <there-si-no-guestfs-in-pypi>
73 68
     elif is_fedora || is_suse; then
74 69
         # On "KVM for IBM z Systems", kvm does not have its own package
... ...
@@ -845,17 +845,6 @@ USE_SSL=$(trueorfalse False USE_SSL)
845 845
 # sharing the same database. It would be useful for multinode Grenade tests.
846 846
 RECREATE_KEYSTONE_DB=$(trueorfalse True RECREATE_KEYSTONE_DB)
847 847
 
848
-# ebtables is inherently racey. If you run it by two or more processes
849
-# simultaneously it will collide, badly, in the kernel and produce
850
-# failures or corruption of ebtables. The only way around it is for
851
-# all tools running ebtables to only ever do so with the --concurrent
852
-# flag. This requires libvirt >= 1.2.11.
853
-#
854
-# If you don't have this then the following work around will replace
855
-# ebtables with a wrapper script so that it is safe to run without
856
-# that flag.
857
-EBTABLES_RACE_FIX=$(trueorfalse False EBTABLES_RACE_FIX)
858
-
859 848
 # Following entries need to be last items in file
860 849
 
861 850
 # Compatibility bits required by other callers like Grenade
862 851
deleted file mode 100755
... ...
@@ -1,31 +0,0 @@
1
-#!/bin/bash -eu
2
-#
3
-# Copyright 2015 Hewlett-Packard Development Company, L.P.
4
-#
5
-# Licensed under the Apache License, Version 2.0 (the "License"); you may
6
-# not use this file except in compliance with the License. You may obtain
7
-# a copy of the License at
8
-#
9
-#    http://www.apache.org/licenses/LICENSE-2.0
10
-#
11
-# Unless required by applicable law or agreed to in writing, software
12
-# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
13
-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
14
-# License for the specific language governing permissions and limitations
15
-# under the License.
16
-#
17
-#
18
-# This replaces the ebtables on your system with a wrapper script that
19
-# does implicit locking. This is needed if libvirt < 1.2.11 on your platform.
20
-
21
-EBTABLES=/sbin/ebtables
22
-EBTABLESREAL=/sbin/ebtables.real
23
-FILES=$TOP_DIR/files
24
-
25
-if [[ -f "$EBTABLES" ]]; then
26
-    if file $EBTABLES | grep ELF; then
27
-        sudo mv $EBTABLES $EBTABLESREAL
28
-        sudo install -m 0755 $FILES/ebtables.workaround $EBTABLES
29
-        echo "Replaced ebtables with locking workaround"
30
-    fi
31
-fi