Browse code

Remove cache dirs from the services

PKI tokens have been actively deprecated from keystone and there are
deprecations being emitted from keystonemiddleware. Because of this we
no longer need an auth cache directory in the services where the PKI
certifcates used to be stored.

Remove the creation and use of all these AUTH_CACHE directories.

Change-Id: I5680376e70e74882e9fdb87ee1b95d5f40570ad7

Jamie Lennox authored on 2017/09/25 08:38:38
Showing 7 changed files
... ...
@@ -51,7 +51,6 @@ else
51 51
 fi
52 52
 
53 53
 CINDER_STATE_PATH=${CINDER_STATE_PATH:=$DATA_DIR/cinder}
54
-CINDER_AUTH_CACHE_DIR=${CINDER_AUTH_CACHE_DIR:-/var/cache/cinder}
55 54
 
56 55
 CINDER_CONF_DIR=/etc/cinder
57 56
 CINDER_CONF=$CINDER_CONF_DIR/cinder.conf
... ...
@@ -225,9 +224,8 @@ function configure_cinder {
225 225
     inicomment $CINDER_API_PASTE_INI filter:authtoken admin_tenant_name
226 226
     inicomment $CINDER_API_PASTE_INI filter:authtoken admin_user
227 227
     inicomment $CINDER_API_PASTE_INI filter:authtoken admin_password
228
-    inicomment $CINDER_API_PASTE_INI filter:authtoken signing_dir
229 228
 
230
-    configure_auth_token_middleware $CINDER_CONF cinder $CINDER_AUTH_CACHE_DIR
229
+    configure_auth_token_middleware $CINDER_CONF cinder
231 230
 
232 231
     iniset $CINDER_CONF DEFAULT auth_strategy keystone
233 232
     iniset $CINDER_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL
... ...
@@ -385,13 +383,6 @@ function create_cinder_accounts {
385 385
     fi
386 386
 }
387 387
 
388
-# create_cinder_cache_dir() - Part of the init_cinder() process
389
-function create_cinder_cache_dir {
390
-    # Create cache dir
391
-    sudo install -d -o $STACK_USER $CINDER_AUTH_CACHE_DIR
392
-    rm -f $CINDER_AUTH_CACHE_DIR/*
393
-}
394
-
395 388
 # init_cinder() - Initialize database and volume group
396 389
 function init_cinder {
397 390
     if is_service_enabled $DATABASE_BACKENDS; then
... ...
@@ -420,7 +411,6 @@ function init_cinder {
420 420
     fi
421 421
 
422 422
     mkdir -p $CINDER_STATE_PATH/volumes
423
-    create_cinder_cache_dir
424 423
 }
425 424
 
426 425
 # install_cinder() - Collect source and prepare
... ...
@@ -44,7 +44,6 @@ fi
44 44
 GLANCE_CACHE_DIR=${GLANCE_CACHE_DIR:=$DATA_DIR/glance/cache}
45 45
 GLANCE_IMAGE_DIR=${GLANCE_IMAGE_DIR:=$DATA_DIR/glance/images}
46 46
 GLANCE_LOCK_DIR=${GLANCE_LOCK_DIR:=$DATA_DIR/glance/locks}
47
-GLANCE_AUTH_CACHE_DIR=${GLANCE_AUTH_CACHE_DIR:-/var/cache/glance}
48 47
 
49 48
 GLANCE_CONF_DIR=${GLANCE_CONF_DIR:-/etc/glance}
50 49
 GLANCE_METADEF_DIR=$GLANCE_CONF_DIR/metadefs
... ...
@@ -98,7 +97,7 @@ function is_glance_enabled {
98 98
 function cleanup_glance {
99 99
     # kill instances (nova)
100 100
     # delete image files (glance)
101
-    sudo rm -rf $GLANCE_CACHE_DIR $GLANCE_IMAGE_DIR $GLANCE_AUTH_CACHE_DIR
101
+    sudo rm -rf $GLANCE_CACHE_DIR $GLANCE_IMAGE_DIR
102 102
 }
103 103
 
104 104
 # configure_glance() - Set config files, create data dirs, etc
... ...
@@ -115,7 +114,7 @@ function configure_glance {
115 115
     iniset $GLANCE_REGISTRY_CONF database connection $dburl
116 116
     iniset $GLANCE_REGISTRY_CONF DEFAULT use_syslog $SYSLOG
117 117
     iniset $GLANCE_REGISTRY_CONF paste_deploy flavor keystone
118
-    configure_auth_token_middleware $GLANCE_REGISTRY_CONF glance $GLANCE_AUTH_CACHE_DIR/registry
118
+    configure_auth_token_middleware $GLANCE_REGISTRY_CONF glance
119 119
     iniset $GLANCE_REGISTRY_CONF oslo_messaging_notifications driver messagingv2
120 120
     iniset_rpc_backend glance $GLANCE_REGISTRY_CONF
121 121
     iniset $GLANCE_REGISTRY_CONF DEFAULT graceful_shutdown_timeout "$SERVICE_GRACEFUL_SHUTDOWN_TIMEOUT"
... ...
@@ -127,7 +126,7 @@ function configure_glance {
127 127
     iniset $GLANCE_API_CONF DEFAULT image_cache_dir $GLANCE_CACHE_DIR/
128 128
     iniset $GLANCE_API_CONF DEFAULT lock_path $GLANCE_LOCK_DIR
129 129
     iniset $GLANCE_API_CONF paste_deploy flavor keystone+cachemanagement
130
-    configure_auth_token_middleware $GLANCE_API_CONF glance $GLANCE_AUTH_CACHE_DIR/api
130
+    configure_auth_token_middleware $GLANCE_API_CONF glance
131 131
     iniset $GLANCE_API_CONF oslo_messaging_notifications driver messagingv2
132 132
     iniset_rpc_backend glance $GLANCE_API_CONF
133 133
     if [ "$VIRT_DRIVER" = 'xenserver' ]; then
... ...
@@ -279,13 +278,6 @@ function create_glance_accounts {
279 279
     fi
280 280
 }
281 281
 
282
-# create_glance_cache_dir() - Part of the init_glance() process
283
-function create_glance_cache_dir {
284
-    # Create cache dir
285
-    sudo install -d -o $STACK_USER $GLANCE_AUTH_CACHE_DIR/api $GLANCE_AUTH_CACHE_DIR/registry $GLANCE_AUTH_CACHE_DIR/search $GLANCE_AUTH_CACHE_DIR/artifact
286
-    rm -f $GLANCE_AUTH_CACHE_DIR/api/* $GLANCE_AUTH_CACHE_DIR/registry/* $GLANCE_AUTH_CACHE_DIR/search/* $GLANCE_AUTH_CACHE_DIR/artifact/*
287
-}
288
-
289 282
 # init_glance() - Initialize databases, etc.
290 283
 function init_glance {
291 284
     # Delete existing images
... ...
@@ -306,8 +298,6 @@ function init_glance {
306 306
     # Load metadata definitions
307 307
     $GLANCE_BIN_DIR/glance-manage --config-file $GLANCE_CONF_DIR/glance-api.conf db_load_metadefs
308 308
     time_stop "dbsync"
309
-
310
-    create_glance_cache_dir
311 309
 }
312 310
 
313 311
 # install_glanceclient() - Collect source and prepare
... ...
@@ -429,7 +429,7 @@ function create_service_user {
429 429
 
430 430
 # Configure the service to use the auth token middleware.
431 431
 #
432
-# configure_auth_token_middleware conf_file admin_user signing_dir [section]
432
+# configure_auth_token_middleware conf_file admin_user [section]
433 433
 #
434 434
 # section defaults to keystone_authtoken, which is where auth_token looks in
435 435
 # the .conf file. If the paste config file is used (api-paste.ini) then
... ...
@@ -437,8 +437,7 @@ function create_service_user {
437 437
 function configure_auth_token_middleware {
438 438
     local conf_file=$1
439 439
     local admin_user=$2
440
-    local signing_dir=$3
441
-    local section=${4:-keystone_authtoken}
440
+    local section=${3:-keystone_authtoken}
442 441
 
443 442
     iniset $conf_file $section auth_type password
444 443
     iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI
... ...
@@ -449,7 +448,6 @@ function configure_auth_token_middleware {
449 449
     iniset $conf_file $section project_domain_name "$SERVICE_DOMAIN_NAME"
450 450
 
451 451
     iniset $conf_file $section cafile $SSL_BUNDLE_FILE
452
-    iniset $conf_file $section signing_dir $signing_dir
453 452
     iniset $conf_file $section memcached_servers localhost:11211
454 453
 }
455 454
 
... ...
@@ -30,7 +30,6 @@ GITDIR["python-neutronclient"]=$DEST/python-neutronclient
30 30
 
31 31
 NEUTRON_AGENT=${NEUTRON_AGENT:-openvswitch}
32 32
 NEUTRON_DIR=$DEST/neutron
33
-NEUTRON_AUTH_CACHE_DIR=${NEUTRON_AUTH_CACHE_DIR:-/var/cache/neutron}
34 33
 
35 34
 NEUTRON_BIN_DIR=$(get_python_exec_prefix)
36 35
 NEUTRON_DHCP_BINARY="neutron-dhcp-agent"
... ...
@@ -44,7 +43,6 @@ NEUTRON_L3_CONF=$NEUTRON_CONF_DIR/l3_agent.ini
44 44
 NEUTRON_AGENT_CONF=$NEUTRON_CONF_DIR/
45 45
 
46 46
 NEUTRON_STATE_PATH=${NEUTRON_STATE_PATH:=$DATA_DIR/neutron}
47
-NEUTRON_AUTH_CACHE_DIR=${NEUTRON_AUTH_CACHE_DIR:-/var/cache/neutron}
48 47
 
49 48
 # By default, use the ML2 plugin
50 49
 NEUTRON_CORE_PLUGIN=${NEUTRON_CORE_PLUGIN:-ml2}
... ...
@@ -175,8 +173,8 @@ function configure_neutron_new {
175 175
         iniset $NEUTRON_CONF DEFAULT allow_overlapping_ips True
176 176
 
177 177
         iniset $NEUTRON_CONF DEFAULT auth_strategy $NEUTRON_AUTH_STRATEGY
178
-        configure_auth_token_middleware $NEUTRON_CONF neutron $NEUTRON_AUTH_CACHE_DIR keystone_authtoken
179
-        configure_auth_token_middleware $NEUTRON_CONF nova $NEUTRON_AUTH_CACHE_DIR nova
178
+        configure_auth_token_middleware $NEUTRON_CONF neutron keystone_authtoken
179
+        configure_auth_token_middleware $NEUTRON_CONF nova nova
180 180
 
181 181
         # Configure VXLAN
182 182
         # TODO(sc68cal) not hardcode?
... ...
@@ -250,7 +248,7 @@ function configure_neutron_new {
250 250
 
251 251
         # TODO(dtroyer): remove the v2.0 hard code below
252 252
         iniset $NEUTRON_META_CONF DEFAULT auth_url $KEYSTONE_SERVICE_URI
253
-        configure_auth_token_middleware $NEUTRON_META_CONF neutron $NEUTRON_AUTH_CACHE_DIR DEFAULT
253
+        configure_auth_token_middleware $NEUTRON_META_CONF neutron DEFAULT
254 254
     fi
255 255
 
256 256
     # Format logging
... ...
@@ -337,13 +335,6 @@ function create_neutron_accounts_new {
337 337
     fi
338 338
 }
339 339
 
340
-# create_neutron_cache_dir() - Part of the init_neutron() process
341
-function create_neutron_cache_dir {
342
-    # Create cache dir
343
-    sudo install -d -o $STACK_USER $NEUTRON_AUTH_CACHE_DIR
344
-    rm -f $NEUTRON_AUTH_CACHE_DIR/*
345
-}
346
-
347 340
 # init_neutron() - Initialize databases, etc.
348 341
 function init_neutron_new {
349 342
 
... ...
@@ -353,8 +344,6 @@ function init_neutron_new {
353 353
     # Run Neutron db migrations
354 354
     $NEUTRON_BIN_DIR/neutron-db-manage upgrade heads
355 355
     time_stop "dbsync"
356
-
357
-    create_neutron_cache_dir
358 356
 }
359 357
 
360 358
 # install_neutron() - Collect source and prepare
... ...
@@ -73,7 +73,6 @@ GITDIR["python-neutronclient"]=$DEST/python-neutronclient
73 73
 
74 74
 NEUTRON_DIR=$DEST/neutron
75 75
 NEUTRON_FWAAS_DIR=$DEST/neutron-fwaas
76
-NEUTRON_AUTH_CACHE_DIR=${NEUTRON_AUTH_CACHE_DIR:-/var/cache/neutron}
77 76
 
78 77
 # Support entry points installation of console scripts
79 78
 if [[ -d $NEUTRON_DIR/bin/neutron-server ]]; then
... ...
@@ -815,7 +814,7 @@ function _configure_neutron_service {
815 815
     iniset $NEUTRON_CONF DEFAULT notify_nova_on_port_status_changes $Q_NOTIFY_NOVA_PORT_STATUS_CHANGES
816 816
     iniset $NEUTRON_CONF DEFAULT notify_nova_on_port_data_changes $Q_NOTIFY_NOVA_PORT_DATA_CHANGES
817 817
 
818
-    configure_auth_token_middleware $NEUTRON_CONF nova $NEUTRON_AUTH_CACHE_DIR nova
818
+    configure_auth_token_middleware $NEUTRON_CONF nova nova
819 819
 
820 820
     # Configure plugin
821 821
     neutron_plugin_configure_service
... ...
@@ -906,8 +905,7 @@ function _neutron_setup_keystone {
906 906
     local conf_file=$1
907 907
     local section=$2
908 908
 
909
-    create_neutron_cache_dir
910
-    configure_auth_token_middleware $conf_file $Q_ADMIN_USERNAME $NEUTRON_AUTH_CACHE_DIR $section
909
+    configure_auth_token_middleware $conf_file $Q_ADMIN_USERNAME $section
911 910
 }
912 911
 
913 912
 function _neutron_setup_interface_driver {
... ...
@@ -46,7 +46,6 @@ fi
46 46
 NOVA_STATE_PATH=${NOVA_STATE_PATH:=$DATA_DIR/nova}
47 47
 # INSTANCES_PATH is the previous name for this
48 48
 NOVA_INSTANCES_PATH=${NOVA_INSTANCES_PATH:=${INSTANCES_PATH:=$NOVA_STATE_PATH/instances}}
49
-NOVA_AUTH_CACHE_DIR=${NOVA_AUTH_CACHE_DIR:-/var/cache/nova}
50 49
 
51 50
 NOVA_CONF_DIR=/etc/nova
52 51
 NOVA_CONF=$NOVA_CONF_DIR/nova.conf
... ...
@@ -240,7 +239,7 @@ function cleanup_nova {
240 240
         sudo rm -rf $NOVA_INSTANCES_PATH/*
241 241
     fi
242 242
 
243
-    sudo rm -rf $NOVA_STATE_PATH $NOVA_AUTH_CACHE_DIR
243
+    sudo rm -rf $NOVA_STATE_PATH
244 244
 
245 245
     # NOTE(dtroyer): This really should be called from here but due to the way
246 246
     #                nova abuses the _cleanup() function we're moving it
... ...
@@ -464,7 +463,7 @@ function create_nova_conf {
464 464
             iniset $NOVA_CONF DEFAULT osapi_compute_link_prefix $NOVA_SERVICE_PROTOCOL://$NOVA_SERVICE_HOST:$NOVA_SERVICE_PORT
465 465
         fi
466 466
 
467
-        configure_auth_token_middleware $NOVA_CONF nova $NOVA_AUTH_CACHE_DIR
467
+        configure_auth_token_middleware $NOVA_CONF nova
468 468
     fi
469 469
 
470 470
     if is_service_enabled cinder; then
... ...
@@ -658,13 +657,6 @@ function init_nova_cells {
658 658
     fi
659 659
 }
660 660
 
661
-# create_nova_cache_dir() - Part of the init_nova() process
662
-function create_nova_cache_dir {
663
-    # Create cache dir
664
-    sudo install -d -o $STACK_USER $NOVA_AUTH_CACHE_DIR
665
-    rm -f $NOVA_AUTH_CACHE_DIR/*
666
-}
667
-
668 661
 function create_nova_conf_nova_network {
669 662
     local public_interface=${PUBLIC_INTERFACE:-$PUBLIC_INTERFACE_DEFAULT}
670 663
     iniset $NOVA_CONF DEFAULT network_manager "nova.network.manager.$NETWORK_MANAGER"
... ...
@@ -722,7 +714,6 @@ function init_nova {
722 722
         done
723 723
     fi
724 724
 
725
-    create_nova_cache_dir
726 725
     create_nova_keys_dir
727 726
 
728 727
     if [[ "$NOVA_BACKEND" == "LVM" ]]; then
... ...
@@ -48,7 +48,6 @@ fi
48 48
 
49 49
 
50 50
 SWIFT_DIR=$DEST/swift
51
-SWIFT_AUTH_CACHE_DIR=${SWIFT_AUTH_CACHE_DIR:-/var/cache/swift}
52 51
 SWIFT_APACHE_WSGI_DIR=${SWIFT_APACHE_WSGI_DIR:-/var/www/swift}
53 52
 SWIFT3_DIR=$DEST/swift3
54 53
 
... ...
@@ -450,7 +449,7 @@ function configure_swift {
450 450
     iniset ${SWIFT_CONFIG_PROXY_SERVER} filter:authtoken log_name swift
451 451
 
452 452
     iniset ${SWIFT_CONFIG_PROXY_SERVER} filter:authtoken paste.filter_factory keystonemiddleware.auth_token:filter_factory
453
-    configure_auth_token_middleware $SWIFT_CONFIG_PROXY_SERVER swift $SWIFT_AUTH_CACHE_DIR filter:authtoken
453
+    configure_auth_token_middleware $SWIFT_CONFIG_PROXY_SERVER swift filter:authtoken
454 454
     iniset ${SWIFT_CONFIG_PROXY_SERVER} filter:authtoken delay_auth_decision 1
455 455
     iniset ${SWIFT_CONFIG_PROXY_SERVER} filter:authtoken cache swift.cache
456 456
     iniset ${SWIFT_CONFIG_PROXY_SERVER} filter:authtoken include_service_catalog False
... ...
@@ -745,10 +744,6 @@ function init_swift {
745 745
         swift-ring-builder container.builder rebalance 42
746 746
         swift-ring-builder account.builder rebalance 42
747 747
     } && popd >/dev/null
748
-
749
-    # Create cache dir
750
-    sudo install -d -o ${STACK_USER} $SWIFT_AUTH_CACHE_DIR
751
-    rm -f $SWIFT_AUTH_CACHE_DIR/*
752 748
 }
753 749
 
754 750
 function install_swift {