We should be using $VOLUME_GROUP_NAME instead since Icehouse.
$VOLUME_GROUP_NAME has been introduced in
I93b8ef32832269d730c76a6dc24ddb4f20c6d9df and $VOLUME_GROUP is nowadays
only use as a fallback to $VOLUME_GROUP_NAME.
As a code comment in lib/lvm says it we kept the $VOLUME_GROUP around as
"for compatibility with icehouse-generation Grenade". Icehouse is long
gone so now seems a good time to remove any usage of $VOLUME_GROUP.
Change-Id: Id3051b5a196c45266c39fde4f08401aaacf0f6bd
... | ... |
@@ -703,13 +703,13 @@ Cinder |
703 | 703 |
~~~~~~ |
704 | 704 |
|
705 | 705 |
The logical volume group used to hold the Cinder-managed volumes is |
706 |
-set by ``VOLUME_GROUP``, the logical volume name prefix is set with |
|
706 |
+set by ``VOLUME_GROUP_NAME``, the logical volume name prefix is set with |
|
707 | 707 |
``VOLUME_NAME_PREFIX`` and the size of the volume backing file is set |
708 | 708 |
with ``VOLUME_BACKING_FILE_SIZE``. |
709 | 709 |
|
710 | 710 |
:: |
711 | 711 |
|
712 |
- VOLUME_GROUP="stack-volumes" |
|
712 |
+ VOLUME_GROUP_NAME="stack-volumes" |
|
713 | 713 |
VOLUME_NAME_PREFIX="volume-" |
714 | 714 |
VOLUME_BACKING_FILE_SIZE=10250M |
715 | 715 |
|
... | ... |
@@ -294,10 +294,10 @@ created inside OpenStack. The size can be overridden by setting |
294 | 294 |
|
295 | 295 |
``stack-volumes`` can be pre-created on any physical volume supported by |
296 | 296 |
Linux's LVM. The name of the volume group can be changed by setting |
297 |
-``VOLUME_GROUP`` in ``localrc``. ``stack.sh`` deletes all logical |
|
298 |
-volumes in ``VOLUME_GROUP`` that begin with ``VOLUME_NAME_PREFIX`` as |
|
297 |
+``VOLUME_GROUP_NAME`` in ``localrc``. ``stack.sh`` deletes all logical |
|
298 |
+volumes in ``VOLUME_GROUP_NAME`` that begin with ``VOLUME_NAME_PREFIX`` as |
|
299 | 299 |
part of cleaning up from previous runs. It is recommended to not use the |
300 |
-root volume group as ``VOLUME_GROUP``. |
|
300 |
+root volume group as ``VOLUME_GROUP_NAME``. |
|
301 | 301 |
|
302 | 302 |
The details of creating the volume group depends on the server hardware |
303 | 303 |
involved but looks something like this: |
... | ... |
@@ -23,11 +23,7 @@ set +o xtrace |
23 | 23 |
# Defaults |
24 | 24 |
# -------- |
25 | 25 |
# Name of the lvm volume groups to use/create for iscsi volumes |
26 |
-# This monkey-motion is for compatibility with icehouse-generation Grenade |
|
27 |
-# If ``VOLUME_GROUP`` is set, use it, otherwise we'll build a VG name based |
|
28 |
-# on ``VOLUME_GROUP_NAME`` that includes the backend name |
|
29 |
-# Grenade doesn't use ``VOLUME_GROUP2`` so it is left out |
|
30 |
-VOLUME_GROUP_NAME=${VOLUME_GROUP:-${VOLUME_GROUP_NAME:-stack-volumes}} |
|
26 |
+VOLUME_GROUP_NAME=${VOLUME_GROUP_NAME:-stack-volumes} |
|
31 | 27 |
DEFAULT_VOLUME_GROUP_NAME=$VOLUME_GROUP_NAME-default |
32 | 28 |
|
33 | 29 |
# Backing file name is of the form $VOLUME_GROUP$BACKING_FILE_SUFFIX |