integration-cli/docker_cli_cp_to_container_test.go
418135e7
 package main
 
 import (
 	"os"
d6e1cc32
 	"runtime"
ebcb7d6b
 	"strings"
418135e7
 
33968e6c
 	"github.com/docker/docker/integration-cli/checker"
418135e7
 	"github.com/go-check/check"
 )
 
 // docker cp LOCALPATH CONTAINER:PATH
 
 // Try all of the test cases from the archive package which implements the
 // internals of `docker cp` and ensure that the behavior matches when actually
 // copying to and from containers.
 
 // Basic assumptions about SRC and DST:
 // 1. SRC must exist.
 // 2. If SRC ends with a trailing separator, it must be a directory.
 // 3. DST parent directory must exist.
 // 4. If DST exists as a file, it must not end with a trailing separator.
 
 // First get these easy error cases out of the way.
 
 // Test for error when SRC does not exist.
 func (s *DockerSuite) TestCpToErrSrcNotExists(c *check.C) {
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-to-err-src-not-exists")
 	defer os.RemoveAll(tmpDir)
 
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstPath := containerCpPath(containerID, "file1")
ebcb7d6b
 	_, srcStatErr := os.Stat(srcPath)
 	c.Assert(os.IsNotExist(srcStatErr), checker.True)
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstPath, nil)
d6e1cc32
 	if runtime.GOOS == "windows" {
 		// Go 1.9+ on Windows returns a different error for `os.Stat()`, see
 		// https://github.com/golang/go/commit/6144c7270e5812d9de8fb97456ee4e5ae657fcbb#diff-f63e1a4b4377b2fe0b05011db3df9599
 		//
 		// Go 1.8: CreateFile C:\not-exist: The system cannot find the file specified.
 		// Go 1.9: GetFileAttributesEx C:\not-exist: The system cannot find the file specified.
 		//
 		// Due to the CLI using a different version than the daemon, comparing the
 		// error message won't work, so just hard-code the common part here.
 		//
 		// TODO this should probably be a test in the CLI repository instead
 		c.Assert(strings.ToLower(err.Error()), checker.Contains, "cannot find the file specified")
 		c.Assert(strings.ToLower(err.Error()), checker.Contains, strings.ToLower(tmpDir))
 	} else {
 		c.Assert(strings.ToLower(err.Error()), checker.Contains, strings.ToLower(srcStatErr.Error()))
 	}
418135e7
 }
 
 // Test for error when SRC ends in a trailing
 // path separator but it exists as a file.
 func (s *DockerSuite) TestCpToErrSrcNotDir(c *check.C) {
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-to-err-src-not-dir")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcPath := cpPathTrailingSep(tmpDir, "file1")
f26a31e8
 	dstPath := containerCpPath(containerID, "testDir")
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstPath, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpNotDir(err), checker.True, check.Commentf("expected IsNotDir error, but got %T: %s", err, err))
418135e7
 }
 
 // Test for error when SRC is a valid file or directory,
ba0afd70
 // but the DST parent directory does not exist.
418135e7
 func (s *DockerSuite) TestCpToErrDstParentNotExists(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{addContent: true})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-to-err-dst-parent-not-exists")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	// Try with a file source.
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstPath := containerCpPath(containerID, "/notExists", "file1")
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstPath, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpNotExist(err), checker.True, check.Commentf("expected IsNotExist error, but got %T: %s", err, err))
418135e7
 
 	// Try with a directory source.
 	srcPath = cpPath(tmpDir, "dir1")
 
8a7ff5ff
 	err = runDockerCp(c, srcPath, dstPath, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpNotExist(err), checker.True, check.Commentf("expected IsNotExist error, but got %T: %s", err, err))
418135e7
 }
 
 // Test for error when DST ends in a trailing path separator but exists as a
927b334e
 // file. Also test that we cannot overwrite an existing directory with a
418135e7
 // non-directory and cannot overwrite an existing
 func (s *DockerSuite) TestCpToErrDstNotDir(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{addContent: true})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-to-err-dst-not-dir")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	// Try with a file source.
 	srcPath := cpPath(tmpDir, "dir1/file1-1")
f26a31e8
 	dstPath := containerCpPathTrailingSep(containerID, "file1")
418135e7
 
 	// The client should encounter an error trying to stat the destination
 	// and then be unable to copy since the destination is asserted to be a
 	// directory but does not exist.
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstPath, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpDirNotExist(err), checker.True, check.Commentf("expected DirNotExist error, but got %T: %s", err, err))
418135e7
 
 	// Try with a directory source.
 	srcPath = cpPath(tmpDir, "dir1")
 
 	// The client should encounter an error trying to stat the destination and
 	// then decide to extract to the parent directory instead with a rebased
 	// name in the source archive, but this directory would overwrite the
 	// existing file with the same name.
8a7ff5ff
 	err = runDockerCp(c, srcPath, dstPath, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCannotOverwriteNonDirWithDir(err), checker.True, check.Commentf("expected CannotOverwriteNonDirWithDir error, but got %T: %s", err, err))
418135e7
 }
 
75f6929b
 // Check that copying from a local path to a symlink in a container copies to
 // the symlink target and does not overwrite the container symlink itself.
 func (s *DockerSuite) TestCpToSymlinkDestination(c *check.C) {
ea3afdad
 	//  stat /tmp/test-cp-to-symlink-destination-262430901/vol3 gets permission denied for the user
 	testRequires(c, NotUserNamespace)
f9a3558a
 	testRequires(c, DaemonIsLinux)
75f6929b
 	testRequires(c, SameHostDaemon) // Requires local volume mount bind.
 
 	testVol := getTestDir(c, "test-cp-to-symlink-destination-")
 	defer os.RemoveAll(testVol)
 
 	makeTestContentInDir(c, testVol)
 
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
75f6929b
 		volumes: defaultVolumes(testVol), // Our bind mount is at /vol2
 	})
 
 	// First, copy a local file to a symlink to a file in the container. This
 	// should overwrite the symlink target contents with the source contents.
 	srcPath := cpPath(testVol, "file2")
f26a31e8
 	dstPath := containerCpPath(containerID, "/vol2/symlinkToFile1")
75f6929b
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstPath, nil), checker.IsNil)
75f6929b
 
 	// The symlink should not have been modified.
f26a31e8
 	c.Assert(symlinkTargetEquals(c, cpPath(testVol, "symlinkToFile1"), "file1"), checker.IsNil)
75f6929b
 
 	// The file should have the contents of "file2" now.
f26a31e8
 	c.Assert(fileContentEquals(c, cpPath(testVol, "file1"), "file2\n"), checker.IsNil)
75f6929b
 
 	// Next, copy a local file to a symlink to a directory in the container.
 	// This should copy the file into the symlink target directory.
f26a31e8
 	dstPath = containerCpPath(containerID, "/vol2/symlinkToDir1")
75f6929b
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstPath, nil), checker.IsNil)
75f6929b
 
 	// The symlink should not have been modified.
f26a31e8
 	c.Assert(symlinkTargetEquals(c, cpPath(testVol, "symlinkToDir1"), "dir1"), checker.IsNil)
75f6929b
 
 	// The file should have the contents of "file2" now.
f26a31e8
 	c.Assert(fileContentEquals(c, cpPath(testVol, "file2"), "file2\n"), checker.IsNil)
75f6929b
 
 	// Next, copy a file to a symlink to a file that does not exist (a broken
 	// symlink) in the container. This should create the target file with the
 	// contents of the source file.
f26a31e8
 	dstPath = containerCpPath(containerID, "/vol2/brokenSymlinkToFileX")
75f6929b
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstPath, nil), checker.IsNil)
75f6929b
 
 	// The symlink should not have been modified.
f26a31e8
 	c.Assert(symlinkTargetEquals(c, cpPath(testVol, "brokenSymlinkToFileX"), "fileX"), checker.IsNil)
75f6929b
 
 	// The file should have the contents of "file2" now.
f26a31e8
 	c.Assert(fileContentEquals(c, cpPath(testVol, "fileX"), "file2\n"), checker.IsNil)
75f6929b
 
 	// Next, copy a local directory to a symlink to a directory in the
 	// container. This should copy the directory into the symlink target
 	// directory and not modify the symlink.
 	srcPath = cpPath(testVol, "/dir2")
f26a31e8
 	dstPath = containerCpPath(containerID, "/vol2/symlinkToDir1")
75f6929b
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstPath, nil), checker.IsNil)
75f6929b
 
 	// The symlink should not have been modified.
f26a31e8
 	c.Assert(symlinkTargetEquals(c, cpPath(testVol, "symlinkToDir1"), "dir1"), checker.IsNil)
75f6929b
 
 	// The directory should now contain a copy of "dir2".
f26a31e8
 	c.Assert(fileContentEquals(c, cpPath(testVol, "dir1/dir2/file2-1"), "file2-1\n"), checker.IsNil)
75f6929b
 
 	// Next, copy a local directory to a symlink to a local directory that does
 	// not exist (a broken symlink) in the container. This should create the
 	// target as a directory with the contents of the source directory. It
 	// should not modify the symlink.
f26a31e8
 	dstPath = containerCpPath(containerID, "/vol2/brokenSymlinkToDirX")
75f6929b
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstPath, nil), checker.IsNil)
75f6929b
 
 	// The symlink should not have been modified.
f26a31e8
 	c.Assert(symlinkTargetEquals(c, cpPath(testVol, "brokenSymlinkToDirX"), "dirX"), checker.IsNil)
75f6929b
 
 	// The "dirX" directory should now be a copy of "dir2".
f26a31e8
 	c.Assert(fileContentEquals(c, cpPath(testVol, "dirX/file2-1"), "file2-1\n"), checker.IsNil)
75f6929b
 }
 
418135e7
 // Possibilities are reduced to the remaining 10 cases:
 //
 //  case | srcIsDir | onlyDirContents | dstExists | dstIsDir | dstTrSep | action
 // ===================================================================================================
 //   A   |  no      |  -              |  no       |  -       |  no      |  create file
 //   B   |  no      |  -              |  no       |  -       |  yes     |  error
 //   C   |  no      |  -              |  yes      |  no      |  -       |  overwrite file
 //   D   |  no      |  -              |  yes      |  yes     |  -       |  create file in dst dir
 //   E   |  yes     |  no             |  no       |  -       |  -       |  create dir, copy contents
 //   F   |  yes     |  no             |  yes      |  no      |  -       |  error
 //   G   |  yes     |  no             |  yes      |  yes     |  -       |  copy dir and contents
 //   H   |  yes     |  yes            |  no       |  -       |  -       |  create dir, copy contents
 //   I   |  yes     |  yes            |  yes      |  no      |  -       |  error
 //   J   |  yes     |  yes            |  yes      |  yes     |  -       |  copy dir contents
 //
 
 // A. SRC specifies a file and DST (no trailing path separator) doesn't
 //    exist. This should create a file with the name DST and copy the
 //    contents of the source file into it.
 func (s *DockerSuite) TestCpToCaseA(c *check.C) {
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		workDir: "/root", command: makeCatFileCommand("itWorks.txt"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-a")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstPath := containerCpPath(containerID, "/root/itWorks.txt")
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstPath, nil), checker.IsNil)
418135e7
 
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1\n"), checker.IsNil)
418135e7
 }
 
 // B. SRC specifies a file and DST (with trailing path separator) doesn't
 //    exist. This should cause an error because the copy operation cannot
 //    create a directory when copying a single file.
 func (s *DockerSuite) TestCpToCaseB(c *check.C) {
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		command: makeCatFileCommand("testDir/file1"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-b")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstDir := containerCpPathTrailingSep(containerID, "testDir")
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstDir, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpDirNotExist(err), checker.True, check.Commentf("expected DirNotExists error, but got %T: %s", err, err))
418135e7
 }
 
 // C. SRC specifies a file and DST exists as a file. This should overwrite
 //    the file at DST with the contents of the source file.
 func (s *DockerSuite) TestCpToCaseC(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 		command: makeCatFileCommand("file2"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-c")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstPath := containerCpPath(containerID, "/root/file2")
418135e7
 
 	// Ensure the container's file starts with the original content.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file2\n"), checker.IsNil)
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstPath, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1\n"), checker.IsNil)
418135e7
 }
 
 // D. SRC specifies a file and DST exists as a directory. This should place
 //    a copy of the source file inside it using the basename from SRC. Ensure
 //    this works whether DST has a trailing path separator or not.
 func (s *DockerSuite) TestCpToCaseD(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true,
 		command:    makeCatFileCommand("/dir1/file1"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-d")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstDir := containerCpPath(containerID, "dir1")
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1\n"), checker.IsNil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
 	// Make new destination container.
f26a31e8
 	containerID = makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true,
 		command:    makeCatFileCommand("/dir1/file1"),
 	})
 
f26a31e8
 	dstDir = containerCpPathTrailingSep(containerID, "dir1")
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcPath, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1\n"), checker.IsNil)
418135e7
 }
 
 // E. SRC specifies a directory and DST does not exist. This should create a
 //    directory at DST and copy the contents of the SRC directory into the DST
 //    directory. Ensure this works whether DST has a trailing path separator or
 //    not.
 func (s *DockerSuite) TestCpToCaseE(c *check.C) {
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		command: makeCatFileCommand("/testDir/file1-1"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-e")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcDir := cpPath(tmpDir, "dir1")
f26a31e8
 	dstDir := containerCpPath(containerID, "testDir")
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
 	// Make new destination container.
f26a31e8
 	containerID = makeTestContainer(c, testContainerOptions{
418135e7
 		command: makeCatFileCommand("/testDir/file1-1"),
 	})
 
f26a31e8
 	dstDir = containerCpPathTrailingSep(containerID, "testDir")
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 }
 
 // F. SRC specifies a directory and DST exists as a file. This should cause an
 //    error as it is not possible to overwrite a file with a directory.
 func (s *DockerSuite) TestCpToCaseF(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-f")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcDir := cpPath(tmpDir, "dir1")
f26a31e8
 	dstFile := containerCpPath(containerID, "/root/file1")
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcDir, dstFile, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpCannotCopyDir(err), checker.True, check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
418135e7
 }
 
 // G. SRC specifies a directory and DST exists as a directory. This should copy
 //    the SRC directory and all its contents to the DST directory. Ensure this
 //    works whether DST has a trailing path separator or not.
 func (s *DockerSuite) TestCpToCaseG(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 		command: makeCatFileCommand("dir2/dir1/file1-1"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-g")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcDir := cpPath(tmpDir, "dir1")
f26a31e8
 	dstDir := containerCpPath(containerID, "/root/dir2")
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
 	// Make new destination container.
f26a31e8
 	containerID = makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true,
 		command:    makeCatFileCommand("/dir2/dir1/file1-1"),
 	})
 
f26a31e8
 	dstDir = containerCpPathTrailingSep(containerID, "/dir2")
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 }
 
 // H. SRC specifies a directory's contents only and DST does not exist. This
 //    should create a directory at DST and copy the contents of the SRC
 //    directory (but not the directory itself) into the DST directory. Ensure
 //    this works whether DST has a trailing path separator or not.
 func (s *DockerSuite) TestCpToCaseH(c *check.C) {
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		command: makeCatFileCommand("/testDir/file1-1"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-h")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcDir := cpPathTrailingSep(tmpDir, "dir1") + "."
f26a31e8
 	dstDir := containerCpPath(containerID, "testDir")
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
 	// Make new destination container.
f26a31e8
 	containerID = makeTestContainer(c, testContainerOptions{
418135e7
 		command: makeCatFileCommand("/testDir/file1-1"),
 	})
 
f26a31e8
 	dstDir = containerCpPathTrailingSep(containerID, "testDir")
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 }
 
7b4e6fc4
 // I. SRC specifies a directory's contents only and DST exists as a file. This
418135e7
 //    should cause an error as it is not possible to overwrite a file with a
 //    directory.
 func (s *DockerSuite) TestCpToCaseI(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-i")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcDir := cpPathTrailingSep(tmpDir, "dir1") + "."
f26a31e8
 	dstFile := containerCpPath(containerID, "/root/file1")
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcDir, dstFile, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpCannotCopyDir(err), checker.True, check.Commentf("expected ErrCannotCopyDir error, but got %T: %s", err, err))
418135e7
 }
 
 // J. SRC specifies a directory's contents only and DST exists as a directory.
 //    This should copy the contents of the SRC directory (but not the directory
 //    itself) into the DST directory. Ensure this works whether DST has a
 //    trailing path separator or not.
 func (s *DockerSuite) TestCpToCaseJ(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 		command: makeCatFileCommand("/dir2/file1-1"),
 	})
 
 	tmpDir := getTestDir(c, "test-cp-to-case-j")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	srcDir := cpPathTrailingSep(tmpDir, "dir1") + "."
f26a31e8
 	dstDir := containerCpPath(containerID, "/dir2")
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
 	// Make new destination container.
f26a31e8
 	containerID = makeTestContainer(c, testContainerOptions{
418135e7
 		command: makeCatFileCommand("/dir2/file1-1"),
 	})
 
f26a31e8
 	dstDir = containerCpPathTrailingSep(containerID, "/dir2")
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 
8a7ff5ff
 	c.Assert(runDockerCp(c, srcDir, dstDir, nil), checker.IsNil)
418135e7
 
 	// Should now contain file1-1's contents.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, "file1-1\n"), checker.IsNil)
418135e7
 }
 
 // The `docker cp` command should also ensure that you cannot
 // write to a container rootfs that is marked as read-only.
 func (s *DockerSuite) TestCpToErrReadOnlyRootfs(c *check.C) {
ea3afdad
 	// --read-only + userns has remount issues
 	testRequires(c, DaemonIsLinux, NotUserNamespace)
418135e7
 	tmpDir := getTestDir(c, "test-cp-to-err-read-only-rootfs")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		readOnly: true, workDir: "/root",
 		command: makeCatFileCommand("shouldNotExist"),
 	})
 
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstPath := containerCpPath(containerID, "/root/shouldNotExist")
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstPath, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpCannotCopyReadOnly(err), checker.True, check.Commentf("expected ErrContainerRootfsReadonly error, but got %T: %s", err, err))
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 }
 
 // The `docker cp` command should also ensure that you
 // cannot write to a volume that is mounted as read-only.
 func (s *DockerSuite) TestCpToErrReadOnlyVolume(c *check.C) {
ea3afdad
 	// --read-only + userns has remount issues
 	testRequires(c, DaemonIsLinux, NotUserNamespace)
418135e7
 	tmpDir := getTestDir(c, "test-cp-to-err-read-only-volume")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		volumes: defaultVolumes(tmpDir), workDir: "/root",
 		command: makeCatFileCommand("/vol_ro/shouldNotExist"),
 	})
 
 	srcPath := cpPath(tmpDir, "file1")
f26a31e8
 	dstPath := containerCpPath(containerID, "/vol_ro/shouldNotExist")
418135e7
 
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstPath, nil)
f26a31e8
 	c.Assert(err, checker.NotNil)
418135e7
 
f26a31e8
 	c.Assert(isCpCannotCopyReadOnly(err), checker.True, check.Commentf("expected ErrVolumeReadonly error, but got %T: %s", err, err))
418135e7
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	c.Assert(containerStartOutputEquals(c, containerID, ""), checker.IsNil)
418135e7
 }