daemon/create_windows.go
47c56e43
 package daemon
 
 import (
a7e686a7
 	"fmt"
 
6bb0d181
 	"github.com/docker/docker/container"
a7e686a7
 	"github.com/docker/docker/pkg/stringid"
 	"github.com/docker/docker/volume"
907407d0
 	containertypes "github.com/docker/engine-api/types/container"
47c56e43
 )
 
 // createContainerPlatformSpecificSettings performs platform specific container create functionality
7c70ad05
 func (daemon *Daemon) createContainerPlatformSpecificSettings(container *container.Container, config *containertypes.Config, hostConfig *containertypes.HostConfig) error {
6952135f
 	// Make sure the host config has the default daemon isolation if not specified by caller.
 	if containertypes.Isolation.IsDefault(containertypes.Isolation(hostConfig.Isolation)) {
 		hostConfig.Isolation = daemon.defaultIsolation
 	}
 
a7e686a7
 	for spec := range config.Volumes {
 
 		mp, err := volume.ParseMountSpec(spec, hostConfig.VolumeDriver)
 		if err != nil {
 			return fmt.Errorf("Unrecognised volume spec: %v", err)
 		}
 
 		// If the mountpoint doesn't have a name, generate one.
 		if len(mp.Name) == 0 {
 			mp.Name = stringid.GenerateNonCryptoID()
 		}
 
 		// Skip volumes for which we already have something mounted on that
 		// destination because of a --volume-from.
6bb0d181
 		if container.IsDestinationMounted(mp.Destination) {
a7e686a7
 			continue
 		}
 
 		volumeDriver := hostConfig.VolumeDriver
 
 		// Create the volume in the volume driver. If it doesn't exist,
 		// a new one will be created.
fc214b44
 		v, err := daemon.volumes.CreateWithRef(mp.Name, volumeDriver, container.ID, nil, nil)
a7e686a7
 		if err != nil {
 			return err
 		}
 
 		// FIXME Windows: This code block is present in the Linux version and
 		// allows the contents to be copied to the container FS prior to it
927b334e
 		// being started. However, the function utilizes the FollowSymLinkInScope
a7e686a7
 		// path which does not cope with Windows volume-style file paths. There
927b334e
 		// is a separate effort to resolve this (@swernli), so this processing
a7e686a7
 		// is deferred for now. A case where this would be useful is when
 		// a dockerfile includes a VOLUME statement, but something is created
 		// in that directory during the dockerfile processing. What this means
331c8a86
 		// on Windows for TP5 is that in that scenario, the contents will not
a7e686a7
 		// copied, but that's (somewhat) OK as HCS will bomb out soon after
 		// at it doesn't support mapped directories which have contents in the
 		// destination path anyway.
 		//
 		// Example for repro later:
 		//   FROM windowsservercore
 		//   RUN mkdir c:\myvol
 		//   RUN copy c:\windows\system32\ntdll.dll c:\myvol
 		//   VOLUME "c:\myvol"
 		//
 		// Then
 		//   docker build -t vol .
 		//   docker run -it --rm vol cmd  <-- This is where HCS will error out.
 		//
 		//	// never attempt to copy existing content in a container FS to a shared volume
 		//	if v.DriverName() == volume.DefaultDriverName {
6bb0d181
 		//		if err := container.CopyImagePathContent(v, mp.Destination); err != nil {
a7e686a7
 		//			return err
 		//		}
 		//	}
 
 		// Add it to container.MountPoints
6bb0d181
 		container.AddMountPointWithVolume(mp.Destination, v, mp.RW)
a7e686a7
 	}
47c56e43
 	return nil
 }