integration-cli/docker_cli_by_digest_test.go
a2b0c977
 package main
 
 import (
de52a3bc
 	"encoding/json"
a2b0c977
 	"fmt"
4352da78
 	"os"
 	"path/filepath"
a2b0c977
 	"regexp"
 	"strings"
 
de52a3bc
 	"github.com/docker/distribution/digest"
257c5925
 	"github.com/docker/distribution/manifest/schema1"
1fa2e311
 	"github.com/docker/distribution/manifest/schema2"
91e197d6
 	"github.com/docker/docker/api/types"
1c9a5d7b
 	"github.com/docker/docker/pkg/integration/checker"
f664f6e4
 	"github.com/docker/docker/pkg/stringutils"
dc944ea7
 	"github.com/go-check/check"
a2b0c977
 )
 
 var (
de52a3bc
 	remoteRepoName  = "dockercli/busybox-by-dgst"
55cec657
 	repoName        = fmt.Sprintf("%s/%s", privateRegistryURL, remoteRepoName)
ed13c3ab
 	pushDigestRegex = regexp.MustCompile("[\\S]+: digest: ([\\S]+) size: [0-9]+")
 	digestRegex     = regexp.MustCompile("Digest: ([\\S]+)")
a2b0c977
 )
 
de52a3bc
 func setupImage(c *check.C) (digest.Digest, error) {
5c295460
 	return setupImageWithTag(c, "latest")
a2b0c977
 }
 
de52a3bc
 func setupImageWithTag(c *check.C, tag string) (digest.Digest, error) {
a2b0c977
 	containerName := "busyboxbydigest"
 
e4468913
 	dockerCmd(c, "run", "-e", "digest=1", "--name", containerName, "busybox")
a2b0c977
 
 	// tag the image to upload it to the private registry
4352da78
 	repoAndTag := repoName + ":" + tag
1c9a5d7b
 	out, _, err := dockerCmdWithError("commit", containerName, repoAndTag)
 	c.Assert(err, checker.IsNil, check.Commentf("image tagging failed: %s", out))
a2b0c977
 
 	// delete the container as we don't need it any more
1c9a5d7b
 	err = deleteContainer(containerName)
 	c.Assert(err, checker.IsNil)
a2b0c977
 
 	// push the image
1c9a5d7b
 	out, _, err = dockerCmdWithError("push", repoAndTag)
 	c.Assert(err, checker.IsNil, check.Commentf("pushing the image to the private registry has failed: %s", out))
a2b0c977
 
 	// delete our local repo that we previously tagged
1c9a5d7b
 	rmiout, _, err := dockerCmdWithError("rmi", repoAndTag)
 	c.Assert(err, checker.IsNil, check.Commentf("error deleting images prior to real test: %s", rmiout))
a2b0c977
 
ed13c3ab
 	matches := pushDigestRegex.FindStringSubmatch(out)
1c9a5d7b
 	c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from push output: %s", out))
a2b0c977
 	pushDigest := matches[1]
 
de52a3bc
 	return digest.Digest(pushDigest), nil
a2b0c977
 }
 
1fa2e311
 func testPullByTagDisplaysDigest(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
5c295460
 	pushDigest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	// pull from the registry using the tag
5c295460
 	out, _ := dockerCmd(c, "pull", repoName)
a2b0c977
 
 	// the pull output includes "Digest: <digest>", so find that
 	matches := digestRegex.FindStringSubmatch(out)
1c9a5d7b
 	c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
a2b0c977
 	pullDigest := matches[1]
 
 	// make sure the pushed and pull digests match
1c9a5d7b
 	c.Assert(pushDigest.String(), checker.Equals, pullDigest)
a2b0c977
 }
 
1fa2e311
 func (s *DockerRegistrySuite) TestPullByTagDisplaysDigest(c *check.C) {
 	testPullByTagDisplaysDigest(c)
 }
 
 func (s *DockerSchema1RegistrySuite) TestPullByTagDisplaysDigest(c *check.C) {
 	testPullByTagDisplaysDigest(c)
 }
 
 func testPullByDigest(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
5c295460
 	pushDigest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
5c295460
 	out, _ := dockerCmd(c, "pull", imageReference)
a2b0c977
 
 	// the pull output includes "Digest: <digest>", so find that
 	matches := digestRegex.FindStringSubmatch(out)
1c9a5d7b
 	c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
a2b0c977
 	pullDigest := matches[1]
 
 	// make sure the pushed and pull digests match
1c9a5d7b
 	c.Assert(pushDigest.String(), checker.Equals, pullDigest)
a2b0c977
 }
 
1fa2e311
 func (s *DockerRegistrySuite) TestPullByDigest(c *check.C) {
 	testPullByDigest(c)
 }
 
 func (s *DockerSchema1RegistrySuite) TestPullByDigest(c *check.C) {
 	testPullByDigest(c)
 }
 
 func testPullByDigestNoFallback(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
642e6a37
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", repoName)
693ba98c
 	out, _, err := dockerCmdWithError("pull", imageReference)
1c9a5d7b
 	c.Assert(err, checker.NotNil, check.Commentf("expected non-zero exit status and correct error message when pulling non-existing image"))
19a93a6e
 	c.Assert(out, checker.Contains, fmt.Sprintf("manifest for %s not found", imageReference), check.Commentf("expected non-zero exit status and correct error message when pulling non-existing image"))
642e6a37
 }
 
1fa2e311
 func (s *DockerRegistrySuite) TestPullByDigestNoFallback(c *check.C) {
 	testPullByDigestNoFallback(c)
 }
 
 func (s *DockerSchema1RegistrySuite) TestPullByDigestNoFallback(c *check.C) {
 	testPullByDigestNoFallback(c)
 }
 
f696b107
 func (s *DockerRegistrySuite) TestCreateByDigest(c *check.C) {
5c295460
 	pushDigest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
 
 	containerName := "createByDigest"
62a856e9
 	dockerCmd(c, "create", "--name", containerName, imageReference)
a2b0c977
 
62a856e9
 	res := inspectField(c, containerName, "Config.Image")
1c9a5d7b
 	c.Assert(res, checker.Equals, imageReference)
a2b0c977
 }
 
f696b107
 func (s *DockerRegistrySuite) TestRunByDigest(c *check.C) {
5c295460
 	pushDigest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil)
a2b0c977
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
 
 	containerName := "runByDigest"
5c295460
 	out, _ := dockerCmd(c, "run", "--name", containerName, imageReference, "sh", "-c", "echo found=$digest")
a2b0c977
 
 	foundRegex := regexp.MustCompile("found=([^\n]+)")
 	matches := foundRegex.FindStringSubmatch(out)
1c9a5d7b
 	c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", out))
 	c.Assert(matches[1], checker.Equals, "1", check.Commentf("Expected %q, got %q", "1", matches[1]))
a2b0c977
 
62a856e9
 	res := inspectField(c, containerName, "Config.Image")
1c9a5d7b
 	c.Assert(res, checker.Equals, imageReference)
a2b0c977
 }
 
f696b107
 func (s *DockerRegistrySuite) TestRemoveImageByDigest(c *check.C) {
5c295460
 	digest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
5c295460
 	dockerCmd(c, "pull", imageReference)
a2b0c977
 
 	// make sure inspect runs ok
62a856e9
 	inspectField(c, imageReference, "Id")
a2b0c977
 
 	// do the delete
1c9a5d7b
 	err = deleteImages(imageReference)
 	c.Assert(err, checker.IsNil, check.Commentf("unexpected error deleting image"))
a2b0c977
 
 	// try to inspect again - it should error this time
62a856e9
 	_, err = inspectFieldWithError(imageReference, "Id")
1c9a5d7b
 	//unexpected nil err trying to inspect what should be a non-existent image
 	c.Assert(err, checker.NotNil)
3db9f7af
 	c.Assert(err.Error(), checker.Contains, "No such object")
a2b0c977
 }
 
f696b107
 func (s *DockerRegistrySuite) TestBuildByDigest(c *check.C) {
5c295460
 	digest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
5c295460
 	dockerCmd(c, "pull", imageReference)
a2b0c977
 
 	// get the image id
62a856e9
 	imageID := inspectField(c, imageReference, "Id")
a2b0c977
 
 	// do the build
 	name := "buildbydigest"
 	_, err = buildImage(name, fmt.Sprintf(
 		`FROM %s
      CMD ["/bin/echo", "Hello World"]`, imageReference),
 		true)
1c9a5d7b
 	c.Assert(err, checker.IsNil)
a2b0c977
 
 	// get the build's image id
62a856e9
 	res := inspectField(c, name, "Config.Image")
a2b0c977
 	// make sure they match
1c9a5d7b
 	c.Assert(res, checker.Equals, imageID)
a2b0c977
 }
 
f696b107
 func (s *DockerRegistrySuite) TestTagByDigest(c *check.C) {
5c295460
 	digest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
5c295460
 	dockerCmd(c, "pull", imageReference)
a2b0c977
 
 	// tag it
 	tag := "tagbydigest"
5c295460
 	dockerCmd(c, "tag", imageReference, tag)
a2b0c977
 
62a856e9
 	expectedID := inspectField(c, imageReference, "Id")
a2b0c977
 
62a856e9
 	tagID := inspectField(c, tag, "Id")
1c9a5d7b
 	c.Assert(tagID, checker.Equals, expectedID)
a2b0c977
 }
 
f696b107
 func (s *DockerRegistrySuite) TestListImagesWithoutDigests(c *check.C) {
5c295460
 	digest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
5c295460
 	dockerCmd(c, "pull", imageReference)
a2b0c977
 
5c295460
 	out, _ := dockerCmd(c, "images")
1c9a5d7b
 	c.Assert(out, checker.Not(checker.Contains), "DIGEST", check.Commentf("list output should not have contained DIGEST header"))
a2b0c977
 }
 
f696b107
 func (s *DockerRegistrySuite) TestListImagesWithDigests(c *check.C) {
a2b0c977
 
 	// setup image1
5c295460
 	digest1, err := setupImageWithTag(c, "tag1")
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 	imageReference1 := fmt.Sprintf("%s@%s", repoName, digest1)
dc944ea7
 	c.Logf("imageReference1 = %s", imageReference1)
a2b0c977
 
 	// pull image1 by digest
5c295460
 	dockerCmd(c, "pull", imageReference1)
a2b0c977
 
 	// list images
5c295460
 	out, _ := dockerCmd(c, "images", "--digests")
a2b0c977
 
 	// make sure repo shown, tag=<none>, digest = $digest1
de52a3bc
 	re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
1c9a5d7b
 	c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
a2b0c977
 	// setup image2
5c295460
 	digest2, err := setupImageWithTag(c, "tag2")
1c9a5d7b
 	//error setting up image
 	c.Assert(err, checker.IsNil)
a2b0c977
 	imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
dc944ea7
 	c.Logf("imageReference2 = %s", imageReference2)
a2b0c977
 
 	// pull image1 by digest
5c295460
 	dockerCmd(c, "pull", imageReference1)
a2b0c977
 
 	// pull image2 by digest
5c295460
 	dockerCmd(c, "pull", imageReference2)
a2b0c977
 
 	// list images
5c295460
 	out, _ = dockerCmd(c, "images", "--digests")
a2b0c977
 
 	// make sure repo shown, tag=<none>, digest = $digest1
1c9a5d7b
 	c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
a2b0c977
 
 	// make sure repo shown, tag=<none>, digest = $digest2
de52a3bc
 	re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
1c9a5d7b
 	c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
a2b0c977
 
 	// pull tag1
5c295460
 	dockerCmd(c, "pull", repoName+":tag1")
a2b0c977
 
 	// list images
5c295460
 	out, _ = dockerCmd(c, "images", "--digests")
a2b0c977
 
 	// make sure image 1 has repo, tag, <none> AND repo, <none>, digest
79eada38
 	reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*tag1\s*` + digest1.String() + `\s`)
1c9a5d7b
 	c.Assert(reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
a2b0c977
 	// make sure image 2 has repo, <none>, digest
1c9a5d7b
 	c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
a2b0c977
 
 	// pull tag 2
5c295460
 	dockerCmd(c, "pull", repoName+":tag2")
a2b0c977
 
 	// list images
5c295460
 	out, _ = dockerCmd(c, "images", "--digests")
a2b0c977
 
 	// make sure image 1 has repo, tag, digest
79eada38
 	c.Assert(reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
a2b0c977
 
 	// make sure image 2 has repo, tag, digest
79eada38
 	reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*tag2\s*` + digest2.String() + `\s`)
1c9a5d7b
 	c.Assert(reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
a2b0c977
 
 	// list images
5c295460
 	out, _ = dockerCmd(c, "images", "--digests")
a2b0c977
 
 	// make sure image 1 has repo, tag, digest
79eada38
 	c.Assert(reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
a2b0c977
 	// make sure image 2 has repo, tag, digest
79eada38
 	c.Assert(reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
a2b0c977
 	// make sure busybox has tag, but not digest
 	busyboxRe := regexp.MustCompile(`\s*busybox\s*latest\s*<none>\s`)
1c9a5d7b
 	c.Assert(busyboxRe.MatchString(out), checker.True, check.Commentf("expected %q: %s", busyboxRe.String(), out))
a2b0c977
 }
 
8906f830
 func (s *DockerRegistrySuite) TestListDanglingImagesWithDigests(c *check.C) {
 	// setup image1
 	digest1, err := setupImageWithTag(c, "dangle1")
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
 	imageReference1 := fmt.Sprintf("%s@%s", repoName, digest1)
 	c.Logf("imageReference1 = %s", imageReference1)
 
 	// pull image1 by digest
 	dockerCmd(c, "pull", imageReference1)
 
 	// list images
 	out, _ := dockerCmd(c, "images", "--digests")
 
 	// make sure repo shown, tag=<none>, digest = $digest1
 	re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1.String() + `\s`)
 	c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
 	// setup image2
 	digest2, err := setupImageWithTag(c, "dangle2")
 	//error setting up image
 	c.Assert(err, checker.IsNil)
 	imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
 	c.Logf("imageReference2 = %s", imageReference2)
 
 	// pull image1 by digest
 	dockerCmd(c, "pull", imageReference1)
 
 	// pull image2 by digest
 	dockerCmd(c, "pull", imageReference2)
 
 	// list images
a07be9be
 	out, _ = dockerCmd(c, "images", "--digests", "--filter=dangling=true")
8906f830
 
 	// make sure repo shown, tag=<none>, digest = $digest1
 	c.Assert(re1.MatchString(out), checker.True, check.Commentf("expected %q: %s", re1.String(), out))
 
 	// make sure repo shown, tag=<none>, digest = $digest2
 	re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2.String() + `\s`)
 	c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
 
 	// pull dangle1 tag
 	dockerCmd(c, "pull", repoName+":dangle1")
 
 	// list images
a07be9be
 	out, _ = dockerCmd(c, "images", "--digests", "--filter=dangling=true")
8906f830
 
 	// make sure image 1 has repo, tag, <none> AND repo, <none>, digest
 	reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*dangle1\s*` + digest1.String() + `\s`)
 	c.Assert(reWithDigest1.MatchString(out), checker.False, check.Commentf("unexpected %q: %s", reWithDigest1.String(), out))
 	// make sure image 2 has repo, <none>, digest
 	c.Assert(re2.MatchString(out), checker.True, check.Commentf("expected %q: %s", re2.String(), out))
 
 	// pull dangle2 tag
 	dockerCmd(c, "pull", repoName+":dangle2")
 
 	// list images, show tagged images
 	out, _ = dockerCmd(c, "images", "--digests")
 
 	// make sure image 1 has repo, tag, digest
 	c.Assert(reWithDigest1.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest1.String(), out))
 
 	// make sure image 2 has repo, tag, digest
 	reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*dangle2\s*` + digest2.String() + `\s`)
 	c.Assert(reWithDigest2.MatchString(out), checker.True, check.Commentf("expected %q: %s", reWithDigest2.String(), out))
 
 	// list images, no longer dangling, should not match
a07be9be
 	out, _ = dockerCmd(c, "images", "--digests", "--filter=dangling=true")
8906f830
 
 	// make sure image 1 has repo, tag, digest
 	c.Assert(reWithDigest1.MatchString(out), checker.False, check.Commentf("unexpected %q: %s", reWithDigest1.String(), out))
 	// make sure image 2 has repo, tag, digest
 	c.Assert(reWithDigest2.MatchString(out), checker.False, check.Commentf("unexpected %q: %s", reWithDigest2.String(), out))
 }
 
f664f6e4
 func (s *DockerRegistrySuite) TestInspectImageWithDigests(c *check.C) {
 	digest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, check.IsNil, check.Commentf("error setting up image"))
f664f6e4
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
 	dockerCmd(c, "pull", imageReference)
 
 	out, _ := dockerCmd(c, "inspect", imageReference)
 
 	var imageJSON []types.ImageInspect
1c9a5d7b
 	err = json.Unmarshal([]byte(out), &imageJSON)
 	c.Assert(err, checker.IsNil)
 	c.Assert(imageJSON, checker.HasLen, 1)
 	c.Assert(imageJSON[0].RepoDigests, checker.HasLen, 1)
 	c.Assert(stringutils.InSlice(imageJSON[0].RepoDigests, imageReference), checker.Equals, true)
f664f6e4
 }
 
c1af0ac0
 func (s *DockerRegistrySuite) TestPsListContainersFilterAncestorImageByDigest(c *check.C) {
 	digest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
c1af0ac0
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
 	dockerCmd(c, "pull", imageReference)
 
c1be45fa
 	// build an image from it
c1af0ac0
 	imageName1 := "images_ps_filter_test"
 	_, err = buildImage(imageName1, fmt.Sprintf(
 		`FROM %s
 		 LABEL match me 1`, imageReference), true)
1c9a5d7b
 	c.Assert(err, checker.IsNil)
c1af0ac0
 
 	// run a container based on that
e4468913
 	dockerCmd(c, "run", "--name=test1", imageReference, "echo", "hello")
 	expectedID, err := getIDByName("test1")
 	c.Assert(err, check.IsNil)
c1af0ac0
 
 	// run a container based on the a descendant of that too
e4468913
 	dockerCmd(c, "run", "--name=test2", imageName1, "echo", "hello")
 	expectedID1, err := getIDByName("test2")
 	c.Assert(err, check.IsNil)
c1af0ac0
 
 	expectedIDs := []string{expectedID, expectedID1}
 
 	// Invalid imageReference
e4468913
 	out, _ := dockerCmd(c, "ps", "-a", "-q", "--no-trunc", fmt.Sprintf("--filter=ancestor=busybox@%s", digest))
1c9a5d7b
 	// Filter container for ancestor filter should be empty
 	c.Assert(strings.TrimSpace(out), checker.Equals, "")
c1af0ac0
 
 	// Valid imageReference
 	out, _ = dockerCmd(c, "ps", "-a", "-q", "--no-trunc", "--filter=ancestor="+imageReference)
 	checkPsAncestorFilterOutput(c, out, imageReference, expectedIDs)
 }
 
f696b107
 func (s *DockerRegistrySuite) TestDeleteImageByIDOnlyPulledByDigest(c *check.C) {
5c295460
 	pushDigest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
a2b0c977
 
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
5c295460
 	dockerCmd(c, "pull", imageReference)
a2b0c977
 	// just in case...
 
5cff374b
 	dockerCmd(c, "tag", imageReference, repoName+":sometag")
 
62a856e9
 	imageID := inspectField(c, imageReference, "Id")
a2b0c977
 
5c295460
 	dockerCmd(c, "rmi", imageID)
5cff374b
 
 	_, err = inspectFieldWithError(imageID, "Id")
 	c.Assert(err, checker.NotNil, check.Commentf("image should have been deleted"))
a2b0c977
 }
de52a3bc
 
2f048f73
 func (s *DockerRegistrySuite) TestDeleteImageWithDigestAndTag(c *check.C) {
 	pushDigest, err := setupImage(c)
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
 
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
 	dockerCmd(c, "pull", imageReference)
 
62a856e9
 	imageID := inspectField(c, imageReference, "Id")
2f048f73
 
 	repoTag := repoName + ":sometag"
 	repoTag2 := repoName + ":othertag"
 	dockerCmd(c, "tag", imageReference, repoTag)
 	dockerCmd(c, "tag", imageReference, repoTag2)
 
 	dockerCmd(c, "rmi", repoTag2)
 
 	// rmi should have deleted only repoTag2, because there's another tag
62a856e9
 	inspectField(c, repoTag, "Id")
2f048f73
 
 	dockerCmd(c, "rmi", repoTag)
 
 	// rmi should have deleted the tag, the digest reference, and the image itself
62a856e9
 	_, err = inspectFieldWithError(imageID, "Id")
2f048f73
 	c.Assert(err, checker.NotNil, check.Commentf("image should have been deleted"))
 }
 
5cff374b
 func (s *DockerRegistrySuite) TestDeleteImageWithDigestAndMultiRepoTag(c *check.C) {
 	pushDigest, err := setupImage(c)
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
 
 	repo2 := fmt.Sprintf("%s/%s", repoName, "repo2")
 
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
 	dockerCmd(c, "pull", imageReference)
 
 	imageID := inspectField(c, imageReference, "Id")
 
 	repoTag := repoName + ":sometag"
 	repoTag2 := repo2 + ":othertag"
 	dockerCmd(c, "tag", imageReference, repoTag)
 	dockerCmd(c, "tag", imageReference, repoTag2)
 
 	dockerCmd(c, "rmi", repoTag)
 
 	// rmi should have deleted repoTag and image reference, but left repoTag2
 	inspectField(c, repoTag2, "Id")
 	_, err = inspectFieldWithError(imageReference, "Id")
 	c.Assert(err, checker.NotNil, check.Commentf("image digest reference should have been removed"))
 
 	_, err = inspectFieldWithError(repoTag, "Id")
 	c.Assert(err, checker.NotNil, check.Commentf("image tag reference should have been removed"))
 
 	dockerCmd(c, "rmi", repoTag2)
 
 	// rmi should have deleted the tag, the digest reference, and the image itself
 	_, err = inspectFieldWithError(imageID, "Id")
 	c.Assert(err, checker.NotNil, check.Commentf("image should have been deleted"))
 }
 
de52a3bc
 // TestPullFailsWithAlteredManifest tests that a `docker pull` fails when
 // we have modified a manifest blob and its digest cannot be verified.
1fa2e311
 // This is the schema2 version of the test.
de52a3bc
 func (s *DockerRegistrySuite) TestPullFailsWithAlteredManifest(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
de52a3bc
 	manifestDigest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
de52a3bc
 
 	// Load the target manifest blob.
 	manifestBlob := s.reg.readBlobContents(c, manifestDigest)
 
1fa2e311
 	var imgManifest schema2.Manifest
 	err = json.Unmarshal(manifestBlob, &imgManifest)
 	c.Assert(err, checker.IsNil, check.Commentf("unable to decode image manifest from blob"))
 
 	// Change a layer in the manifest.
 	imgManifest.Layers[0].Digest = digest.Digest("sha256:0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef")
 
 	// Move the existing data file aside, so that we can replace it with a
 	// malicious blob of data. NOTE: we defer the returned undo func.
 	undo := s.reg.tempMoveBlobData(c, manifestDigest)
 	defer undo()
 
 	alteredManifestBlob, err := json.MarshalIndent(imgManifest, "", "   ")
 	c.Assert(err, checker.IsNil, check.Commentf("unable to encode altered image manifest to JSON"))
 
 	s.reg.writeBlobContents(c, manifestDigest, alteredManifestBlob)
 
 	// Now try pulling that image by digest. We should get an error about
 	// digest verification for the manifest digest.
 
 	// Pull from the registry using the <name>@<digest> reference.
 	imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
 	out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
 	c.Assert(exitStatus, checker.Not(check.Equals), 0)
 
 	expectedErrorMsg := fmt.Sprintf("manifest verification failed for digest %s", manifestDigest)
 	c.Assert(out, checker.Contains, expectedErrorMsg)
 }
 
 // TestPullFailsWithAlteredManifest tests that a `docker pull` fails when
 // we have modified a manifest blob and its digest cannot be verified.
 // This is the schema1 version of the test.
 func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredManifest(c *check.C) {
 	testRequires(c, DaemonIsLinux)
 	manifestDigest, err := setupImage(c)
 	c.Assert(err, checker.IsNil, check.Commentf("error setting up image"))
 
 	// Load the target manifest blob.
 	manifestBlob := s.reg.readBlobContents(c, manifestDigest)
 
257c5925
 	var imgManifest schema1.Manifest
1c9a5d7b
 	err = json.Unmarshal(manifestBlob, &imgManifest)
 	c.Assert(err, checker.IsNil, check.Commentf("unable to decode image manifest from blob"))
de52a3bc
 
257c5925
 	// Change a layer in the manifest.
 	imgManifest.FSLayers[0] = schema1.FSLayer{
de52a3bc
 		BlobSum: digest.Digest("sha256:0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef"),
257c5925
 	}
de52a3bc
 
 	// Move the existing data file aside, so that we can replace it with a
 	// malicious blob of data. NOTE: we defer the returned undo func.
 	undo := s.reg.tempMoveBlobData(c, manifestDigest)
 	defer undo()
 
257c5925
 	alteredManifestBlob, err := json.MarshalIndent(imgManifest, "", "   ")
1c9a5d7b
 	c.Assert(err, checker.IsNil, check.Commentf("unable to encode altered image manifest to JSON"))
de52a3bc
 
 	s.reg.writeBlobContents(c, manifestDigest, alteredManifestBlob)
 
 	// Now try pulling that image by digest. We should get an error about
 	// digest verification for the manifest digest.
 
 	// Pull from the registry using the <name>@<digest> reference.
 	imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
 	out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
1c9a5d7b
 	c.Assert(exitStatus, checker.Not(check.Equals), 0)
de52a3bc
 
 	expectedErrorMsg := fmt.Sprintf("image verification failed for digest %s", manifestDigest)
1c9a5d7b
 	c.Assert(out, checker.Contains, expectedErrorMsg)
de52a3bc
 }
 
 // TestPullFailsWithAlteredLayer tests that a `docker pull` fails when
 // we have modified a layer blob and its digest cannot be verified.
1fa2e311
 // This is the schema2 version of the test.
de52a3bc
 func (s *DockerRegistrySuite) TestPullFailsWithAlteredLayer(c *check.C) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
de52a3bc
 	manifestDigest, err := setupImage(c)
1c9a5d7b
 	c.Assert(err, checker.IsNil)
de52a3bc
 
 	// Load the target manifest blob.
 	manifestBlob := s.reg.readBlobContents(c, manifestDigest)
 
1fa2e311
 	var imgManifest schema2.Manifest
 	err = json.Unmarshal(manifestBlob, &imgManifest)
 	c.Assert(err, checker.IsNil)
 
 	// Next, get the digest of one of the layers from the manifest.
 	targetLayerDigest := imgManifest.Layers[0].Digest
 
 	// Move the existing data file aside, so that we can replace it with a
 	// malicious blob of data. NOTE: we defer the returned undo func.
 	undo := s.reg.tempMoveBlobData(c, targetLayerDigest)
 	defer undo()
 
 	// Now make a fake data blob in this directory.
 	s.reg.writeBlobContents(c, targetLayerDigest, []byte("This is not the data you are looking for."))
 
 	// Now try pulling that image by digest. We should get an error about
 	// digest verification for the target layer digest.
 
 	// Remove distribution cache to force a re-pull of the blobs
 	if err := os.RemoveAll(filepath.Join(dockerBasePath, "image", s.d.storageDriver, "distribution")); err != nil {
 		c.Fatalf("error clearing distribution cache: %v", err)
 	}
 
 	// Pull from the registry using the <name>@<digest> reference.
 	imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
 	out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
b5f51e52
 	c.Assert(exitStatus, checker.Not(check.Equals), 0, check.Commentf("expected a non-zero exit status"))
1fa2e311
 
 	expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
 	c.Assert(out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
 }
 
 // TestPullFailsWithAlteredLayer tests that a `docker pull` fails when
 // we have modified a layer blob and its digest cannot be verified.
 // This is the schema1 version of the test.
 func (s *DockerSchema1RegistrySuite) TestPullFailsWithAlteredLayer(c *check.C) {
 	testRequires(c, DaemonIsLinux)
 	manifestDigest, err := setupImage(c)
 	c.Assert(err, checker.IsNil)
 
 	// Load the target manifest blob.
 	manifestBlob := s.reg.readBlobContents(c, manifestDigest)
 
257c5925
 	var imgManifest schema1.Manifest
1c9a5d7b
 	err = json.Unmarshal(manifestBlob, &imgManifest)
 	c.Assert(err, checker.IsNil)
de52a3bc
 
 	// Next, get the digest of one of the layers from the manifest.
 	targetLayerDigest := imgManifest.FSLayers[0].BlobSum
 
 	// Move the existing data file aside, so that we can replace it with a
 	// malicious blob of data. NOTE: we defer the returned undo func.
 	undo := s.reg.tempMoveBlobData(c, targetLayerDigest)
 	defer undo()
 
 	// Now make a fake data blob in this directory.
 	s.reg.writeBlobContents(c, targetLayerDigest, []byte("This is not the data you are looking for."))
 
 	// Now try pulling that image by digest. We should get an error about
 	// digest verification for the target layer digest.
 
4352da78
 	// Remove distribution cache to force a re-pull of the blobs
 	if err := os.RemoveAll(filepath.Join(dockerBasePath, "image", s.d.storageDriver, "distribution")); err != nil {
 		c.Fatalf("error clearing distribution cache: %v", err)
 	}
 
de52a3bc
 	// Pull from the registry using the <name>@<digest> reference.
 	imageReference := fmt.Sprintf("%s@%s", repoName, manifestDigest)
 	out, exitStatus, _ := dockerCmdWithError("pull", imageReference)
b5f51e52
 	c.Assert(exitStatus, checker.Not(check.Equals), 0, check.Commentf("expected a non-zero exit status"))
de52a3bc
 
 	expectedErrorMsg := fmt.Sprintf("filesystem layer verification failed for digest %s", targetLayerDigest)
1c9a5d7b
 	c.Assert(out, checker.Contains, expectedErrorMsg, check.Commentf("expected error message in output: %s", out))
de52a3bc
 }