graph/pull.go
6856a6b1
 package graph
 
 import (
 	"fmt"
 	"io"
7c88e8f1
 	"io/ioutil"
6856a6b1
 	"net"
 	"net/url"
7c88e8f1
 	"os"
6856a6b1
 	"strings"
 	"time"
 
ee7dd44c
 	log "github.com/Sirupsen/logrus"
514be385
 	"github.com/docker/distribution/digest"
6856a6b1
 	"github.com/docker/docker/engine"
 	"github.com/docker/docker/image"
7a9c944b
 	"github.com/docker/docker/pkg/common"
12b278d3
 	"github.com/docker/docker/pkg/progressreader"
6856a6b1
 	"github.com/docker/docker/registry"
 	"github.com/docker/docker/utils"
 )
 
 func (s *TagStore) CmdPull(job *engine.Job) engine.Status {
 	if n := len(job.Args); n != 1 && n != 2 {
a2b0c977
 		return job.Errorf("Usage: %s IMAGE [TAG|DIGEST]", job.Name)
6856a6b1
 	}
1c62e0ae
 
6856a6b1
 	var (
 		localName   = job.Args[0]
 		tag         string
 		sf          = utils.NewStreamFormatter(job.GetenvBool("json"))
 		authConfig  = &registry.AuthConfig{}
 		metaHeaders map[string][]string
 	)
1c62e0ae
 
568f86eb
 	// Resolve the Repository name from fqn to RepositoryInfo
 	repoInfo, err := registry.ResolveRepositoryInfo(job, localName)
 	if err != nil {
 		return job.Error(err)
 	}
 
6856a6b1
 	if len(job.Args) > 1 {
 		tag = job.Args[1]
 	}
 
 	job.GetenvJson("authConfig", authConfig)
 	job.GetenvJson("metaHeaders", &metaHeaders)
 
a2b0c977
 	c, err := s.poolAdd("pull", utils.ImageReference(repoInfo.LocalName, tag))
6856a6b1
 	if err != nil {
 		if c != nil {
 			// Another pull of the same repository is already taking place; just wait for it to finish
568f86eb
 			job.Stdout.Write(sf.FormatStatus("", "Repository %s already being pulled by another client. Waiting.", repoInfo.LocalName))
6856a6b1
 			<-c
 			return engine.StatusOK
 		}
 		return job.Error(err)
 	}
a2b0c977
 	defer s.poolRemove("pull", utils.ImageReference(repoInfo.LocalName, tag))
6856a6b1
 
213e3d11
 	log.Debugf("pulling image from host %q with remote name %q", repoInfo.Index.Name, repoInfo.RemoteName)
568f86eb
 	endpoint, err := repoInfo.GetEndpoint()
6856a6b1
 	if err != nil {
 		return job.Error(err)
 	}
 
752dd707
 	r, err := registry.NewSession(authConfig, registry.HTTPRequestFactory(metaHeaders), endpoint, true)
6856a6b1
 	if err != nil {
 		return job.Error(err)
 	}
 
568f86eb
 	logName := repoInfo.LocalName
ef741525
 	if tag != "" {
a2b0c977
 		logName = utils.ImageReference(logName, tag)
ef741525
 	}
 
770e9b6b
 	if len(repoInfo.Index.Mirrors) == 0 && (repoInfo.Index.Official || endpoint.Version == registry.APIVersion2) {
8d1a0086
 		if repoInfo.Official {
 			j := job.Eng.Job("trust_update_base")
 			if err = j.Run(); err != nil {
 				log.Errorf("error updating trust base graph: %s", err)
 			}
3be4551a
 		}
 
750b41ce
 		log.Debugf("pulling v2 repository with local name %q", repoInfo.LocalName)
 		if err := s.pullV2Repository(job.Eng, r, job.Stdout, repoInfo, tag, sf, job.GetenvBool("parallel")); err == nil {
 			if err = job.Eng.Job("log", "pull", logName, "").Run(); err != nil {
 				log.Errorf("Error logging event 'pull' for %s: %s", logName, err)
ef741525
 			}
750b41ce
 			return engine.StatusOK
c8a06069
 		} else if err != registry.ErrDoesNotExist && err != ErrV2RegistryUnavailable {
750b41ce
 			log.Errorf("Error from V2 registry: %s", err)
3be4551a
 		}
213e3d11
 
 		log.Debug("image does not exist on v2 registry, falling back to v1")
3be4551a
 	}
 
213e3d11
 	log.Debugf("pulling v1 repository with local name %q", repoInfo.LocalName)
568f86eb
 	if err = s.pullRepository(r, job.Stdout, repoInfo, tag, sf, job.GetenvBool("parallel")); err != nil {
6856a6b1
 		return job.Error(err)
 	}
 
ef741525
 	if err = job.Eng.Job("log", "pull", logName, "").Run(); err != nil {
 		log.Errorf("Error logging event 'pull' for %s: %s", logName, err)
 	}
 
6856a6b1
 	return engine.StatusOK
 }
 
568f86eb
 func (s *TagStore) pullRepository(r *registry.Session, out io.Writer, repoInfo *registry.RepositoryInfo, askedTag string, sf *utils.StreamFormatter, parallel bool) error {
 	out.Write(sf.FormatStatus("", "Pulling repository %s", repoInfo.CanonicalName))
6856a6b1
 
568f86eb
 	repoData, err := r.GetRepositoryData(repoInfo.RemoteName)
6856a6b1
 	if err != nil {
 		if strings.Contains(err.Error(), "HTTP code: 404") {
a2b0c977
 			return fmt.Errorf("Error: image %s not found", utils.ImageReference(repoInfo.RemoteName, askedTag))
6856a6b1
 		}
114838cb
 		// Unexpected HTTP error
 		return err
6856a6b1
 	}
 
a02f67be
 	log.Debugf("Retrieving the tag list")
568f86eb
 	tagsList, err := r.GetRemoteTags(repoData.Endpoints, repoInfo.RemoteName, repoData.Tokens)
6856a6b1
 	if err != nil {
213e3d11
 		log.Errorf("unable to get remote tags: %s", err)
6856a6b1
 		return err
 	}
 
 	for tag, id := range tagsList {
 		repoData.ImgList[id] = &registry.ImgData{
 			ID:       id,
 			Tag:      tag,
 			Checksum: "",
 		}
 	}
 
a02f67be
 	log.Debugf("Registering tags")
6856a6b1
 	// If no tag has been specified, pull them all
 	if askedTag == "" {
 		for tag, id := range tagsList {
 			repoData.ImgList[id].Tag = tag
 		}
 	} else {
 		// Otherwise, check that the tag exists and use only that one
 		id, exists := tagsList[askedTag]
 		if !exists {
568f86eb
 			return fmt.Errorf("Tag %s not found in repository %s", askedTag, repoInfo.CanonicalName)
6856a6b1
 		}
 		repoData.ImgList[id].Tag = askedTag
 	}
 
 	errors := make(chan error)
ecff6303
 
 	layers_downloaded := false
6856a6b1
 	for _, image := range repoData.ImgList {
 		downloadImage := func(img *registry.ImgData) {
 			if askedTag != "" && img.Tag != askedTag {
 				if parallel {
 					errors <- nil
 				}
 				return
 			}
 
 			if img.Tag == "" {
a02f67be
 				log.Debugf("Image (id: %s) present in this repository but untagged, skipping", img.ID)
6856a6b1
 				if parallel {
 					errors <- nil
 				}
 				return
 			}
 
 			// ensure no two downloads of the same image happen at the same time
 			if c, err := s.poolAdd("pull", "img:"+img.ID); err != nil {
 				if c != nil {
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Layer already being pulled by another client. Waiting.", nil))
6856a6b1
 					<-c
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Download complete", nil))
6856a6b1
 				} else {
a02f67be
 					log.Debugf("Image (id: %s) pull is already running, skipping: %v", img.ID, err)
6856a6b1
 				}
 				if parallel {
 					errors <- nil
 				}
 				return
 			}
 			defer s.poolRemove("pull", "img:"+img.ID)
 
7a9c944b
 			out.Write(sf.FormatProgress(common.TruncateID(img.ID), fmt.Sprintf("Pulling image (%s) from %s", img.Tag, repoInfo.CanonicalName), nil))
6856a6b1
 			success := false
ecff6303
 			var lastErr, err error
 			var is_downloaded bool
568f86eb
 			for _, ep := range repoInfo.Index.Mirrors {
7a9c944b
 				out.Write(sf.FormatProgress(common.TruncateID(img.ID), fmt.Sprintf("Pulling image (%s) from %s, mirror: %s", img.Tag, repoInfo.CanonicalName, ep), nil))
568f86eb
 				if is_downloaded, err = s.pullImage(r, out, img.ID, ep, repoData.Tokens, sf); err != nil {
 					// Don't report errors when pulling from mirrors.
 					log.Debugf("Error pulling image (%s) from %s, mirror: %s, %s", img.Tag, repoInfo.CanonicalName, ep, err)
 					continue
69a75c67
 				}
568f86eb
 				layers_downloaded = layers_downloaded || is_downloaded
 				success = true
 				break
69a75c67
 			}
 			if !success {
 				for _, ep := range repoData.Endpoints {
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(img.ID), fmt.Sprintf("Pulling image (%s) from %s, endpoint: %s", img.Tag, repoInfo.CanonicalName, ep), nil))
ecff6303
 					if is_downloaded, err = s.pullImage(r, out, img.ID, ep, repoData.Tokens, sf); err != nil {
69a75c67
 						// It's not ideal that only the last error is returned, it would be better to concatenate the errors.
 						// As the error is also given to the output stream the user will see the error.
 						lastErr = err
7a9c944b
 						out.Write(sf.FormatProgress(common.TruncateID(img.ID), fmt.Sprintf("Error pulling image (%s) from %s, endpoint: %s, %s", img.Tag, repoInfo.CanonicalName, ep, err), nil))
69a75c67
 						continue
 					}
ecff6303
 					layers_downloaded = layers_downloaded || is_downloaded
69a75c67
 					success = true
 					break
6856a6b1
 				}
 			}
 			if !success {
568f86eb
 				err := fmt.Errorf("Error pulling image (%s) from %s, %v", img.Tag, repoInfo.CanonicalName, lastErr)
7a9c944b
 				out.Write(sf.FormatProgress(common.TruncateID(img.ID), err.Error(), nil))
6856a6b1
 				if parallel {
 					errors <- err
 					return
 				}
 			}
7a9c944b
 			out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Download complete", nil))
6856a6b1
 
 			if parallel {
 				errors <- nil
 			}
 		}
 
 		if parallel {
 			go downloadImage(image)
 		} else {
 			downloadImage(image)
 		}
 	}
 	if parallel {
 		var lastError error
 		for i := 0; i < len(repoData.ImgList); i++ {
 			if err := <-errors; err != nil {
 				lastError = err
 			}
 		}
 		if lastError != nil {
 			return lastError
 		}
 
 	}
 	for tag, id := range tagsList {
72a9000f
 		if askedTag != "" && tag != askedTag {
6856a6b1
 			continue
 		}
568f86eb
 		if err := s.Set(repoInfo.LocalName, tag, id, true); err != nil {
6856a6b1
 			return err
 		}
 	}
 
568f86eb
 	requestedTag := repoInfo.CanonicalName
ecff6303
 	if len(askedTag) > 0 {
a2b0c977
 		requestedTag = utils.ImageReference(repoInfo.CanonicalName, askedTag)
ecff6303
 	}
 	WriteStatus(requestedTag, out, sf, layers_downloaded)
6856a6b1
 	return nil
 }
 
ecff6303
 func (s *TagStore) pullImage(r *registry.Session, out io.Writer, imgID, endpoint string, token []string, sf *utils.StreamFormatter) (bool, error) {
6856a6b1
 	history, err := r.GetRemoteHistory(imgID, endpoint, token)
 	if err != nil {
ecff6303
 		return false, err
6856a6b1
 	}
7a9c944b
 	out.Write(sf.FormatProgress(common.TruncateID(imgID), "Pulling dependent layers", nil))
6856a6b1
 	// FIXME: Try to stream the images?
 	// FIXME: Launch the getRemoteImage() in goroutines
 
ecff6303
 	layers_downloaded := false
6856a6b1
 	for i := len(history) - 1; i >= 0; i-- {
 		id := history[i]
 
 		// ensure no two downloads of the same layer happen at the same time
 		if c, err := s.poolAdd("pull", "layer:"+id); err != nil {
a02f67be
 			log.Debugf("Image (id: %s) pull is already running, skipping: %v", id, err)
6856a6b1
 			<-c
 		}
 		defer s.poolRemove("pull", "layer:"+id)
 
 		if !s.graph.Exists(id) {
7a9c944b
 			out.Write(sf.FormatProgress(common.TruncateID(id), "Pulling metadata", nil))
6856a6b1
 			var (
 				imgJSON []byte
 				imgSize int
 				err     error
 				img     *image.Image
 			)
 			retries := 5
 			for j := 1; j <= retries; j++ {
 				imgJSON, imgSize, err = r.GetRemoteImageJSON(id, endpoint, token)
 				if err != nil && j == retries {
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(id), "Error pulling dependent layers", nil))
ecff6303
 					return layers_downloaded, err
6856a6b1
 				} else if err != nil {
 					time.Sleep(time.Duration(j) * 500 * time.Millisecond)
 					continue
 				}
 				img, err = image.NewImgJSON(imgJSON)
ecff6303
 				layers_downloaded = true
6856a6b1
 				if err != nil && j == retries {
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(id), "Error pulling dependent layers", nil))
ecff6303
 					return layers_downloaded, fmt.Errorf("Failed to parse json: %s", err)
6856a6b1
 				} else if err != nil {
 					time.Sleep(time.Duration(j) * 500 * time.Millisecond)
 					continue
 				} else {
 					break
 				}
 			}
 
 			for j := 1; j <= retries; j++ {
 				// Get the layer
 				status := "Pulling fs layer"
 				if j > 1 {
 					status = fmt.Sprintf("Pulling fs layer [retries: %d]", j)
 				}
7a9c944b
 				out.Write(sf.FormatProgress(common.TruncateID(id), status, nil))
6856a6b1
 				layer, err := r.GetRemoteImageLayer(img.ID, endpoint, token, int64(imgSize))
 				if uerr, ok := err.(*url.Error); ok {
 					err = uerr.Err
 				}
 				if terr, ok := err.(net.Error); ok && terr.Timeout() && j < retries {
 					time.Sleep(time.Duration(j) * 500 * time.Millisecond)
 					continue
 				} else if err != nil {
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(id), "Error pulling dependent layers", nil))
ecff6303
 					return layers_downloaded, err
6856a6b1
 				}
ecff6303
 				layers_downloaded = true
6856a6b1
 				defer layer.Close()
 
26184de8
 				err = s.graph.Register(img,
12b278d3
 					progressreader.New(progressreader.Config{
 						In:        layer,
 						Out:       out,
 						Formatter: sf,
 						Size:      imgSize,
 						NewLines:  false,
 						ID:        common.TruncateID(id),
 						Action:    "Downloading",
 					}))
6856a6b1
 				if terr, ok := err.(net.Error); ok && terr.Timeout() && j < retries {
 					time.Sleep(time.Duration(j) * 500 * time.Millisecond)
 					continue
 				} else if err != nil {
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(id), "Error downloading dependent layers", nil))
ecff6303
 					return layers_downloaded, err
6856a6b1
 				} else {
 					break
 				}
 			}
 		}
7a9c944b
 		out.Write(sf.FormatProgress(common.TruncateID(id), "Download complete", nil))
ecff6303
 	}
 	return layers_downloaded, nil
 }
6856a6b1
 
ecff6303
 func WriteStatus(requestedTag string, out io.Writer, sf *utils.StreamFormatter, layers_downloaded bool) {
 	if layers_downloaded {
 		out.Write(sf.FormatStatus("", "Status: Downloaded newer image for %s", requestedTag))
 	} else {
 		out.Write(sf.FormatStatus("", "Status: Image is up to date for %s", requestedTag))
6856a6b1
 	}
 }
7c88e8f1
 
 // downloadInfo is used to pass information from download to extractor
 type downloadInfo struct {
 	imgJSON    []byte
 	img        *image.Image
514be385
 	digest     digest.Digest
7c88e8f1
 	tmpFile    *os.File
 	length     int64
 	downloaded bool
 	err        chan error
 }
 
750b41ce
 func (s *TagStore) pullV2Repository(eng *engine.Engine, r *registry.Session, out io.Writer, repoInfo *registry.RepositoryInfo, tag string, sf *utils.StreamFormatter, parallel bool) error {
9c6f8e14
 	endpoint, err := r.V2RegistryEndpoint(repoInfo.Index)
 	if err != nil {
c8a06069
 		if repoInfo.Index.Official {
 			log.Debugf("Unable to pull from V2 registry, falling back to v1: %s", err)
 			return ErrV2RegistryUnavailable
 		}
9c6f8e14
 		return fmt.Errorf("error getting registry endpoint: %s", err)
 	}
 	auth, err := r.GetV2Authorization(endpoint, repoInfo.RemoteName, true)
750b41ce
 	if err != nil {
 		return fmt.Errorf("error getting authorization: %s", err)
 	}
456f4936
 	var layersDownloaded bool
7c88e8f1
 	if tag == "" {
568f86eb
 		log.Debugf("Pulling tag list from V2 registry for %s", repoInfo.CanonicalName)
9c6f8e14
 		tags, err := r.GetV2RemoteTags(endpoint, repoInfo.RemoteName, auth)
7c88e8f1
 		if err != nil {
 			return err
 		}
8bfdad9a
 		if len(tags) == 0 {
 			return registry.ErrDoesNotExist
 		}
7c88e8f1
 		for _, t := range tags {
9c6f8e14
 			if downloaded, err := s.pullV2Tag(eng, r, out, endpoint, repoInfo, t, sf, parallel, auth); err != nil {
7c88e8f1
 				return err
456f4936
 			} else if downloaded {
 				layersDownloaded = true
7c88e8f1
 			}
 		}
 	} else {
9c6f8e14
 		if downloaded, err := s.pullV2Tag(eng, r, out, endpoint, repoInfo, tag, sf, parallel, auth); err != nil {
7c88e8f1
 			return err
456f4936
 		} else if downloaded {
 			layersDownloaded = true
7c88e8f1
 		}
 	}
 
568f86eb
 	requestedTag := repoInfo.CanonicalName
456f4936
 	if len(tag) > 0 {
a2b0c977
 		requestedTag = utils.ImageReference(repoInfo.CanonicalName, tag)
456f4936
 	}
 	WriteStatus(requestedTag, out, sf, layersDownloaded)
7c88e8f1
 	return nil
 }
 
9c6f8e14
 func (s *TagStore) pullV2Tag(eng *engine.Engine, r *registry.Session, out io.Writer, endpoint *registry.Endpoint, repoInfo *registry.RepositoryInfo, tag string, sf *utils.StreamFormatter, parallel bool, auth *registry.RequestAuthorization) (bool, error) {
7c88e8f1
 	log.Debugf("Pulling tag from V2 registry: %q", tag)
9ececa14
 
514be385
 	manifestBytes, manifestDigest, err := r.GetV2ImageManifest(endpoint, repoInfo.RemoteName, tag, auth)
7c88e8f1
 	if err != nil {
456f4936
 		return false, err
7c88e8f1
 	}
 
9ececa14
 	// loadManifest ensures that the manifest payload has the expected digest
 	// if the tag is a digest reference.
 	manifest, verified, err := s.loadManifest(eng, manifestBytes, manifestDigest, tag)
7c88e8f1
 	if err != nil {
456f4936
 		return false, fmt.Errorf("error verifying manifest: %s", err)
7c88e8f1
 	}
 
25945a40
 	if err := checkValidManifest(manifest); err != nil {
 		return false, err
7c88e8f1
 	}
 
 	if verified {
a2b0c977
 		log.Printf("Image manifest for %s has been verified", utils.ImageReference(repoInfo.CanonicalName, tag))
7c88e8f1
 	}
6088df20
 	out.Write(sf.FormatStatus(tag, "Pulling from %s", repoInfo.CanonicalName))
18200030
 
15d5c7f1
 	downloads := make([]downloadInfo, len(manifest.FSLayers))
7c88e8f1
 
15d5c7f1
 	for i := len(manifest.FSLayers) - 1; i >= 0; i-- {
7c88e8f1
 		var (
15d5c7f1
 			sumStr  = manifest.FSLayers[i].BlobSum
 			imgJSON = []byte(manifest.History[i].V1Compatibility)
7c88e8f1
 		)
 
 		img, err := image.NewImgJSON(imgJSON)
 		if err != nil {
456f4936
 			return false, fmt.Errorf("failed to parse json: %s", err)
7c88e8f1
 		}
 		downloads[i].img = img
 
 		// Check if exists
 		if s.graph.Exists(img.ID) {
 			log.Debugf("Image already exists: %s", img.ID)
 			continue
 		}
 
514be385
 		dgst, err := digest.ParseDigest(sumStr)
 		if err != nil {
 			return false, err
7c88e8f1
 		}
514be385
 		downloads[i].digest = dgst
 
7a9c944b
 		out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Pulling fs layer", nil))
7c88e8f1
 
 		downloadFunc := func(di *downloadInfo) error {
7d21ea66
 			log.Debugf("pulling blob %q to V1 img %s", sumStr, img.ID)
7c88e8f1
 
 			if c, err := s.poolAdd("pull", "img:"+img.ID); err != nil {
 				if c != nil {
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Layer already being pulled by another client. Waiting.", nil))
7c88e8f1
 					<-c
7a9c944b
 					out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Download complete", nil))
7c88e8f1
 				} else {
 					log.Debugf("Image (id: %s) pull is already running, skipping: %v", img.ID, err)
 				}
 			} else {
e8b8cf61
 				defer s.poolRemove("pull", "img:"+img.ID)
7c88e8f1
 				tmpFile, err := ioutil.TempFile("", "GetV2ImageBlob")
 				if err != nil {
 					return err
 				}
 
514be385
 				r, l, err := r.GetV2ImageBlobReader(endpoint, repoInfo.RemoteName, di.digest.Algorithm(), di.digest.Hex(), auth)
7c88e8f1
 				if err != nil {
 					return err
 				}
 				defer r.Close()
213e3d11
 
514be385
 				verifier, err := digest.NewDigestVerifier(di.digest)
213e3d11
 				if err != nil {
514be385
 					return err
213e3d11
 				}
 
12b278d3
 				if _, err := io.Copy(tmpFile, progressreader.New(progressreader.Config{
514be385
 					In:        ioutil.NopCloser(io.TeeReader(r, verifier)),
12b278d3
 					Out:       out,
 					Formatter: sf,
 					Size:      int(l),
 					NewLines:  false,
 					ID:        common.TruncateID(img.ID),
 					Action:    "Downloading",
 				})); err != nil {
6564e0ad
 					return fmt.Errorf("unable to copy v2 image blob data: %s", err)
 				}
213e3d11
 
7a9c944b
 				out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Verifying Checksum", nil))
213e3d11
 
514be385
 				if !verifier.Verified() {
 					log.Infof("Image verification failed: checksum mismatch for %q", di.digest.String())
6088df20
 					verified = false
213e3d11
 				}
7c88e8f1
 
7a9c944b
 				out.Write(sf.FormatProgress(common.TruncateID(img.ID), "Download complete", nil))
7c88e8f1
 
 				log.Debugf("Downloaded %s to tempfile %s", img.ID, tmpFile.Name())
 				di.tmpFile = tmpFile
 				di.length = l
 				di.downloaded = true
 			}
 			di.imgJSON = imgJSON
 
 			return nil
 		}
 
 		if parallel {
 			downloads[i].err = make(chan error)
 			go func(di *downloadInfo) {
 				di.err <- downloadFunc(di)
 			}(&downloads[i])
 		} else {
 			err := downloadFunc(&downloads[i])
 			if err != nil {
456f4936
 				return false, err
7c88e8f1
 			}
 		}
 	}
 
636037c3
 	var tagUpdated bool
7c88e8f1
 	for i := len(downloads) - 1; i >= 0; i-- {
 		d := &downloads[i]
 		if d.err != nil {
 			err := <-d.err
 			if err != nil {
456f4936
 				return false, err
7c88e8f1
 			}
 		}
 		if d.downloaded {
 			// if tmpFile is empty assume download and extracted elsewhere
 			defer os.Remove(d.tmpFile.Name())
 			defer d.tmpFile.Close()
 			d.tmpFile.Seek(0, 0)
 			if d.tmpFile != nil {
26184de8
 				err = s.graph.Register(d.img,
12b278d3
 					progressreader.New(progressreader.Config{
 						In:        d.tmpFile,
 						Out:       out,
 						Formatter: sf,
 						Size:      int(d.length),
 						ID:        common.TruncateID(d.img.ID),
 						Action:    "Extracting",
 					}))
7c88e8f1
 				if err != nil {
456f4936
 					return false, err
7c88e8f1
 				}
 
 				// FIXME: Pool release here for parallel tag pull (ensures any downloads block until fully extracted)
 			}
7a9c944b
 			out.Write(sf.FormatProgress(common.TruncateID(d.img.ID), "Pull complete", nil))
636037c3
 			tagUpdated = true
7c88e8f1
 		} else {
7a9c944b
 			out.Write(sf.FormatProgress(common.TruncateID(d.img.ID), "Already exists", nil))
7c88e8f1
 		}
 
 	}
 
636037c3
 	// Check for new tag if no layers downloaded
 	if !tagUpdated {
 		repo, err := s.Get(repoInfo.LocalName)
 		if err != nil {
 			return false, err
 		}
 		if repo != nil {
 			if _, exists := repo[tag]; !exists {
 				tagUpdated = true
 			}
 		}
 	}
 
 	if verified && tagUpdated {
a2b0c977
 		out.Write(sf.FormatStatus(utils.ImageReference(repoInfo.CanonicalName, tag), "The image you are pulling has been verified. Important: image verification is a tech preview feature and should not be relied on to provide security."))
6088df20
 	}
18200030
 
9ececa14
 	if manifestDigest != "" {
514be385
 		out.Write(sf.FormatStatus("", "Digest: %s", manifestDigest))
a2b0c977
 	}
 
 	if utils.DigestReference(tag) {
 		if err = s.SetDigest(repoInfo.LocalName, tag, downloads[0].img.ID); err != nil {
 			return false, err
 		}
 	} else {
 		// only set the repository/tag -> image ID mapping when pulling by tag (i.e. not by digest)
 		if err = s.Set(repoInfo.LocalName, tag, downloads[0].img.ID, true); err != nil {
 			return false, err
 		}
7c88e8f1
 	}
 
636037c3
 	return tagUpdated, nil
7c88e8f1
 }