integration-cli/docker_cli_by_digest_test.go
a2b0c977
 package main
 
 import (
 	"fmt"
 	"os/exec"
 	"regexp"
 	"strings"
 
 	"github.com/docker/docker/utils"
dc944ea7
 	"github.com/go-check/check"
a2b0c977
 )
 
 var (
 	repoName    = fmt.Sprintf("%v/dockercli/busybox-by-dgst", privateRegistryURL)
 	digestRegex = regexp.MustCompile("Digest: ([^\n]+)")
 )
 
 func setupImage() (string, error) {
 	return setupImageWithTag("latest")
 }
 
 func setupImageWithTag(tag string) (string, error) {
 	containerName := "busyboxbydigest"
 
dc944ea7
 	cmd := exec.Command(dockerBinary, "run", "-d", "-e", "digest=1", "--name", containerName, "busybox")
 	if _, err := runCommand(cmd); err != nil {
a2b0c977
 		return "", err
 	}
 
 	// tag the image to upload it to the private registry
 	repoAndTag := utils.ImageReference(repoName, tag)
dc944ea7
 	cmd = exec.Command(dockerBinary, "commit", containerName, repoAndTag)
 	if out, _, err := runCommandWithOutput(cmd); err != nil {
a2b0c977
 		return "", fmt.Errorf("image tagging failed: %s, %v", out, err)
 	}
 
 	// delete the container as we don't need it any more
 	if err := deleteContainer(containerName); err != nil {
 		return "", err
 	}
 
 	// push the image
dc944ea7
 	cmd = exec.Command(dockerBinary, "push", repoAndTag)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
 		return "", fmt.Errorf("pushing the image to the private registry has failed: %s, %v", out, err)
 	}
 
 	// delete our local repo that we previously tagged
dc944ea7
 	cmd = exec.Command(dockerBinary, "rmi", repoAndTag)
 	if out, _, err := runCommandWithOutput(cmd); err != nil {
a2b0c977
 		return "", fmt.Errorf("error deleting images prior to real test: %s, %v", out, err)
 	}
 
 	// the push output includes "Digest: <digest>", so find that
 	matches := digestRegex.FindStringSubmatch(out)
 	if len(matches) != 2 {
 		return "", fmt.Errorf("unable to parse digest from push output: %s", out)
 	}
 	pushDigest := matches[1]
 
 	return pushDigest, nil
 }
 
f696b107
 func (s *DockerRegistrySuite) TestPullByTagDisplaysDigest(c *check.C) {
a2b0c977
 	pushDigest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	// pull from the registry using the tag
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", repoName)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by tag: %s, %v", out, err)
a2b0c977
 	}
 
 	// the pull output includes "Digest: <digest>", so find that
 	matches := digestRegex.FindStringSubmatch(out)
 	if len(matches) != 2 {
dc944ea7
 		c.Fatalf("unable to parse digest from pull output: %s", out)
a2b0c977
 	}
 	pullDigest := matches[1]
 
 	// make sure the pushed and pull digests match
 	if pushDigest != pullDigest {
dc944ea7
 		c.Fatalf("push digest %q didn't match pull digest %q", pushDigest, pullDigest)
a2b0c977
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestPullByDigest(c *check.C) {
a2b0c977
 	pushDigest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", imageReference)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	// the pull output includes "Digest: <digest>", so find that
 	matches := digestRegex.FindStringSubmatch(out)
 	if len(matches) != 2 {
dc944ea7
 		c.Fatalf("unable to parse digest from pull output: %s", out)
a2b0c977
 	}
 	pullDigest := matches[1]
 
 	// make sure the pushed and pull digests match
 	if pushDigest != pullDigest {
dc944ea7
 		c.Fatalf("push digest %q didn't match pull digest %q", pushDigest, pullDigest)
a2b0c977
 	}
 }
 
642e6a37
 func (s *DockerRegistrySuite) TestPullByDigestNoFallback(c *check.C) {
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@sha256:ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff", repoName)
 	cmd := exec.Command(dockerBinary, "pull", imageReference)
 	out, _, err := runCommandWithOutput(cmd)
 	if err == nil || !strings.Contains(out, "pulling with digest reference failed from v2 registry") {
 		c.Fatalf("expected non-zero exit status and correct error message when pulling non-existing image: %s", out)
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestCreateByDigest(c *check.C) {
a2b0c977
 	pushDigest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
 
 	containerName := "createByDigest"
dc944ea7
 	cmd := exec.Command(dockerBinary, "create", "--name", containerName, imageReference)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error creating by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	res, err := inspectField(containerName, "Config.Image")
 	if err != nil {
dc944ea7
 		c.Fatalf("failed to get Config.Image: %s, %v", out, err)
a2b0c977
 	}
 	if res != imageReference {
dc944ea7
 		c.Fatalf("unexpected Config.Image: %s (expected %s)", res, imageReference)
a2b0c977
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestRunByDigest(c *check.C) {
a2b0c977
 	pushDigest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
 
 	containerName := "runByDigest"
dc944ea7
 	cmd := exec.Command(dockerBinary, "run", "--name", containerName, imageReference, "sh", "-c", "echo found=$digest")
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error run by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	foundRegex := regexp.MustCompile("found=([^\n]+)")
 	matches := foundRegex.FindStringSubmatch(out)
 	if len(matches) != 2 {
dc944ea7
 		c.Fatalf("error locating expected 'found=1' output: %s", out)
a2b0c977
 	}
 	if matches[1] != "1" {
dc944ea7
 		c.Fatalf("Expected %q, got %q", "1", matches[1])
a2b0c977
 	}
 
 	res, err := inspectField(containerName, "Config.Image")
 	if err != nil {
dc944ea7
 		c.Fatalf("failed to get Config.Image: %s, %v", out, err)
a2b0c977
 	}
 	if res != imageReference {
dc944ea7
 		c.Fatalf("unexpected Config.Image: %s (expected %s)", res, imageReference)
a2b0c977
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestRemoveImageByDigest(c *check.C) {
a2b0c977
 	digest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", imageReference)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	// make sure inspect runs ok
 	if _, err := inspectField(imageReference, "Id"); err != nil {
dc944ea7
 		c.Fatalf("failed to inspect image: %v", err)
a2b0c977
 	}
 
 	// do the delete
 	if err := deleteImages(imageReference); err != nil {
dc944ea7
 		c.Fatalf("unexpected error deleting image: %v", err)
a2b0c977
 	}
 
 	// try to inspect again - it should error this time
 	if _, err := inspectField(imageReference, "Id"); err == nil {
dc944ea7
 		c.Fatalf("unexpected nil err trying to inspect what should be a non-existent image")
a2b0c977
 	} else if !strings.Contains(err.Error(), "No such image") {
dc944ea7
 		c.Fatalf("expected 'No such image' output, got %v", err)
a2b0c977
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestBuildByDigest(c *check.C) {
a2b0c977
 	digest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", imageReference)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	// get the image id
 	imageID, err := inspectField(imageReference, "Id")
 	if err != nil {
dc944ea7
 		c.Fatalf("error getting image id: %v", err)
a2b0c977
 	}
 
 	// do the build
 	name := "buildbydigest"
 	_, err = buildImage(name, fmt.Sprintf(
 		`FROM %s
      CMD ["/bin/echo", "Hello World"]`, imageReference),
 		true)
 	if err != nil {
dc944ea7
 		c.Fatal(err)
a2b0c977
 	}
 
 	// get the build's image id
 	res, err := inspectField(name, "Config.Image")
 	if err != nil {
dc944ea7
 		c.Fatal(err)
a2b0c977
 	}
 	// make sure they match
 	if res != imageID {
dc944ea7
 		c.Fatalf("Image %s, expected %s", res, imageID)
a2b0c977
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestTagByDigest(c *check.C) {
a2b0c977
 	digest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", imageReference)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	// tag it
 	tag := "tagbydigest"
dc944ea7
 	cmd = exec.Command(dockerBinary, "tag", imageReference, tag)
 	if _, err := runCommand(cmd); err != nil {
 		c.Fatalf("unexpected error tagging: %v", err)
a2b0c977
 	}
 
 	expectedID, err := inspectField(imageReference, "Id")
 	if err != nil {
dc944ea7
 		c.Fatalf("error getting original image id: %v", err)
a2b0c977
 	}
 
 	tagID, err := inspectField(tag, "Id")
 	if err != nil {
dc944ea7
 		c.Fatalf("error getting tagged image id: %v", err)
a2b0c977
 	}
 
 	if tagID != expectedID {
dc944ea7
 		c.Fatalf("expected image id %q, got %q", expectedID, tagID)
a2b0c977
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestListImagesWithoutDigests(c *check.C) {
a2b0c977
 	digest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	imageReference := fmt.Sprintf("%s@%s", repoName, digest)
 
 	// pull from the registry using the <name>@<digest> reference
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", imageReference)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
dc944ea7
 	cmd = exec.Command(dockerBinary, "images")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error listing images: %s, %v", out, err)
a2b0c977
 	}
 
 	if strings.Contains(out, "DIGEST") {
dc944ea7
 		c.Fatalf("list output should not have contained DIGEST header: %s", out)
a2b0c977
 	}
 
 }
 
f696b107
 func (s *DockerRegistrySuite) TestListImagesWithDigests(c *check.C) {
a2b0c977
 
 	// setup image1
 	digest1, err := setupImageWithTag("tag1")
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 	imageReference1 := fmt.Sprintf("%s@%s", repoName, digest1)
dc944ea7
 	c.Logf("imageReference1 = %s", imageReference1)
a2b0c977
 
 	// pull image1 by digest
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", imageReference1)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	// list images
dc944ea7
 	cmd = exec.Command(dockerBinary, "images", "--digests")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error listing images: %s, %v", out, err)
a2b0c977
 	}
 
 	// make sure repo shown, tag=<none>, digest = $digest1
 	re1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1 + `\s`)
 	if !re1.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", re1.String(), out)
a2b0c977
 	}
 
 	// setup image2
 	digest2, err := setupImageWithTag("tag2")
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 	imageReference2 := fmt.Sprintf("%s@%s", repoName, digest2)
dc944ea7
 	c.Logf("imageReference2 = %s", imageReference2)
a2b0c977
 
 	// pull image1 by digest
dc944ea7
 	cmd = exec.Command(dockerBinary, "pull", imageReference1)
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	// pull image2 by digest
dc944ea7
 	cmd = exec.Command(dockerBinary, "pull", imageReference2)
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 
 	// list images
dc944ea7
 	cmd = exec.Command(dockerBinary, "images", "--digests")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error listing images: %s, %v", out, err)
a2b0c977
 	}
 
 	// make sure repo shown, tag=<none>, digest = $digest1
 	if !re1.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", re1.String(), out)
a2b0c977
 	}
 
 	// make sure repo shown, tag=<none>, digest = $digest2
 	re2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2 + `\s`)
 	if !re2.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", re2.String(), out)
a2b0c977
 	}
 
 	// pull tag1
dc944ea7
 	cmd = exec.Command(dockerBinary, "pull", repoName+":tag1")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling tag1: %s, %v", out, err)
a2b0c977
 	}
 
 	// list images
dc944ea7
 	cmd = exec.Command(dockerBinary, "images", "--digests")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error listing images: %s, %v", out, err)
a2b0c977
 	}
 
 	// make sure image 1 has repo, tag, <none> AND repo, <none>, digest
 	reWithTag1 := regexp.MustCompile(`\s*` + repoName + `\s*tag1\s*<none>\s`)
 	reWithDigest1 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest1 + `\s`)
 	if !reWithTag1.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", reWithTag1.String(), out)
a2b0c977
 	}
 	if !reWithDigest1.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", reWithDigest1.String(), out)
a2b0c977
 	}
 	// make sure image 2 has repo, <none>, digest
 	if !re2.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", re2.String(), out)
a2b0c977
 	}
 
 	// pull tag 2
dc944ea7
 	cmd = exec.Command(dockerBinary, "pull", repoName+":tag2")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling tag2: %s, %v", out, err)
a2b0c977
 	}
 
 	// list images
dc944ea7
 	cmd = exec.Command(dockerBinary, "images", "--digests")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error listing images: %s, %v", out, err)
a2b0c977
 	}
 
 	// make sure image 1 has repo, tag, digest
 	if !reWithTag1.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", re1.String(), out)
a2b0c977
 	}
 
 	// make sure image 2 has repo, tag, digest
 	reWithTag2 := regexp.MustCompile(`\s*` + repoName + `\s*tag2\s*<none>\s`)
 	reWithDigest2 := regexp.MustCompile(`\s*` + repoName + `\s*<none>\s*` + digest2 + `\s`)
 	if !reWithTag2.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", reWithTag2.String(), out)
a2b0c977
 	}
 	if !reWithDigest2.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", reWithDigest2.String(), out)
a2b0c977
 	}
 
 	// list images
dc944ea7
 	cmd = exec.Command(dockerBinary, "images", "--digests")
 	out, _, err = runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error listing images: %s, %v", out, err)
a2b0c977
 	}
 
 	// make sure image 1 has repo, tag, digest
 	if !reWithTag1.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", re1.String(), out)
a2b0c977
 	}
 	// make sure image 2 has repo, tag, digest
 	if !reWithTag2.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", re2.String(), out)
a2b0c977
 	}
 	// make sure busybox has tag, but not digest
 	busyboxRe := regexp.MustCompile(`\s*busybox\s*latest\s*<none>\s`)
 	if !busyboxRe.MatchString(out) {
dc944ea7
 		c.Fatalf("expected %q: %s", busyboxRe.String(), out)
a2b0c977
 	}
 }
 
f696b107
 func (s *DockerRegistrySuite) TestDeleteImageByIDOnlyPulledByDigest(c *check.C) {
a2b0c977
 	pushDigest, err := setupImage()
 	if err != nil {
dc944ea7
 		c.Fatalf("error setting up image: %v", err)
a2b0c977
 	}
 
 	// pull from the registry using the <name>@<digest> reference
 	imageReference := fmt.Sprintf("%s@%s", repoName, pushDigest)
dc944ea7
 	cmd := exec.Command(dockerBinary, "pull", imageReference)
 	out, _, err := runCommandWithOutput(cmd)
a2b0c977
 	if err != nil {
dc944ea7
 		c.Fatalf("error pulling by digest: %s, %v", out, err)
a2b0c977
 	}
 	// just in case...
 
 	imageID, err := inspectField(imageReference, ".Id")
 	if err != nil {
dc944ea7
 		c.Fatalf("error inspecting image id: %v", err)
a2b0c977
 	}
 
dc944ea7
 	cmd = exec.Command(dockerBinary, "rmi", imageID)
 	if _, err := runCommand(cmd); err != nil {
 		c.Fatalf("error deleting image by id: %v", err)
a2b0c977
 	}
 }