integration-cli/docker_cli_cp_from_container_test.go
418135e7
 package main
 
 import (
 	"os"
 	"path/filepath"
e25352a4
 	"testing"
418135e7
 
6345208b
 	"gotest.tools/assert"
418135e7
 )
 
 // Try all of the test cases from the archive package which implements the
 // internals of `docker cp` and ensure that the behavior matches when actually
 // copying to and from containers.
 
 // Basic assumptions about SRC and DST:
 // 1. SRC must exist.
 // 2. If SRC ends with a trailing separator, it must be a directory.
 // 3. DST parent directory must exist.
 // 4. If DST exists as a file, it must not end with a trailing separator.
 
75f6929b
 // Check that copying from a container to a local symlink copies to the symlink
 // target and does not overwrite the local symlink itself.
00d409f0
 // TODO: move to docker/cli and/or integration/container/copy_test.go
64a928a3
 func (s *DockerSuite) TestCpFromSymlinkDestination(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{addContent: true})
75f6929b
 
 	tmpDir := getTestDir(c, "test-cp-from-err-dst-not-dir")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
 	// First, copy a file from the container to a symlink to a file. This
 	// should overwrite the symlink target contents with the source contents.
f26a31e8
 	srcPath := containerCpPath(containerID, "/file2")
75f6929b
 	dstPath := cpPath(tmpDir, "symlinkToFile1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstPath, nil) == nil)
75f6929b
 
 	// The symlink should not have been modified.
ef4c63ac
 	assert.Assert(c, symlinkTargetEquals(c, dstPath, "file1") == nil)
75f6929b
 
 	// The file should have the contents of "file2" now.
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, cpPath(tmpDir, "file1"), "file2\n") == nil)
75f6929b
 
 	// Next, copy a file from the container to a symlink to a directory. This
 	// should copy the file into the symlink target directory.
 	dstPath = cpPath(tmpDir, "symlinkToDir1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstPath, nil) == nil)
75f6929b
 
 	// The symlink should not have been modified.
ef4c63ac
 	assert.Assert(c, symlinkTargetEquals(c, dstPath, "dir1") == nil)
75f6929b
 
 	// The file should have the contents of "file2" now.
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, cpPath(tmpDir, "file2"), "file2\n") == nil)
75f6929b
 
 	// Next, copy a file from the container to a symlink to a file that does
 	// not exist (a broken symlink). This should create the target file with
 	// the contents of the source file.
 	dstPath = cpPath(tmpDir, "brokenSymlinkToFileX")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstPath, nil) == nil)
75f6929b
 
 	// The symlink should not have been modified.
ef4c63ac
 	assert.Assert(c, symlinkTargetEquals(c, dstPath, "fileX") == nil)
75f6929b
 
 	// The file should have the contents of "file2" now.
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, cpPath(tmpDir, "fileX"), "file2\n") == nil)
75f6929b
 
 	// Next, copy a directory from the container to a symlink to a local
 	// directory. This should copy the directory into the symlink target
 	// directory and not modify the symlink.
f26a31e8
 	srcPath = containerCpPath(containerID, "/dir2")
75f6929b
 	dstPath = cpPath(tmpDir, "symlinkToDir1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstPath, nil) == nil)
75f6929b
 
 	// The symlink should not have been modified.
ef4c63ac
 	assert.Assert(c, symlinkTargetEquals(c, dstPath, "dir1") == nil)
75f6929b
 
 	// The directory should now contain a copy of "dir2".
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, cpPath(tmpDir, "dir1/dir2/file2-1"), "file2-1\n") == nil)
75f6929b
 
 	// Next, copy a directory from the container to a symlink to a local
 	// directory that does not exist (a broken symlink). This should create
 	// the target as a directory with the contents of the source directory. It
 	// should not modify the symlink.
 	dstPath = cpPath(tmpDir, "brokenSymlinkToDirX")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstPath, nil) == nil)
75f6929b
 
 	// The symlink should not have been modified.
ef4c63ac
 	assert.Assert(c, symlinkTargetEquals(c, dstPath, "dirX") == nil)
75f6929b
 
 	// The "dirX" directory should now be a copy of "dir2".
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, cpPath(tmpDir, "dirX/file2-1"), "file2-1\n") == nil)
75f6929b
 }
 
418135e7
 // Possibilities are reduced to the remaining 10 cases:
 //
 //  case | srcIsDir | onlyDirContents | dstExists | dstIsDir | dstTrSep | action
 // ===================================================================================================
 //   A   |  no      |  -              |  no       |  -       |  no      |  create file
 //   B   |  no      |  -              |  no       |  -       |  yes     |  error
 //   C   |  no      |  -              |  yes      |  no      |  -       |  overwrite file
 //   D   |  no      |  -              |  yes      |  yes     |  -       |  create file in dst dir
 //   E   |  yes     |  no             |  no       |  -       |  -       |  create dir, copy contents
 //   F   |  yes     |  no             |  yes      |  no      |  -       |  error
 //   G   |  yes     |  no             |  yes      |  yes     |  -       |  copy dir and contents
 //   H   |  yes     |  yes            |  no       |  -       |  -       |  create dir, copy contents
 //   I   |  yes     |  yes            |  yes      |  no      |  -       |  error
 //   J   |  yes     |  yes            |  yes      |  yes     |  -       |  copy dir contents
 //
 
 // A. SRC specifies a file and DST (no trailing path separator) doesn't
 //    exist. This should create a file with the name DST and copy the
 //    contents of the source file into it.
64a928a3
 func (s *DockerSuite) TestCpFromCaseA(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-from-case-a")
 	defer os.RemoveAll(tmpDir)
 
f26a31e8
 	srcPath := containerCpPath(containerID, "/root/file1")
418135e7
 	dstPath := cpPath(tmpDir, "itWorks.txt")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstPath, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1\n") == nil)
418135e7
 }
 
 // B. SRC specifies a file and DST (with trailing path separator) doesn't
 //    exist. This should cause an error because the copy operation cannot
 //    create a directory when copying a single file.
64a928a3
 func (s *DockerSuite) TestCpFromCaseB(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{addContent: true})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-from-case-b")
 	defer os.RemoveAll(tmpDir)
 
f26a31e8
 	srcPath := containerCpPath(containerID, "/file1")
418135e7
 	dstDir := cpPathTrailingSep(tmpDir, "testDir")
 
8a7ff5ff
 	err := runDockerCp(c, srcPath, dstDir, nil)
6345208b
 	assert.ErrorContains(c, err, "")
418135e7
 
4cf69b99
 	assert.Assert(c, isCpDirNotExist(err), "expected DirNotExists error, but got %T: %s", err, err)
418135e7
 }
 
 // C. SRC specifies a file and DST exists as a file. This should overwrite
 //    the file at DST with the contents of the source file.
64a928a3
 func (s *DockerSuite) TestCpFromCaseC(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-from-case-c")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	srcPath := containerCpPath(containerID, "/root/file1")
418135e7
 	dstPath := cpPath(tmpDir, "file2")
 
 	// Ensure the local file starts with different content.
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file2\n") == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstPath, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1\n") == nil)
418135e7
 }
 
 // D. SRC specifies a file and DST exists as a directory. This should place
 //    a copy of the source file inside it using the basename from SRC. Ensure
 //    this works whether DST has a trailing path separator or not.
64a928a3
 func (s *DockerSuite) TestCpFromCaseD(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{addContent: true})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-from-case-d")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	srcPath := containerCpPath(containerID, "/file1")
418135e7
 	dstDir := cpPath(tmpDir, "dir1")
 	dstPath := filepath.Join(dstDir, "file1")
 
 	// Ensure that dstPath doesn't exist.
f26a31e8
 	_, err := os.Stat(dstPath)
4cf69b99
 	assert.Assert(c, os.IsNotExist(err), "did not expect dstPath %q to exist", dstPath)
418135e7
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1\n") == nil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
f26a31e8
 	// unable to remove dstDir
ef4c63ac
 	assert.Assert(c, os.RemoveAll(dstDir) == nil)
418135e7
 
f26a31e8
 	// unable to make dstDir
ef4c63ac
 	assert.Assert(c, os.MkdirAll(dstDir, os.FileMode(0755)) == nil)
418135e7
 
 	dstDir = cpPathTrailingSep(tmpDir, "dir1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcPath, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1\n") == nil)
418135e7
 }
 
 // E. SRC specifies a directory and DST does not exist. This should create a
 //    directory at DST and copy the contents of the SRC directory into the DST
 //    directory. Ensure this works whether DST has a trailing path separator or
 //    not.
64a928a3
 func (s *DockerSuite) TestCpFromCaseE(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{addContent: true})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-from-case-e")
 	defer os.RemoveAll(tmpDir)
 
f26a31e8
 	srcDir := containerCpPath(containerID, "dir1")
418135e7
 	dstDir := cpPath(tmpDir, "testDir")
 	dstPath := filepath.Join(dstDir, "file1-1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
f26a31e8
 	// unable to remove dstDir
ef4c63ac
 	assert.Assert(c, os.RemoveAll(dstDir) == nil)
418135e7
 
 	dstDir = cpPathTrailingSep(tmpDir, "testDir")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 }
 
 // F. SRC specifies a directory and DST exists as a file. This should cause an
 //    error as it is not possible to overwrite a file with a directory.
64a928a3
 func (s *DockerSuite) TestCpFromCaseF(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-from-case-f")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	srcDir := containerCpPath(containerID, "/root/dir1")
418135e7
 	dstFile := cpPath(tmpDir, "file1")
 
8a7ff5ff
 	err := runDockerCp(c, srcDir, dstFile, nil)
6345208b
 	assert.ErrorContains(c, err, "")
418135e7
 
4cf69b99
 	assert.Assert(c, isCpCannotCopyDir(err), "expected ErrCannotCopyDir error, but got %T: %s", err, err)
418135e7
 }
 
 // G. SRC specifies a directory and DST exists as a directory. This should copy
 //    the SRC directory and all its contents to the DST directory. Ensure this
 //    works whether DST has a trailing path separator or not.
64a928a3
 func (s *DockerSuite) TestCpFromCaseG(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-from-case-g")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	srcDir := containerCpPath(containerID, "/root/dir1")
418135e7
 	dstDir := cpPath(tmpDir, "dir2")
 	resultDir := filepath.Join(dstDir, "dir1")
 	dstPath := filepath.Join(resultDir, "file1-1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
f26a31e8
 	// unable to remove dstDir
ef4c63ac
 	assert.Assert(c, os.RemoveAll(dstDir) == nil)
418135e7
 
f26a31e8
 	// unable to make dstDir
ef4c63ac
 	assert.Assert(c, os.MkdirAll(dstDir, os.FileMode(0755)) == nil)
418135e7
 
 	dstDir = cpPathTrailingSep(tmpDir, "dir2")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 }
 
 // H. SRC specifies a directory's contents only and DST does not exist. This
 //    should create a directory at DST and copy the contents of the SRC
 //    directory (but not the directory itself) into the DST directory. Ensure
 //    this works whether DST has a trailing path separator or not.
64a928a3
 func (s *DockerSuite) TestCpFromCaseH(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{addContent: true})
418135e7
 
 	tmpDir := getTestDir(c, "test-cp-from-case-h")
 	defer os.RemoveAll(tmpDir)
 
f26a31e8
 	srcDir := containerCpPathTrailingSep(containerID, "dir1") + "."
418135e7
 	dstDir := cpPath(tmpDir, "testDir")
 	dstPath := filepath.Join(dstDir, "file1-1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
f26a31e8
 	// unable to remove resultDir
ef4c63ac
 	assert.Assert(c, os.RemoveAll(dstDir) == nil)
418135e7
 
 	dstDir = cpPathTrailingSep(tmpDir, "testDir")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 }
 
7b4e6fc4
 // I. SRC specifies a directory's contents only and DST exists as a file. This
418135e7
 //    should cause an error as it is not possible to overwrite a file with a
 //    directory.
64a928a3
 func (s *DockerSuite) TestCpFromCaseI(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-from-case-i")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	srcDir := containerCpPathTrailingSep(containerID, "/root/dir1") + "."
418135e7
 	dstFile := cpPath(tmpDir, "file1")
 
8a7ff5ff
 	err := runDockerCp(c, srcDir, dstFile, nil)
6345208b
 	assert.ErrorContains(c, err, "")
418135e7
 
4cf69b99
 	assert.Assert(c, isCpCannotCopyDir(err), "expected ErrCannotCopyDir error, but got %T: %s", err, err)
418135e7
 }
 
 // J. SRC specifies a directory's contents only and DST exists as a directory.
 //    This should copy the contents of the SRC directory (but not the directory
 //    itself) into the DST directory. Ensure this works whether DST has a
 //    trailing path separator or not.
64a928a3
 func (s *DockerSuite) TestCpFromCaseJ(c *testing.T) {
f9a3558a
 	testRequires(c, DaemonIsLinux)
f26a31e8
 	containerID := makeTestContainer(c, testContainerOptions{
418135e7
 		addContent: true, workDir: "/root",
 	})
 
 	tmpDir := getTestDir(c, "test-cp-from-case-j")
 	defer os.RemoveAll(tmpDir)
 
 	makeTestContentInDir(c, tmpDir)
 
f26a31e8
 	srcDir := containerCpPathTrailingSep(containerID, "/root/dir1") + "."
418135e7
 	dstDir := cpPath(tmpDir, "dir2")
 	dstPath := filepath.Join(dstDir, "file1-1")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 
 	// Now try again but using a trailing path separator for dstDir.
 
f26a31e8
 	// unable to remove dstDir
ef4c63ac
 	assert.Assert(c, os.RemoveAll(dstDir) == nil)
418135e7
 
f26a31e8
 	// unable to make dstDir
ef4c63ac
 	assert.Assert(c, os.MkdirAll(dstDir, os.FileMode(0755)) == nil)
418135e7
 
 	dstDir = cpPathTrailingSep(tmpDir, "dir2")
 
ef4c63ac
 	assert.Assert(c, runDockerCp(c, srcDir, dstDir, nil) == nil)
418135e7
 
ef4c63ac
 	assert.Assert(c, fileContentEquals(c, dstPath, "file1-1\n") == nil)
418135e7
 }