Browse code

Merge pull request #3113 from shykes/engine-export

Move 'docker export' to the engine API

Victor Vieux authored on 2013/12/11 06:28:24
Showing 3 changed files
... ...
@@ -174,10 +174,11 @@ func getContainersExport(srv *Server, version float64, w http.ResponseWriter, r
174 174
 	if vars == nil {
175 175
 		return fmt.Errorf("Missing parameter")
176 176
 	}
177
-	name := vars["name"]
178
-
179
-	if err := srv.ContainerExport(name, w); err != nil {
180
-		utils.Errorf("%s", err)
177
+	job := srv.Eng.Job("export", vars["name"])
178
+	if err := job.Stdout.Add(w); err != nil {
179
+		return err
180
+	}
181
+	if err := job.Run(); err != nil {
181 182
 		return err
182 183
 	}
183 184
 	return nil
... ...
@@ -113,7 +113,6 @@ func (eng *Engine) Job(name string, args ...string) *Job {
113 113
 		Stderr: NewOutput(),
114 114
 		env:    &Env{},
115 115
 	}
116
-	job.Stdout.Add(utils.NopWriteCloser(eng.Stdout))
117 116
 	job.Stderr.Add(utils.NopWriteCloser(eng.Stderr))
118 117
 	handler, exists := eng.handlers[name]
119 118
 	if exists {
... ...
@@ -70,6 +70,10 @@ func jobInitApi(job *engine.Job) engine.Status {
70 70
 	if srv.runtime.networkManager.bridgeNetwork != nil {
71 71
 		job.Eng.Hack_SetGlobalVar("httpapi.bridgeIP", srv.runtime.networkManager.bridgeNetwork.IP)
72 72
 	}
73
+	if err := job.Eng.Register("export", srv.ContainerExport); err != nil {
74
+		job.Error(err)
75
+		return engine.StatusErr
76
+	}
73 77
 	if err := job.Eng.Register("create", srv.ContainerCreate); err != nil {
74 78
 		job.Error(err)
75 79
 		return engine.StatusErr
... ...
@@ -165,22 +169,30 @@ func (srv *Server) ContainerKill(name string, sig int) error {
165 165
 	return nil
166 166
 }
167 167
 
168
-func (srv *Server) ContainerExport(name string, out io.Writer) error {
168
+func (srv *Server) ContainerExport(job *engine.Job) engine.Status {
169
+	if len(job.Args) != 1 {
170
+		job.Errorf("Usage: %s container_id", job.Name)
171
+		return engine.StatusErr
172
+	}
173
+	name := job.Args[0]
169 174
 	if container := srv.runtime.Get(name); container != nil {
170
-
171 175
 		data, err := container.Export()
172 176
 		if err != nil {
173
-			return err
177
+			job.Errorf("%s: %s", name, err)
178
+			return engine.StatusErr
174 179
 		}
175 180
 
176 181
 		// Stream the entire contents of the container (basically a volatile snapshot)
177
-		if _, err := io.Copy(out, data); err != nil {
178
-			return err
182
+		if _, err := io.Copy(job.Stdout, data); err != nil {
183
+			job.Errorf("%s: %s", name, err)
184
+			return engine.StatusErr
179 185
 		}
186
+		// FIXME: factor job-specific LogEvent to engine.Job.Run()
180 187
 		srv.LogEvent("export", container.ID, srv.runtime.repositories.ImageName(container.Image))
181
-		return nil
188
+		return engine.StatusOK
182 189
 	}
183
-	return fmt.Errorf("No such container: %s", name)
190
+	job.Errorf("No such container: %s", name)
191
+	return engine.StatusErr
184 192
 }
185 193
 
186 194
 // ImageExport exports all images with the given tag. All versions