GitList

Browse code

Reduce TestClientWithRequestTimeout flakiness

The test sometimes failed because no error was returned:

=== Failed
=== FAIL: pkg/plugins TestClientWithRequestTimeout (0.00s)
client_test.go:254: assertion failed: expected an error, got nil: expected error

Possibly caused by a race condition, as the sleep was just 1 ms longer than the timeout;
this patch is increasing the sleep in the response to try to reduce flakiness.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2021/06/30 06:53:23
Showing 1 changed files

pkg/plugins/client_test.go index 71a5614..f93734d 100644

pkg/plugins/client_test.go

History View file @ 00a4f67

@@ -242,7 +242,7 @@ func TestClientWithRequestTimeout(t *testing.T) {
                      	timeout := 1 * time.Millisecond
                      	testHandler := func(w http.ResponseWriter, r *http.Request) {
                     -		time.Sleep(timeout + 1*time.Millisecond)
                     +		time.Sleep(timeout + 10*time.Millisecond)
                      		w.WriteHeader(http.StatusOK)
+                     	}