Browse code

Windows CI: Port TestKill*

Signed-off-by: John Howard <jhoward@microsoft.com>

John Howard authored on 2016/02/25 06:33:25
Showing 1 changed files
... ...
@@ -10,8 +10,7 @@ import (
10 10
 )
11 11
 
12 12
 func (s *DockerSuite) TestKillContainer(c *check.C) {
13
-	testRequires(c, DaemonIsLinux)
14
-	out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
13
+	out, _ := runSleepingContainer(c, "-d")
15 14
 	cleanedContainerID := strings.TrimSpace(out)
16 15
 	c.Assert(waitRun(cleanedContainerID), check.IsNil)
17 16
 
... ...
@@ -22,9 +21,8 @@ func (s *DockerSuite) TestKillContainer(c *check.C) {
22 22
 
23 23
 }
24 24
 
25
-func (s *DockerSuite) TestKillofStoppedContainer(c *check.C) {
26
-	testRequires(c, DaemonIsLinux)
27
-	out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
25
+func (s *DockerSuite) TestKillOffStoppedContainer(c *check.C) {
26
+	out, _ := runSleepingContainer(c, "-d")
28 27
 	cleanedContainerID := strings.TrimSpace(out)
29 28
 
30 29
 	dockerCmd(c, "stop", cleanedContainerID)
... ...
@@ -34,6 +32,7 @@ func (s *DockerSuite) TestKillofStoppedContainer(c *check.C) {
34 34
 }
35 35
 
36 36
 func (s *DockerSuite) TestKillDifferentUserContainer(c *check.C) {
37
+	// TODO Windows: Windows does not yet support -u (Feb 2016).
37 38
 	testRequires(c, DaemonIsLinux)
38 39
 	out, _ := dockerCmd(c, "run", "-u", "daemon", "-d", "busybox", "top")
39 40
 	cleanedContainerID := strings.TrimSpace(out)
... ...
@@ -48,6 +47,7 @@ func (s *DockerSuite) TestKillDifferentUserContainer(c *check.C) {
48 48
 
49 49
 // regression test about correct signal parsing see #13665
50 50
 func (s *DockerSuite) TestKillWithSignal(c *check.C) {
51
+	// Cannot port to Windows - does not support signals in the same was a Linux does
51 52
 	testRequires(c, DaemonIsLinux)
52 53
 	out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
53 54
 	cid := strings.TrimSpace(out)
... ...
@@ -61,8 +61,7 @@ func (s *DockerSuite) TestKillWithSignal(c *check.C) {
61 61
 }
62 62
 
63 63
 func (s *DockerSuite) TestKillWithInvalidSignal(c *check.C) {
64
-	testRequires(c, DaemonIsLinux)
65
-	out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
64
+	out, _ := runSleepingContainer(c, "-d")
66 65
 	cid := strings.TrimSpace(out)
67 66
 	c.Assert(waitRun(cid), check.IsNil)
68 67
 
... ...
@@ -73,7 +72,7 @@ func (s *DockerSuite) TestKillWithInvalidSignal(c *check.C) {
73 73
 	running := inspectField(c, cid, "State.Running")
74 74
 	c.Assert(running, checker.Equals, "true", check.Commentf("Container should be in running state after an invalid signal"))
75 75
 
76
-	out, _ = dockerCmd(c, "run", "-d", "busybox", "top")
76
+	out, _ = runSleepingContainer(c, "-d")
77 77
 	cid = strings.TrimSpace(out)
78 78
 	c.Assert(waitRun(cid), check.IsNil)
79 79
 
... ...
@@ -87,8 +86,7 @@ func (s *DockerSuite) TestKillWithInvalidSignal(c *check.C) {
87 87
 }
88 88
 
89 89
 func (s *DockerSuite) TestKillStoppedContainerAPIPre120(c *check.C) {
90
-	testRequires(c, DaemonIsLinux)
91
-	dockerCmd(c, "run", "--name", "docker-kill-test-api", "-d", "busybox", "top")
90
+	runSleepingContainer(c, "--name", "docker-kill-test-api", "-d")
92 91
 	dockerCmd(c, "stop", "docker-kill-test-api")
93 92
 
94 93
 	status, _, err := sockRequest("POST", fmt.Sprintf("/v1.19/containers/%s/kill", "docker-kill-test-api"), nil)