Browse code

Use actual cli version for TestConfigHTTPHeader

Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>

Kenfe-Mickael Laventure authored on 2017/06/02 01:35:30
Showing 3 changed files
... ...
@@ -17,6 +17,8 @@ if ! command -v "$TEST_CLIENT_BINARY" &> /dev/null; then
17 17
 	false
18 18
 fi
19 19
 
20
+export DOCKER_CLI_VERSION=$(${TEST_CLIENT_BINARY} --version | awk '{ gsub(",", " "); print $3 }')
21
+
20 22
 # This is a temporary hack for split-binary mode. It can be removed once
21 23
 # https://github.com/docker/docker/pull/22134 is merged into docker master
22 24
 if [ "$(go env GOOS)" = 'windows' ]; then
... ...
@@ -60,6 +60,7 @@ test_env() {
60 60
 		# use "env -i" to tightly control the environment variables that bleed into the tests
61 61
 		env -i \
62 62
 			DEST="$DEST" \
63
+			DOCKER_CLI_VERSION="$DOCKER_CLI_VERSION" \
63 64
 			DOCKER_API_VERSION="$DOCKER_API_VERSION" \
64 65
 			DOCKER_INTEGRATION_DAEMON_DEST="$DOCKER_INTEGRATION_DAEMON_DEST" \
65 66
 			DOCKER_TLS_VERIFY="$DOCKER_TEST_TLS_VERIFY" \
... ...
@@ -58,8 +58,7 @@ func (s *DockerSuite) TestConfigHTTPHeader(c *check.C) {
58 58
 
59 59
 	c.Assert(headers["User-Agent"], checker.NotNil, check.Commentf("Missing User-Agent"))
60 60
 
61
-	//TODO(tiborvass): restore dockerversion.Version instead of library-import
62
-	c.Assert(headers["User-Agent"][0], checker.Equals, "Docker-Client/unknown-version ("+runtime.GOOS+")", check.Commentf("Badly formatted User-Agent,out:%v", result.Combined()))
61
+	c.Assert(headers["User-Agent"][0], checker.Equals, "Docker-Client/"+os.Getenv("DOCKER_CLI_VERSION")+" ("+runtime.GOOS+")", check.Commentf("Badly formatted User-Agent,out:%v", result.Combined()))
63 62
 
64 63
 	c.Assert(headers["Myheader"], checker.NotNil)
65 64
 	c.Assert(headers["Myheader"][0], checker.Equals, "MyValue", check.Commentf("Missing/bad header,out:%v", result.Combined()))