Browse code

optimize restore & use Getenv less in daemon.go

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com> (github: unclejack)

unclejack authored on 2014/05/31 03:03:56
Showing 1 changed files
... ...
@@ -327,7 +327,9 @@ func (daemon *Daemon) Destroy(container *Container) error {
327 327
 }
328 328
 
329 329
 func (daemon *Daemon) restore() error {
330
-	if os.Getenv("DEBUG") == "" && os.Getenv("TEST") == "" {
330
+	debug := (os.Getenv("DEBUG") != "" || os.Getenv("TEST") != "")
331
+
332
+	if !debug {
331 333
 		fmt.Printf("Loading containers: ")
332 334
 	}
333 335
 	dir, err := ioutil.ReadDir(daemon.repository)
... ...
@@ -340,7 +342,7 @@ func (daemon *Daemon) restore() error {
340 340
 	for _, v := range dir {
341 341
 		id := v.Name()
342 342
 		container, err := daemon.load(id)
343
-		if os.Getenv("DEBUG") == "" && os.Getenv("TEST") == "" {
343
+		if !debug {
344 344
 			fmt.Print(".")
345 345
 		}
346 346
 		if err != nil {
... ...
@@ -357,20 +359,16 @@ func (daemon *Daemon) restore() error {
357 357
 		}
358 358
 	}
359 359
 
360
-	registerContainer := func(container *Container) {
361
-		if err := daemon.register(container, false); err != nil {
362
-			utils.Debugf("Failed to register container %s: %s", container.ID, err)
363
-		}
364
-	}
365
-
366 360
 	if entities := daemon.containerGraph.List("/", -1); entities != nil {
367 361
 		for _, p := range entities.Paths() {
368
-			if os.Getenv("DEBUG") == "" && os.Getenv("TEST") == "" {
362
+			if !debug {
369 363
 				fmt.Print(".")
370 364
 			}
371 365
 			e := entities[p]
372 366
 			if container, ok := containers[e.ID()]; ok {
373
-				registerContainer(container)
367
+				if err := daemon.register(container, false); err != nil {
368
+					utils.Debugf("Failed to register container %s: %s", container.ID, err)
369
+				}
374 370
 				delete(containers, e.ID())
375 371
 			}
376 372
 		}
... ...
@@ -383,11 +381,13 @@ func (daemon *Daemon) restore() error {
383 383
 		if err != nil {
384 384
 			utils.Debugf("Setting default id - %s", err)
385 385
 		}
386
-		registerContainer(container)
386
+		if err := daemon.register(container, false); err != nil {
387
+			utils.Debugf("Failed to register container %s: %s", container.ID, err)
388
+		}
387 389
 	}
388 390
 
389 391
 	daemon.idIndex.UpdateSuffixarray()
390
-	if os.Getenv("DEBUG") == "" && os.Getenv("TEST") == "" {
392
+	if !debug {
391 393
 		fmt.Printf(": done.\n")
392 394
 	}
393 395