1. docker
  2. Commit 15b30881570369564bde3f7d8faf4491b2ebfaab
Browse code

Don't convert []byte to string unnecessarily.

Caleb Spare authored on 2013/03/30 16:22:56
Showing 2 changed files
auth/auth.go
History View file @ 15b3088
... ... 
@@ -152,11 +152,11 @@ func Login(authConfig *AuthConfig) (string, error) {
152 152 
 				return "", errors.New(status)
153 153 
 			}
154 154 
 		} else {
155 
-			status = fmt.Sprintf("Registration: %s", string(reqBody))
155 
+			status = fmt.Sprintf("Registration: %s", reqBody)
156 156 
 			return "", errors.New(status)
157 157 
 		}
158 158 
 	} else {
159 
-		status = fmt.Sprintf("[%s] : %s", reqStatusCode, string(reqBody))
159 
+		status = fmt.Sprintf("[%s] : %s", reqStatusCode, reqBody)
160 160 
 		return "", errors.New(status)
161 161 
 	}
162 162 
 	if storeConfig {
container_test.go
History View file @ 15b3088
... ... 
@@ -227,7 +227,7 @@ func TestCommitRun(t *testing.T) {
227 227 
 		t.Fatal(err)
228 228 
 	}
229 229 
 	if string(output) != "hello\n" {
230 
-		t.Fatalf("Unexpected output. Expected %s, received: %s (err: %s)", "hello\n", string(output), string(output2))
230 
+		t.Fatalf("Unexpected output. Expected %s, received: %s (err: %s)", "hello\n", output, output2)
231 231 
 	}
232 232 
 }
233 233
... ... 
@@ -885,7 +885,7 @@ func BenchmarkRunSequencial(b *testing.B) {
885 885 
 			b.Fatal(err)
886 886 
 		}
887 887 
 		if string(output) != "foo" {
888 
-			b.Fatalf("Unexecpted output: %v", string(output))
888 
+			b.Fatalf("Unexpected output: %s", output)
889 889 
 		}
890 890 
 		if err := runtime.Destroy(container); err != nil {
891 891 
 			b.Fatal(err)