Browse code

builder: temporarily disable bridge networking when using buildkit

Signed-off-by: Tibor Vass <tibor@docker.com>

Tibor Vass authored on 2018/08/22 12:00:02
Showing 4 changed files
... ...
@@ -18,16 +18,13 @@ import (
18 18
 
19 19
 const networkName = "bridge"
20 20
 
21
-func init() {
22
-	// FIXME: https://github.com/moby/moby/issues/37676
23
-	runcexecutor.DisableSubReaper()
24
-}
25
-
26 21
 func newExecutor(root string, net libnetwork.NetworkController) (executor.Executor, error) {
22
+	// FIXME: fix bridge networking
23
+	_ = bridgeProvider{}
27 24
 	return runcexecutor.New(runcexecutor.Opt{
28 25
 		Root:              filepath.Join(root, "executor"),
29 26
 		CommandCandidates: []string{"docker-runc", "runc"},
30
-	}, &bridgeProvider{NetworkController: net})
27
+	}, nil)
31 28
 }
32 29
 
33 30
 type bridgeProvider struct {
... ...
@@ -26,7 +26,7 @@ github.com/imdario/mergo v0.3.6
26 26
 golang.org/x/sync 1d60e4601c6fd243af51cc01ddf169918a5407ca
27 27
 
28 28
 # buildkit
29
-github.com/moby/buildkit 46f9075ab68a07df2c40ae6e240ce4f9392b3a66 git://github.com/tiborvass/buildkit.git
29
+github.com/moby/buildkit 49906c62925ed429ec9174a0b6869982967f1a39
30 30
 github.com/tonistiigi/fsutil b19464cd1b6a00773b4f2eb7acf9c30426f9df42
31 31
 github.com/grpc-ecosystem/grpc-opentracing 8e809c8a86450a29b90dcc9efbf062d0fe6d9746
32 32
 github.com/opentracing/opentracing-go 1361b9cd60be79c4c3a7fa9841b3c132e40066a7
... ...
@@ -404,12 +404,6 @@ func (s *forwardIO) writeCloserToFile(wc io.WriteCloser) (*os.File, error) {
404 404
 var subReaperOnce sync.Once
405 405
 var subReaperError error
406 406
 
407
-// DisableSubReaper prevents setting subreaper on the current process.
408
-// Do not rely on this function it may change or be removed.
409
-func DisableSubReaper() {
410
-	subReaperOnce.Do(func() {})
411
-}
412
-
413 407
 func setSubReaper() error {
414 408
 	subReaperOnce.Do(func() {
415 409
 		subReaperError = runcsystem.SetSubreaper(1)
... ...
@@ -14,7 +14,7 @@ google.golang.org/grpc v1.12.0
14 14
 github.com/opencontainers/go-digest c9281466c8b2f606084ac71339773efd177436e7
15 15
 golang.org/x/net 0ed95abb35c445290478a5348a7b38bb154135fd
16 16
 github.com/gogo/protobuf v1.0.0
17
-github.com/gogo/googleapis 08a7655d27152912db7aaf4f983275eaf8d128ef
17
+github.com/gogo/googleapis b23578765ee54ff6bceff57f397d833bf4ca6869
18 18
 github.com/golang/protobuf v1.1.0
19 19
 github.com/containerd/continuity d3c23511c1bf5851696cba83143d9cbcd666869b
20 20
 github.com/opencontainers/image-spec v1.0.1