Browse code

docker-py: fix linting issues reported by shellcheck

- SC2006: use $(...) notation instead of legacy backticked `...`
- SC2086: double quote to prevent globbing and word splitting

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 0b3d201892682d4886b5c03d81c1e3d60702bd77)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2019/08/10 20:07:02
Showing 1 changed files
... ...
@@ -7,21 +7,21 @@ source hack/make/.integration-test-helpers
7 7
 # TODO docker 17.06 cli client used in CI fails to build using a sha;
8 8
 # unable to prepare context: unable to 'git clone' to temporary context directory: error fetching: error: no such remote ref ead0bb9e08c13dd3d1712759491eee06bf5a5602
9 9
 #: exit status 128
10
-: ${DOCKER_PY_COMMIT:=4.0.2}
10
+: "${DOCKER_PY_COMMIT:=4.0.2}"
11 11
 
12 12
 # custom options to pass py.test
13 13
 # TODO remove these skip once we update to a docker-py version that has https://github.com/docker/docker-py/pull/2369, https://github.com/docker/docker-py/pull/2380, https://github.com/docker/docker-py/pull/2382
14
-: ${PY_TEST_OPTIONS:="\
14
+: "${PY_TEST_OPTIONS:=\
15 15
 --deselect=tests/integration/api_swarm_test.py::SwarmTest::test_init_swarm_data_path_addr \
16 16
 --deselect=tests/integration/api_exec_test.py::ExecTest::test_detach_with_arg \
17 17
 --deselect=tests/integration/api_exec_test.py::ExecDemuxTest::test_exec_command_tty_stream_no_demux \
18 18
 --deselect=tests/integration/api_build_test.py::BuildTest::test_build_invalid_platform \
19 19
 --deselect=tests/integration/api_image_test.py::PullImageTest::test_pull_invalid_platform \
20
-"}
20
+}"
21 21
 (
22 22
 	bundle .integration-daemon-start
23 23
 
24
-	docker_host_scheme=`echo "${DOCKER_HOST}" | cut -d: -f1 -`
24
+	docker_host_scheme=$(echo "${DOCKER_HOST}" | cut -d: -f1 -)
25 25
 
26 26
 	case "${docker_host_scheme}" in
27 27
 		unix)
... ...
@@ -48,14 +48,16 @@ source hack/make/.integration-test-helpers
48 48
 			[ -n "${TESTDEBUG}" ] && set -x
49 49
 			[ -z "${TESTDEBUG}" ] && build_opts="--quiet"
50 50
 			[ -f /.dockerenv ] || build_opts="${build_opts} --network=host"
51
-			exec docker build ${build_opts} -t ${docker_py_image} -f tests/Dockerfile "https://github.com/docker/docker-py.git#${DOCKER_PY_COMMIT}"
51
+			# shellcheck disable=SC2086
52
+			exec docker build ${build_opts} -t "${docker_py_image}" -f tests/Dockerfile "https://github.com/docker/docker-py.git#${DOCKER_PY_COMMIT}"
52 53
 		)
53 54
 	fi
54 55
 
55 56
 	echo INFO: Starting docker-py tests...
56 57
 	(
57 58
 		[ -n "${TESTDEBUG}" ] && set -x
58
-		exec docker run -t --rm ${run_opts} ${docker_py_image} pytest ${PY_TEST_OPTIONS} tests/integration
59
+		# shellcheck disable=SC2086
60
+		exec docker run -t --rm ${run_opts} "${docker_py_image}" pytest ${PY_TEST_OPTIONS} tests/integration
59 61
 	)
60 62
 	bundle .integration-daemon-stop
61 63
 ) 2>&1 | tee -a "$DEST/test.log"