Browse code

client: DiskUsage: rename fields to match API

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Sebastiaan van Stijn authored on 2025/11/07 07:58:57
Showing 4 changed files
... ...
@@ -51,11 +51,11 @@ type DiskUsageResult struct {
51 51
 
52 52
 // ContainersDiskUsage contains disk usage information for containers.
53 53
 type ContainersDiskUsage struct {
54
-	// ActiveContainers is the number of active containers.
55
-	ActiveContainers int64
54
+	// ActiveCount is the number of active containers.
55
+	ActiveCount int64
56 56
 
57
-	// TotalContainers is the total number of containers.
58
-	TotalContainers int64
57
+	// TotalCount is the total number of containers.
58
+	TotalCount int64
59 59
 
60 60
 	// Reclaimable is the amount of disk space that can be reclaimed.
61 61
 	Reclaimable int64
... ...
@@ -69,11 +69,11 @@ type ContainersDiskUsage struct {
69 69
 
70 70
 // ImagesDiskUsage contains disk usage information for images.
71 71
 type ImagesDiskUsage struct {
72
-	// ActiveImages is the number of active images.
73
-	ActiveImages int64
72
+	// ActiveCount is the number of active images.
73
+	ActiveCount int64
74 74
 
75
-	// TotalImages is the total number of images.
76
-	TotalImages int64
75
+	// TotalCount is the total number of images.
76
+	TotalCount int64
77 77
 
78 78
 	// Reclaimable is the amount of disk space that can be reclaimed.
79 79
 	Reclaimable int64
... ...
@@ -87,11 +87,11 @@ type ImagesDiskUsage struct {
87 87
 
88 88
 // VolumesDiskUsage contains disk usage information for volumes.
89 89
 type VolumesDiskUsage struct {
90
-	// ActiveVolumes is the number of active volumes.
91
-	ActiveVolumes int64
90
+	// ActiveCount is the number of active volumes.
91
+	ActiveCount int64
92 92
 
93
-	// TotalVolumes is the total number of volumes.
94
-	TotalVolumes int64
93
+	// TotalCount is the total number of volumes.
94
+	TotalCount int64
95 95
 
96 96
 	// Reclaimable is the amount of disk space that can be reclaimed.
97 97
 	Reclaimable int64
... ...
@@ -105,11 +105,11 @@ type VolumesDiskUsage struct {
105 105
 
106 106
 // BuildCacheDiskUsage contains disk usage information for build cache.
107 107
 type BuildCacheDiskUsage struct {
108
-	// ActiveBuildCacheRecords is the number of active build cache records.
109
-	ActiveBuildCacheRecords int64
108
+	// ActiveCount is the number of active build cache records.
109
+	ActiveCount int64
110 110
 
111
-	// TotalBuildCacheRecords is the total number of build cache records.
112
-	TotalBuildCacheRecords int64
111
+	// TotalCount is the total number of build cache records.
112
+	TotalCount int64
113 113
 
114 114
 	// Reclaimable is the amount of disk space that can be reclaimed.
115 115
 	Reclaimable int64
... ...
@@ -162,10 +162,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
162 162
 	var r DiskUsageResult
163 163
 	if idu := du.ImageUsage; idu != nil {
164 164
 		r.Images = ImagesDiskUsage{
165
-			ActiveImages: idu.ActiveCount,
166
-			Reclaimable:  idu.Reclaimable,
167
-			TotalImages:  idu.TotalCount,
168
-			TotalSize:    idu.TotalSize,
165
+			ActiveCount: idu.ActiveCount,
166
+			Reclaimable: idu.Reclaimable,
167
+			TotalCount:  idu.TotalCount,
168
+			TotalSize:   idu.TotalSize,
169 169
 		}
170 170
 
171 171
 		if options.Verbose {
... ...
@@ -175,10 +175,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
175 175
 
176 176
 	if cdu := du.ContainerUsage; cdu != nil {
177 177
 		r.Containers = ContainersDiskUsage{
178
-			ActiveContainers: cdu.ActiveCount,
179
-			Reclaimable:      cdu.Reclaimable,
180
-			TotalContainers:  cdu.TotalCount,
181
-			TotalSize:        cdu.TotalSize,
178
+			ActiveCount: cdu.ActiveCount,
179
+			Reclaimable: cdu.Reclaimable,
180
+			TotalCount:  cdu.TotalCount,
181
+			TotalSize:   cdu.TotalSize,
182 182
 		}
183 183
 
184 184
 		if options.Verbose {
... ...
@@ -188,10 +188,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
188 188
 
189 189
 	if bdu := du.BuildCacheUsage; bdu != nil {
190 190
 		r.BuildCache = BuildCacheDiskUsage{
191
-			ActiveBuildCacheRecords: bdu.ActiveCount,
192
-			Reclaimable:             bdu.Reclaimable,
193
-			TotalBuildCacheRecords:  bdu.TotalCount,
194
-			TotalSize:               bdu.TotalSize,
191
+			ActiveCount: bdu.ActiveCount,
192
+			Reclaimable: bdu.Reclaimable,
193
+			TotalCount:  bdu.TotalCount,
194
+			TotalSize:   bdu.TotalSize,
195 195
 		}
196 196
 
197 197
 		if options.Verbose {
... ...
@@ -201,10 +201,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
201 201
 
202 202
 	if vdu := du.VolumeUsage; vdu != nil {
203 203
 		r.Volumes = VolumesDiskUsage{
204
-			ActiveVolumes: vdu.ActiveCount,
205
-			Reclaimable:   vdu.Reclaimable,
206
-			TotalVolumes:  vdu.TotalCount,
207
-			TotalSize:     vdu.TotalSize,
204
+			ActiveCount: vdu.ActiveCount,
205
+			Reclaimable: vdu.Reclaimable,
206
+			TotalCount:  vdu.TotalCount,
207
+			TotalSize:   vdu.TotalSize,
208 208
 		}
209 209
 
210 210
 		if options.Verbose {
... ...
@@ -226,15 +226,15 @@ func diskUsageResultFromLegacyAPI(du *system.DiskUsage) DiskUsageResult {
226 226
 
227 227
 func imageDiskUsageFromLegacyAPI(du *system.DiskUsage) ImagesDiskUsage {
228 228
 	idu := ImagesDiskUsage{
229
-		TotalSize:   du.LayersSize,
230
-		TotalImages: int64(len(du.Images)),
231
-		Items:       du.Images,
229
+		TotalSize:  du.LayersSize,
230
+		TotalCount: int64(len(du.Images)),
231
+		Items:      du.Images,
232 232
 	}
233 233
 
234 234
 	var used int64
235 235
 	for _, i := range idu.Items {
236 236
 		if i.Containers > 0 {
237
-			idu.ActiveImages++
237
+			idu.ActiveCount++
238 238
 
239 239
 			if i.Size == -1 || i.SharedSize == -1 {
240 240
 				continue
... ...
@@ -243,7 +243,7 @@ func imageDiskUsageFromLegacyAPI(du *system.DiskUsage) ImagesDiskUsage {
243 243
 		}
244 244
 	}
245 245
 
246
-	if idu.TotalImages > 0 {
246
+	if idu.TotalCount > 0 {
247 247
 		idu.Reclaimable = idu.TotalSize - used
248 248
 	}
249 249
 
... ...
@@ -252,8 +252,8 @@ func imageDiskUsageFromLegacyAPI(du *system.DiskUsage) ImagesDiskUsage {
252 252
 
253 253
 func containerDiskUsageFromLegacyAPI(du *system.DiskUsage) ContainersDiskUsage {
254 254
 	cdu := ContainersDiskUsage{
255
-		TotalContainers: int64(len(du.Containers)),
256
-		Items:           du.Containers,
255
+		TotalCount: int64(len(du.Containers)),
256
+		Items:      du.Containers,
257 257
 	}
258 258
 
259 259
 	var used int64
... ...
@@ -261,7 +261,7 @@ func containerDiskUsageFromLegacyAPI(du *system.DiskUsage) ContainersDiskUsage {
261 261
 		cdu.TotalSize += c.SizeRw
262 262
 		switch strings.ToLower(c.State) {
263 263
 		case "running", "paused", "restarting":
264
-			cdu.ActiveContainers++
264
+			cdu.ActiveCount++
265 265
 			used += c.SizeRw
266 266
 		}
267 267
 	}
... ...
@@ -272,8 +272,8 @@ func containerDiskUsageFromLegacyAPI(du *system.DiskUsage) ContainersDiskUsage {
272 272
 
273 273
 func buildCacheDiskUsageFromLegacyAPI(du *system.DiskUsage) BuildCacheDiskUsage {
274 274
 	bdu := BuildCacheDiskUsage{
275
-		TotalBuildCacheRecords: int64(len(du.BuildCache)),
276
-		Items:                  du.BuildCache,
275
+		TotalCount: int64(len(du.BuildCache)),
276
+		Items:      du.BuildCache,
277 277
 	}
278 278
 
279 279
 	var used int64
... ...
@@ -283,7 +283,7 @@ func buildCacheDiskUsageFromLegacyAPI(du *system.DiskUsage) BuildCacheDiskUsage
283 283
 		}
284 284
 
285 285
 		if b.InUse {
286
-			bdu.ActiveBuildCacheRecords++
286
+			bdu.ActiveCount++
287 287
 			if !b.Shared {
288 288
 				used += b.Size
289 289
 			}
... ...
@@ -296,8 +296,8 @@ func buildCacheDiskUsageFromLegacyAPI(du *system.DiskUsage) BuildCacheDiskUsage
296 296
 
297 297
 func volumeDiskUsageFromLegacyAPI(du *system.DiskUsage) VolumesDiskUsage {
298 298
 	vdu := VolumesDiskUsage{
299
-		TotalVolumes: int64(len(du.Volumes)),
300
-		Items:        du.Volumes,
299
+		TotalCount: int64(len(du.Volumes)),
300
+		Items:      du.Volumes,
301 301
 	}
302 302
 
303 303
 	var used int64
... ...
@@ -305,7 +305,7 @@ func volumeDiskUsageFromLegacyAPI(du *system.DiskUsage) VolumesDiskUsage {
305 305
 		// Ignore volumes with no usage data
306 306
 		if v.UsageData != nil {
307 307
 			if v.UsageData.RefCount > 0 {
308
-				vdu.ActiveVolumes++
308
+				vdu.ActiveCount++
309 309
 				used += v.UsageData.Size
310 310
 			}
311 311
 			if v.UsageData.Size > 0 {
... ...
@@ -41,8 +41,8 @@ func TestDiskUsage(t *testing.T) {
41 41
 
42 42
 	du, err := client.DiskUsage(context.Background(), DiskUsageOptions{})
43 43
 	assert.NilError(t, err)
44
-	assert.Equal(t, du.Images.ActiveImages, int64(0))
45
-	assert.Equal(t, du.Images.TotalImages, int64(0))
44
+	assert.Equal(t, du.Images.ActiveCount, int64(0))
45
+	assert.Equal(t, du.Images.TotalCount, int64(0))
46 46
 	assert.Equal(t, du.Images.Reclaimable, int64(0))
47 47
 	assert.Equal(t, du.Images.TotalSize, int64(4096))
48 48
 	assert.Equal(t, len(du.Images.Items), 0)
... ...
@@ -151,8 +151,8 @@ func TestLegacyDiskUsage(t *testing.T) {
151 151
 
152 152
 	du, err := client.DiskUsage(context.Background(), DiskUsageOptions{})
153 153
 	assert.NilError(t, err)
154
-	assert.Equal(t, du.Images.ActiveImages, int64(0))
155
-	assert.Equal(t, du.Images.TotalImages, int64(0))
154
+	assert.Equal(t, du.Images.ActiveCount, int64(0))
155
+	assert.Equal(t, du.Images.TotalCount, int64(0))
156 156
 	assert.Equal(t, du.Images.Reclaimable, int64(0))
157 157
 	assert.Equal(t, du.Images.TotalSize, int64(4096))
158 158
 	assert.Equal(t, len(du.Images.Items), 0)
... ...
@@ -101,8 +101,8 @@ func TestDiskUsage(t *testing.T) {
101 101
 				})
102 102
 				assert.NilError(t, err)
103 103
 
104
-				assert.Equal(t, du.Containers.ActiveContainers, int64(1))
105
-				assert.Equal(t, du.Containers.TotalContainers, int64(1))
104
+				assert.Equal(t, du.Containers.ActiveCount, int64(1))
105
+				assert.Equal(t, du.Containers.TotalCount, int64(1))
106 106
 				assert.Equal(t, len(du.Containers.Items), 1)
107 107
 				assert.Equal(t, len(du.Containers.Items[0].Names), 1)
108 108
 				assert.Assert(t, len(prev.Images.Items) > 0)
... ...
@@ -111,8 +111,8 @@ func TestDiskUsage(t *testing.T) {
111 111
 				// Additional container layer could add to the size
112 112
 				assert.Check(t, du.Images.TotalSize >= prev.Images.TotalSize)
113 113
 
114
-				assert.Equal(t, du.Images.ActiveImages, int64(1))
115
-				assert.Equal(t, du.Images.TotalImages, int64(1))
114
+				assert.Equal(t, du.Images.ActiveCount, int64(1))
115
+				assert.Equal(t, du.Images.TotalCount, int64(1))
116 116
 				assert.Equal(t, len(du.Images.Items), 1)
117 117
 				assert.Equal(t, du.Images.Items[0].Containers, prev.Images.Items[0].Containers+1)
118 118
 
... ...
@@ -51,11 +51,11 @@ type DiskUsageResult struct {
51 51
 
52 52
 // ContainersDiskUsage contains disk usage information for containers.
53 53
 type ContainersDiskUsage struct {
54
-	// ActiveContainers is the number of active containers.
55
-	ActiveContainers int64
54
+	// ActiveCount is the number of active containers.
55
+	ActiveCount int64
56 56
 
57
-	// TotalContainers is the total number of containers.
58
-	TotalContainers int64
57
+	// TotalCount is the total number of containers.
58
+	TotalCount int64
59 59
 
60 60
 	// Reclaimable is the amount of disk space that can be reclaimed.
61 61
 	Reclaimable int64
... ...
@@ -69,11 +69,11 @@ type ContainersDiskUsage struct {
69 69
 
70 70
 // ImagesDiskUsage contains disk usage information for images.
71 71
 type ImagesDiskUsage struct {
72
-	// ActiveImages is the number of active images.
73
-	ActiveImages int64
72
+	// ActiveCount is the number of active images.
73
+	ActiveCount int64
74 74
 
75
-	// TotalImages is the total number of images.
76
-	TotalImages int64
75
+	// TotalCount is the total number of images.
76
+	TotalCount int64
77 77
 
78 78
 	// Reclaimable is the amount of disk space that can be reclaimed.
79 79
 	Reclaimable int64
... ...
@@ -87,11 +87,11 @@ type ImagesDiskUsage struct {
87 87
 
88 88
 // VolumesDiskUsage contains disk usage information for volumes.
89 89
 type VolumesDiskUsage struct {
90
-	// ActiveVolumes is the number of active volumes.
91
-	ActiveVolumes int64
90
+	// ActiveCount is the number of active volumes.
91
+	ActiveCount int64
92 92
 
93
-	// TotalVolumes is the total number of volumes.
94
-	TotalVolumes int64
93
+	// TotalCount is the total number of volumes.
94
+	TotalCount int64
95 95
 
96 96
 	// Reclaimable is the amount of disk space that can be reclaimed.
97 97
 	Reclaimable int64
... ...
@@ -105,11 +105,11 @@ type VolumesDiskUsage struct {
105 105
 
106 106
 // BuildCacheDiskUsage contains disk usage information for build cache.
107 107
 type BuildCacheDiskUsage struct {
108
-	// ActiveBuildCacheRecords is the number of active build cache records.
109
-	ActiveBuildCacheRecords int64
108
+	// ActiveCount is the number of active build cache records.
109
+	ActiveCount int64
110 110
 
111
-	// TotalBuildCacheRecords is the total number of build cache records.
112
-	TotalBuildCacheRecords int64
111
+	// TotalCount is the total number of build cache records.
112
+	TotalCount int64
113 113
 
114 114
 	// Reclaimable is the amount of disk space that can be reclaimed.
115 115
 	Reclaimable int64
... ...
@@ -162,10 +162,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
162 162
 	var r DiskUsageResult
163 163
 	if idu := du.ImageUsage; idu != nil {
164 164
 		r.Images = ImagesDiskUsage{
165
-			ActiveImages: idu.ActiveCount,
166
-			Reclaimable:  idu.Reclaimable,
167
-			TotalImages:  idu.TotalCount,
168
-			TotalSize:    idu.TotalSize,
165
+			ActiveCount: idu.ActiveCount,
166
+			Reclaimable: idu.Reclaimable,
167
+			TotalCount:  idu.TotalCount,
168
+			TotalSize:   idu.TotalSize,
169 169
 		}
170 170
 
171 171
 		if options.Verbose {
... ...
@@ -175,10 +175,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
175 175
 
176 176
 	if cdu := du.ContainerUsage; cdu != nil {
177 177
 		r.Containers = ContainersDiskUsage{
178
-			ActiveContainers: cdu.ActiveCount,
179
-			Reclaimable:      cdu.Reclaimable,
180
-			TotalContainers:  cdu.TotalCount,
181
-			TotalSize:        cdu.TotalSize,
178
+			ActiveCount: cdu.ActiveCount,
179
+			Reclaimable: cdu.Reclaimable,
180
+			TotalCount:  cdu.TotalCount,
181
+			TotalSize:   cdu.TotalSize,
182 182
 		}
183 183
 
184 184
 		if options.Verbose {
... ...
@@ -188,10 +188,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
188 188
 
189 189
 	if bdu := du.BuildCacheUsage; bdu != nil {
190 190
 		r.BuildCache = BuildCacheDiskUsage{
191
-			ActiveBuildCacheRecords: bdu.ActiveCount,
192
-			Reclaimable:             bdu.Reclaimable,
193
-			TotalBuildCacheRecords:  bdu.TotalCount,
194
-			TotalSize:               bdu.TotalSize,
191
+			ActiveCount: bdu.ActiveCount,
192
+			Reclaimable: bdu.Reclaimable,
193
+			TotalCount:  bdu.TotalCount,
194
+			TotalSize:   bdu.TotalSize,
195 195
 		}
196 196
 
197 197
 		if options.Verbose {
... ...
@@ -201,10 +201,10 @@ func (cli *Client) DiskUsage(ctx context.Context, options DiskUsageOptions) (Dis
201 201
 
202 202
 	if vdu := du.VolumeUsage; vdu != nil {
203 203
 		r.Volumes = VolumesDiskUsage{
204
-			ActiveVolumes: vdu.ActiveCount,
205
-			Reclaimable:   vdu.Reclaimable,
206
-			TotalVolumes:  vdu.TotalCount,
207
-			TotalSize:     vdu.TotalSize,
204
+			ActiveCount: vdu.ActiveCount,
205
+			Reclaimable: vdu.Reclaimable,
206
+			TotalCount:  vdu.TotalCount,
207
+			TotalSize:   vdu.TotalSize,
208 208
 		}
209 209
 
210 210
 		if options.Verbose {
... ...
@@ -226,15 +226,15 @@ func diskUsageResultFromLegacyAPI(du *system.DiskUsage) DiskUsageResult {
226 226
 
227 227
 func imageDiskUsageFromLegacyAPI(du *system.DiskUsage) ImagesDiskUsage {
228 228
 	idu := ImagesDiskUsage{
229
-		TotalSize:   du.LayersSize,
230
-		TotalImages: int64(len(du.Images)),
231
-		Items:       du.Images,
229
+		TotalSize:  du.LayersSize,
230
+		TotalCount: int64(len(du.Images)),
231
+		Items:      du.Images,
232 232
 	}
233 233
 
234 234
 	var used int64
235 235
 	for _, i := range idu.Items {
236 236
 		if i.Containers > 0 {
237
-			idu.ActiveImages++
237
+			idu.ActiveCount++
238 238
 
239 239
 			if i.Size == -1 || i.SharedSize == -1 {
240 240
 				continue
... ...
@@ -243,7 +243,7 @@ func imageDiskUsageFromLegacyAPI(du *system.DiskUsage) ImagesDiskUsage {
243 243
 		}
244 244
 	}
245 245
 
246
-	if idu.TotalImages > 0 {
246
+	if idu.TotalCount > 0 {
247 247
 		idu.Reclaimable = idu.TotalSize - used
248 248
 	}
249 249
 
... ...
@@ -252,8 +252,8 @@ func imageDiskUsageFromLegacyAPI(du *system.DiskUsage) ImagesDiskUsage {
252 252
 
253 253
 func containerDiskUsageFromLegacyAPI(du *system.DiskUsage) ContainersDiskUsage {
254 254
 	cdu := ContainersDiskUsage{
255
-		TotalContainers: int64(len(du.Containers)),
256
-		Items:           du.Containers,
255
+		TotalCount: int64(len(du.Containers)),
256
+		Items:      du.Containers,
257 257
 	}
258 258
 
259 259
 	var used int64
... ...
@@ -261,7 +261,7 @@ func containerDiskUsageFromLegacyAPI(du *system.DiskUsage) ContainersDiskUsage {
261 261
 		cdu.TotalSize += c.SizeRw
262 262
 		switch strings.ToLower(c.State) {
263 263
 		case "running", "paused", "restarting":
264
-			cdu.ActiveContainers++
264
+			cdu.ActiveCount++
265 265
 			used += c.SizeRw
266 266
 		}
267 267
 	}
... ...
@@ -272,8 +272,8 @@ func containerDiskUsageFromLegacyAPI(du *system.DiskUsage) ContainersDiskUsage {
272 272
 
273 273
 func buildCacheDiskUsageFromLegacyAPI(du *system.DiskUsage) BuildCacheDiskUsage {
274 274
 	bdu := BuildCacheDiskUsage{
275
-		TotalBuildCacheRecords: int64(len(du.BuildCache)),
276
-		Items:                  du.BuildCache,
275
+		TotalCount: int64(len(du.BuildCache)),
276
+		Items:      du.BuildCache,
277 277
 	}
278 278
 
279 279
 	var used int64
... ...
@@ -283,7 +283,7 @@ func buildCacheDiskUsageFromLegacyAPI(du *system.DiskUsage) BuildCacheDiskUsage
283 283
 		}
284 284
 
285 285
 		if b.InUse {
286
-			bdu.ActiveBuildCacheRecords++
286
+			bdu.ActiveCount++
287 287
 			if !b.Shared {
288 288
 				used += b.Size
289 289
 			}
... ...
@@ -296,8 +296,8 @@ func buildCacheDiskUsageFromLegacyAPI(du *system.DiskUsage) BuildCacheDiskUsage
296 296
 
297 297
 func volumeDiskUsageFromLegacyAPI(du *system.DiskUsage) VolumesDiskUsage {
298 298
 	vdu := VolumesDiskUsage{
299
-		TotalVolumes: int64(len(du.Volumes)),
300
-		Items:        du.Volumes,
299
+		TotalCount: int64(len(du.Volumes)),
300
+		Items:      du.Volumes,
301 301
 	}
302 302
 
303 303
 	var used int64
... ...
@@ -305,7 +305,7 @@ func volumeDiskUsageFromLegacyAPI(du *system.DiskUsage) VolumesDiskUsage {
305 305
 		// Ignore volumes with no usage data
306 306
 		if v.UsageData != nil {
307 307
 			if v.UsageData.RefCount > 0 {
308
-				vdu.ActiveVolumes++
308
+				vdu.ActiveCount++
309 309
 				used += v.UsageData.Size
310 310
 			}
311 311
 			if v.UsageData.Size > 0 {