Browse code

use of checkers on docker_cli_restart_test.go

Signed-off-by: weiyan <weiyan3@huawei.com>

weiyan authored on 2015/10/14 18:29:13
Showing 1 changed files
... ...
@@ -4,6 +4,7 @@ import (
4 4
 	"strings"
5 5
 	"time"
6 6
 
7
+	"github.com/docker/docker/pkg/integration/checker"
7 8
 	"github.com/go-check/check"
8 9
 )
9 10
 
... ...
@@ -15,16 +16,12 @@ func (s *DockerSuite) TestRestartStoppedContainer(c *check.C) {
15 15
 	dockerCmd(c, "wait", cleanedContainerID)
16 16
 
17 17
 	out, _ = dockerCmd(c, "logs", cleanedContainerID)
18
-	if out != "foobar\n" {
19
-		c.Errorf("container should've printed 'foobar'")
20
-	}
18
+	c.Assert(out, checker.Equals, "foobar\n")
21 19
 
22 20
 	dockerCmd(c, "restart", cleanedContainerID)
23 21
 
24 22
 	out, _ = dockerCmd(c, "logs", cleanedContainerID)
25
-	if out != "foobar\nfoobar\n" {
26
-		c.Errorf("container should've printed 'foobar' twice, got %v", out)
27
-	}
23
+	c.Assert(out, checker.Equals, "foobar\nfoobar\n")
28 24
 }
29 25
 
30 26
 func (s *DockerSuite) TestRestartRunningContainer(c *check.C) {
... ...
@@ -33,22 +30,18 @@ func (s *DockerSuite) TestRestartRunningContainer(c *check.C) {
33 33
 
34 34
 	cleanedContainerID := strings.TrimSpace(out)
35 35
 
36
-	c.Assert(waitRun(cleanedContainerID), check.IsNil)
36
+	c.Assert(waitRun(cleanedContainerID), checker.IsNil)
37 37
 
38 38
 	out, _ = dockerCmd(c, "logs", cleanedContainerID)
39
-	if out != "foobar\n" {
40
-		c.Errorf("container should've printed 'foobar'")
41
-	}
39
+	c.Assert(out, checker.Equals, "foobar\n")
42 40
 
43 41
 	dockerCmd(c, "restart", "-t", "1", cleanedContainerID)
44 42
 
45 43
 	out, _ = dockerCmd(c, "logs", cleanedContainerID)
46 44
 
47
-	c.Assert(waitRun(cleanedContainerID), check.IsNil)
45
+	c.Assert(waitRun(cleanedContainerID), checker.IsNil)
48 46
 
49
-	if out != "foobar\nfoobar\n" {
50
-		c.Errorf("container should've printed 'foobar' twice")
51
-	}
47
+	c.Assert(out, checker.Equals, "foobar\nfoobar\n")
52 48
 }
53 49
 
54 50
 // Test that restarting a container with a volume does not create a new volume on restart. Regression test for #819.
... ...
@@ -58,27 +51,21 @@ func (s *DockerSuite) TestRestartWithVolumes(c *check.C) {
58 58
 
59 59
 	cleanedContainerID := strings.TrimSpace(out)
60 60
 	out, _ = dockerCmd(c, "inspect", "--format", "{{ len .Mounts }}", cleanedContainerID)
61
-
62
-	if out = strings.Trim(out, " \n\r"); out != "1" {
63
-		c.Errorf("expect 1 volume received %s", out)
64
-	}
61
+	out = strings.Trim(out, " \n\r")
62
+	c.Assert(out, checker.Equals, "1")
65 63
 
66 64
 	source, err := inspectMountSourceField(cleanedContainerID, "/test")
67
-	c.Assert(err, check.IsNil)
65
+	c.Assert(err, checker.IsNil)
68 66
 
69 67
 	dockerCmd(c, "restart", cleanedContainerID)
70 68
 
71 69
 	out, _ = dockerCmd(c, "inspect", "--format", "{{ len .Mounts }}", cleanedContainerID)
72
-	if out = strings.Trim(out, " \n\r"); out != "1" {
73
-		c.Errorf("expect 1 volume after restart received %s", out)
74
-	}
70
+	out = strings.Trim(out, " \n\r")
71
+	c.Assert(out, checker.Equals, "1")
75 72
 
76 73
 	sourceAfterRestart, err := inspectMountSourceField(cleanedContainerID, "/test")
77
-	c.Assert(err, check.IsNil)
78
-
79
-	if source != sourceAfterRestart {
80
-		c.Errorf("expected volume path: %s Actual path: %s", source, sourceAfterRestart)
81
-	}
74
+	c.Assert(err, checker.IsNil)
75
+	c.Assert(source, checker.Equals, sourceAfterRestart)
82 76
 }
83 77
 
84 78
 func (s *DockerSuite) TestRestartPolicyNO(c *check.C) {
... ...
@@ -87,10 +74,8 @@ func (s *DockerSuite) TestRestartPolicyNO(c *check.C) {
87 87
 
88 88
 	id := strings.TrimSpace(string(out))
89 89
 	name, err := inspectField(id, "HostConfig.RestartPolicy.Name")
90
-	c.Assert(err, check.IsNil)
91
-	if name != "no" {
92
-		c.Fatalf("Container restart policy name is %s, expected %s", name, "no")
93
-	}
90
+	c.Assert(err, checker.IsNil)
91
+	c.Assert(name, checker.Equals, "no")
94 92
 }
95 93
 
96 94
 func (s *DockerSuite) TestRestartPolicyAlways(c *check.C) {
... ...
@@ -99,18 +84,14 @@ func (s *DockerSuite) TestRestartPolicyAlways(c *check.C) {
99 99
 
100 100
 	id := strings.TrimSpace(string(out))
101 101
 	name, err := inspectField(id, "HostConfig.RestartPolicy.Name")
102
-	c.Assert(err, check.IsNil)
103
-	if name != "always" {
104
-		c.Fatalf("Container restart policy name is %s, expected %s", name, "always")
105
-	}
102
+	c.Assert(err, checker.IsNil)
103
+	c.Assert(name, checker.Equals, "always")
106 104
 
107 105
 	MaximumRetryCount, err := inspectField(id, "HostConfig.RestartPolicy.MaximumRetryCount")
108
-	c.Assert(err, check.IsNil)
106
+	c.Assert(err, checker.IsNil)
109 107
 
110 108
 	// MaximumRetryCount=0 if the restart policy is always
111
-	if MaximumRetryCount != "0" {
112
-		c.Fatalf("Container Maximum Retry Count is %s, expected %s", MaximumRetryCount, "0")
113
-	}
109
+	c.Assert(MaximumRetryCount, checker.Equals, "0")
114 110
 }
115 111
 
116 112
 func (s *DockerSuite) TestRestartPolicyOnFailure(c *check.C) {
... ...
@@ -119,10 +100,8 @@ func (s *DockerSuite) TestRestartPolicyOnFailure(c *check.C) {
119 119
 
120 120
 	id := strings.TrimSpace(string(out))
121 121
 	name, err := inspectField(id, "HostConfig.RestartPolicy.Name")
122
-	c.Assert(err, check.IsNil)
123
-	if name != "on-failure" {
124
-		c.Fatalf("Container restart policy name is %s, expected %s", name, "on-failure")
125
-	}
122
+	c.Assert(err, checker.IsNil)
123
+	c.Assert(name, checker.Equals, "on-failure")
126 124
 
127 125
 }
128 126
 
... ...
@@ -133,18 +112,15 @@ func (s *DockerSuite) TestContainerRestartwithGoodContainer(c *check.C) {
133 133
 	out, _ := dockerCmd(c, "run", "-d", "--restart=on-failure:3", "busybox", "true")
134 134
 
135 135
 	id := strings.TrimSpace(string(out))
136
-	if err := waitInspect(id, "{{ .State.Restarting }} {{ .State.Running }}", "false false", 5*time.Second); err != nil {
137
-		c.Fatal(err)
138
-	}
136
+	err := waitInspect(id, "{{ .State.Restarting }} {{ .State.Running }}", "false false", 5*time.Second)
137
+	c.Assert(err, checker.IsNil)
138
+
139 139
 	count, err := inspectField(id, "RestartCount")
140
-	c.Assert(err, check.IsNil)
141
-	if count != "0" {
142
-		c.Fatalf("Container was restarted %s times, expected %d", count, 0)
143
-	}
140
+	c.Assert(err, checker.IsNil)
141
+	c.Assert(count, checker.Equals, "0")
142
+
144 143
 	MaximumRetryCount, err := inspectField(id, "HostConfig.RestartPolicy.MaximumRetryCount")
145
-	c.Assert(err, check.IsNil)
146
-	if MaximumRetryCount != "3" {
147
-		c.Fatalf("Container Maximum Retry Count is %s, expected %s", MaximumRetryCount, "3")
148
-	}
144
+	c.Assert(err, checker.IsNil)
145
+	c.Assert(MaximumRetryCount, checker.Equals, "3")
149 146
 
150 147
 }