Browse code

Move TestBuildOnBuildForbiddenFromTrigger to integration-cli

Docker-DCO-1.1-Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com> (github: LK4D4)

Alexandr Morozov authored on 2014/06/17 16:36:45
Showing 2 changed files
... ...
@@ -1324,3 +1324,20 @@ func TestBuildOnBuildForbiddenChained(t *testing.T) {
1324 1324
 	}
1325 1325
 	logDone("build - onbuild forbidden chained")
1326 1326
 }
1327
+
1328
+func TestBuildOnBuildForbiddenFrom(t *testing.T) {
1329
+	name := "testbuildonbuildforbiddenfrom"
1330
+	defer deleteImages(name)
1331
+	_, err := buildImage(name,
1332
+		`FROM busybox
1333
+		ONBUILD FROM scratch`,
1334
+		true)
1335
+	if err != nil {
1336
+		if !strings.Contains(err.Error(), "FROM isn't allowed as an ONBUILD trigger") {
1337
+			t.Fatalf("Wrong error %v, must be about FROM forbidden", err)
1338
+		}
1339
+	} else {
1340
+		t.Fatal("Error must not be nil")
1341
+	}
1342
+	logDone("build - onbuild forbidden from")
1343
+}
... ...
@@ -413,20 +413,6 @@ func buildImage(context testContextTemplate, t *testing.T, eng *engine.Engine, u
413 413
 	return image, err
414 414
 }
415 415
 
416
-func TestBuildOnBuildForbiddenFromTrigger(t *testing.T) {
417
-	_, err := buildImage(testContextTemplate{`
418
-	from {IMAGE}
419
-	onbuild from {IMAGE}
420
-	`,
421
-		nil, nil,
422
-	},
423
-		t, nil, true,
424
-	)
425
-	if err == nil {
426
-		t.Fatal("Error should not be nil")
427
-	}
428
-}
429
-
430 416
 func TestBuildOnBuildForbiddenMaintainerTrigger(t *testing.T) {
431 417
 	_, err := buildImage(testContextTemplate{`
432 418
 	from {IMAGE}