Browse code

Fix few comments in validate scripts

Signed-off-by: Vincent Demeester <vincent@sbr.pm>

Vincent Demeester authored on 2015/10/10 18:21:04
Showing 4 changed files
... ...
@@ -8,7 +8,6 @@ unset IFS
8 8
 
9 9
 errors=()
10 10
 for f in "${files[@]}"; do
11
-	# we use "git show" here to validate that what's committed passes go vet
12 11
 	failedLint=$(golint "$f")
13 12
 	if [ "$failedLint" ]; then
14 13
 		errors+=( "$failedLint" )
... ...
@@ -15,7 +15,7 @@ for f in "${files[@]}"; do
15 15
 		continue
16 16
 	fi
17 17
 
18
-	# we use "git show" here to validate that what's committed is formatted
18
+	# we use "git show" here to validate that what's committed doesn't contain golang built-in testing
19 19
 	if git show "$VALIDATE_HEAD:$f" | grep -q testing.T; then
20 20
 		badFiles+=( "$f" )
21 21
 	fi
... ...
@@ -8,7 +8,7 @@ unset IFS
8 8
 
9 9
 badFiles=()
10 10
 for f in "${files[@]}"; do
11
-	# we use "git show" here to validate that what's committed is formatted
11
+	# we use "git show" here to validate that what's committed has valid toml syntax
12 12
 	if ! git show "$VALIDATE_HEAD:$f" | tomlv /proc/self/fd/0 ; then
13 13
 		badFiles+=( "$f" )
14 14
 	fi
... ...
@@ -8,7 +8,6 @@ unset IFS
8 8
 
9 9
 errors=()
10 10
 for f in "${files[@]}"; do
11
-	# we use "git show" here to validate that what's committed passes go vet
12 11
 	failedVet=$(go vet "$f")
13 12
 	if [ "$failedVet" ]; then
14 13
 		errors+=( "$failedVet" )