1. docker
  2. Commit 1dcb7d9e40d0ee5f9ab068fed55d3072246ce8ec
Browse code

Remove (?) from comments in pkg/devicemapper

Got merged with it, removing it as it doesn't add anything.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>

Vincent Demeester authored on 2015/09/30 17:35:02
Showing 3 changed files
pkg/devicemapper/devmapper.go
History View file @ 1dcb7d9
... ... 
@@ -109,7 +109,7 @@ type (
109 109 
 	}
110 110 
 	// TaskType represents a type of task
111 111 
 	TaskType int
112 
-	// AddNodeType represents a type of node to be added (?)
112 
+	// AddNodeType represents a type of node to be added
113 113 
 	AddNodeType int
114 114 
 )
115 115
... ... 
@@ -309,7 +309,7 @@ func FindLoopDeviceFor(file *os.File) *os.File {
309 309 
 	return nil
310 310 
 }
311 311
312 
-// UdevWait wakes any processes that are waiting for udev to complete the specified cookie. (?)
312 
+// UdevWait waits for any processes that are waiting for udev to complete the specified cookie.
313 313 
 func UdevWait(cookie *uint) error {
314 314 
 	if res := DmUdevWait(*cookie); res != 1 {
315 315 
 		logrus.Debugf("Failed to wait on udev cookie %d", *cookie)
... ... 
@@ -318,7 +318,7 @@ func UdevWait(cookie *uint) error {
318 318 
 	return nil
319 319 
 }
320 320
321 
-// LogInitVerbose is an interface to initialize the verbose logger for the device mapper library. (?)
321 
+// LogInitVerbose is an interface to initialize the verbose logger for the device mapper library.
322 322 
 func LogInitVerbose(level int) {
323 323 
 	DmLogInitVerbose(level)
324 324 
 }
... ... 
@@ -706,7 +706,7 @@ func ResumeDevice(name string) error {
706 706 
 	return nil
707 707 
 }
708 708
709 
-// CreateDevice creates a device with the specified poolName with the specified device id. (?)
709 
+// CreateDevice creates a device with the specified poolName with the specified device id.
710 710 
 func CreateDevice(poolName string, deviceID int) error {
711 711 
 	logrus.Debugf("[devmapper] CreateDevice(poolName=%v, deviceID=%v)", poolName, deviceID)
712 712 
 	task, err := TaskCreateNamed(deviceTargetMsg, poolName)
... ... 
@@ -735,7 +735,7 @@ func CreateDevice(poolName string, deviceID int) error {
735 735 
 	return nil
736 736 
 }
737 737
738 
-// DeleteDevice deletes a device with the specified poolName with the specified device id. (?)
738 
+// DeleteDevice deletes a device with the specified poolName with the specified device id.
739 739 
 func DeleteDevice(poolName string, deviceID int) error {
740 740 
 	task, err := TaskCreateNamed(deviceTargetMsg, poolName)
741 741 
 	if task == nil {
... ... 
@@ -763,7 +763,7 @@ func ActivateDevice(poolName string, name string, deviceID int, size uint64) err
763 763 
 }
764 764
765 765 
 // ActivateDeviceWithExternal activates the device identified by the specified
766 
-// poolName, name and deviceID with the specified size. (?)
766 
+// poolName, name and deviceID with the specified size.
767 767 
 func ActivateDeviceWithExternal(poolName string, name string, deviceID int, size uint64, external string) error {
768 768 
 	return activateDevice(poolName, name, deviceID, size, external)
769 769 
 }
pkg/devicemapper/devmapper_log.go
History View file @ 1dcb7d9
... ... 
@@ -11,7 +11,7 @@ import (
11 11 
 // Due to the way cgo works this has to be in a separate file, as devmapper.go has
12 12 
 // definitions in the cgo block, which is incompatible with using "//export"
13 13
14 
-// DevmapperLogCallback exports the devmapper log callback for cgo. (?)
14 
+// DevmapperLogCallback exports the devmapper log callback for cgo.
15 15 
 //export DevmapperLogCallback
16 16 
 func DevmapperLogCallback(level C.int, file *C.char, line C.int, dmErrnoOrClass C.int, message *C.char) {
17 17 
 	msg := C.GoString(message)
pkg/devicemapper/devmapper_wrapper.go
History View file @ 1dcb7d9
... ... 
@@ -77,7 +77,7 @@ const (
77 77 
 	LoopSetCapacity = C.LOOP_SET_CAPACITY
78 78 
 )
79 79
80 
-// LOOP consts. (?)
80 
+// LOOP consts.
81 81 
 const (
82 82 
 	LoFlagsAutoClear = C.LO_FLAGS_AUTOCLEAR
83 83 
 	LoFlagsReadOnly  = C.LO_FLAGS_READ_ONLY
... ... 
@@ -86,7 +86,7 @@ const (
86 86 
 	LoNameSize       = C.LO_NAME_SIZE
87 87 
 )
88 88
89 
-// DeviceMapper Udev consts. (?)
89 
+// Devicemapper cookie flags.
90 90 
 const (
91 91 
 	DmUdevDisableSubsystemRulesFlag = C.DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG
92 92 
 	DmUdevDisableDiskRulesFlag      = C.DM_UDEV_DISABLE_DISK_RULES_FLAG