Browse code

Move TestBuildOnBuildForbiddenChainedTrigger to integration-cli

Docker-DCO-1.1-Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com> (github: LK4D4)

Alexandr Morozov authored on 2014/06/17 16:24:47
Showing 2 changed files
... ...
@@ -1307,3 +1307,20 @@ func TestBuildOnBuild(t *testing.T) {
1307 1307
 	}
1308 1308
 	logDone("build - onbuild")
1309 1309
 }
1310
+
1311
+func TestBuildOnBuildForbiddenChained(t *testing.T) {
1312
+	name := "testbuildonbuildforbiddenchained"
1313
+	defer deleteImages(name)
1314
+	_, err := buildImage(name,
1315
+		`FROM busybox
1316
+		ONBUILD ONBUILD RUN touch foobar`,
1317
+		true)
1318
+	if err != nil {
1319
+		if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") {
1320
+			t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err)
1321
+		}
1322
+	} else {
1323
+		t.Fatal("Error must not be nil")
1324
+	}
1325
+	logDone("build - onbuild forbidden chained")
1326
+}
... ...
@@ -413,20 +413,6 @@ func buildImage(context testContextTemplate, t *testing.T, eng *engine.Engine, u
413 413
 	return image, err
414 414
 }
415 415
 
416
-func TestBuildOnBuildForbiddenChainedTrigger(t *testing.T) {
417
-	_, err := buildImage(testContextTemplate{`
418
-	from {IMAGE}
419
-	onbuild onbuild run echo test
420
-	`,
421
-		nil, nil,
422
-	},
423
-		t, nil, true,
424
-	)
425
-	if err == nil {
426
-		t.Fatal("Error should not be nil")
427
-	}
428
-}
429
-
430 416
 func TestBuildOnBuildForbiddenFromTrigger(t *testing.T) {
431 417
 	_, err := buildImage(testContextTemplate{`
432 418
 	from {IMAGE}