GitList

Browse code

d/libnetwork: fix (*Controller).getLBIndex panics

Check the serviceBinding's deleted flag to guard against the service
getting deleted before we locked its mutex, which would make it futile
to look up the load balancers. And guard against dereferencing a nil
*loadBalancer in general.

Signed-off-by: Cory Snider <csnider@mirantis.com>

Cory Snider authored on 2026/01/30 08:14:56
Showing 1 changed files

daemon/libnetwork/service_common.go index 38a313d..65d0a7c 100644

daemon/libnetwork/service_common.go

History View file @ 21dd960

@@ -160,9 +160,14 @@ func (c *Controller) getLBIndex(sid, nid string, ingressPorts []*PortConfig) int
+                     	}
                      	s.Lock()
                     +	defer s.Unlock()
                     +	if s.deleted {
                     +		return 0
                     +	}
                      	lb := s.loadBalancers[nid]
                     -	s.Unlock()
+                    -
                     +	if lb == nil {
                     +		return 0
                     +	}
                      	return int(lb.fwMark)
+                     }