Browse code

Skip tests that check max concurrency

These are not yet implemented with containerd snapshotters. We skip them
now because implementing this is not trivial with containerd.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

Djordje Lukic authored on 2023/10/03 08:25:04
Showing 1 changed files
... ...
@@ -40,6 +40,7 @@ import (
40 40
 	is "gotest.tools/v3/assert/cmp"
41 41
 	"gotest.tools/v3/icmd"
42 42
 	"gotest.tools/v3/poll"
43
+	"gotest.tools/v3/skip"
43 44
 )
44 45
 
45 46
 const containerdSocket = "/var/run/docker/containerd/containerd.sock"
... ...
@@ -2072,6 +2073,8 @@ func (s *DockerDaemonSuite) TestDaemonLogOptions(c *testing.T) {
2072 2072
 
2073 2073
 // Test case for #20936, #22443
2074 2074
 func (s *DockerDaemonSuite) TestDaemonMaxConcurrency(c *testing.T) {
2075
+	skip.If(c, testEnv.UsingSnapshotter, "max concurrency is not implemented (yet) with containerd snapshotters https://github.com/moby/moby/issues/46610")
2076
+
2075 2077
 	s.d.Start(c, "--max-concurrent-uploads=6", "--max-concurrent-downloads=8")
2076 2078
 
2077 2079
 	expectedMaxConcurrentUploads := `level=debug msg="Max Concurrent Uploads: 6"`
... ...
@@ -2084,6 +2087,8 @@ func (s *DockerDaemonSuite) TestDaemonMaxConcurrency(c *testing.T) {
2084 2084
 
2085 2085
 // Test case for #20936, #22443
2086 2086
 func (s *DockerDaemonSuite) TestDaemonMaxConcurrencyWithConfigFile(c *testing.T) {
2087
+	skip.If(c, testEnv.UsingSnapshotter, "max concurrency is not implemented (yet) with containerd snapshotters https://github.com/moby/moby/issues/46610")
2088
+
2087 2089
 	testRequires(c, testEnv.IsLocalDaemon, DaemonIsLinux)
2088 2090
 
2089 2091
 	// daemon config file
... ...
@@ -2124,6 +2129,8 @@ func (s *DockerDaemonSuite) TestDaemonMaxConcurrencyWithConfigFile(c *testing.T)
2124 2124
 
2125 2125
 // Test case for #20936, #22443
2126 2126
 func (s *DockerDaemonSuite) TestDaemonMaxConcurrencyWithConfigFileReload(c *testing.T) {
2127
+	skip.If(c, testEnv.UsingSnapshotter, "max concurrency is not implemented (yet) with containerd snapshotters https://github.com/moby/moby/issues/46610")
2128
+
2127 2129
 	testRequires(c, testEnv.IsLocalDaemon, DaemonIsLinux)
2128 2130
 
2129 2131
 	// daemon config file